Re: [PATCH 1/7] arm64: dts: imx8qm: add lvds subsystem

From: Frank Li <Frank.li@nxp.com>
To: Peng Fan <peng.fan@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/7] arm64: dts: imx8qm: add lvds subsystem
Date: Fri, 7 Jun 2024 14:52:35 -0400	[thread overview]
Message-ID: <ZmNW81FbILhkTAlg@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <AM6PR04MB5941C0BBD0A64A9AFDD8EC5A88FB2@AM6PR04MB5941.eurprd04.prod.outlook.com>

On Fri, Jun 07, 2024 at 01:28:35AM +0000, Peng Fan wrote:
> > Subject: [PATCH 1/7] arm64: dts: imx8qm: add lvds subsystem
> > 
> > Add irqstear, pwm and i2c in lvds subsystem.
> 
> irqsteer
> 
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi | 231
> > ++++++++++++++++++++++
> >  arch/arm64/boot/dts/freescale/imx8qm.dtsi         |   1 +
> >  2 files changed, 232 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi
> > b/arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi
> > new file mode 100644
> > index 0000000000000..eb8208cddeaf9
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-lvds.dtsi
> > @@ -0,0 +1,231 @@
> > +// SPDX-License-Identifier: GPL-2.0+
> 
> GPL-2.0-only and MIT?
> 
> > +
> > +/*
> > + * Copyright 2024 NXP
> > + */
> > +
> > +/{
> > +
> > +	lvds1_ipg_clk: lvds0_ipg_clk: clock-controller-lvds-ipg {
> 
> Two alias name?

It is alllowed by dt. link to one fixed 24M clock. of course we can change
lvds1_ipg_clk to lvds0_ipg_clk.

To avoid confuse, I'd better use two name to align node nams.

Frank

> 
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <24000000>;
> > +		clock-output-names = "lvds0_ipg_clk";
> > +	};
> > +
> 
> Regards,
> Peng.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel