From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C1EBC27C5E for ; Mon, 10 Jun 2024 09:19:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WfABYbZaorCcg08o6IvxylMXh5k0+vSynwMtb+Iykzg=; b=TWs4D8rzy1S28K Q3AB64gp1tCJ0Aow1IKUke35e3i6L2UI3OPnHBBJSKsLGuB9mERGg6H3bjmKsCPtJ+cZAsv1k71QU OQLCDqrl36q6BQlLrOxkGsK/VZV3yN/zEpzeaqtL1ick/NRd9nPgbfVeUB+eBPLeiBW8NSFHFpF6D RR4rTJdIGjWHSxSUtk4RP3T4GGsh/0e7u2k7Bweb88Nc9H1ymDAjGj6erYpT4DtdDkHknev4U/GLk Xa7KQq7ACMrqWuULfrrVGXOhoysDVZrY+Th/9DBZ0jyEXOlQ2XoW9NXcguZRFrZUR4/iW1bw0rhph nz3YfYh0JrRBCSSJaXNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGbB0-00000004Qiv-3FJB; Mon, 10 Jun 2024 09:18:54 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGbAx-00000004QPA-1PEz for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 09:18:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=cm5RXgxrGyPx0HOxnj0oADHLpbubFzGyui01dq/eV+M=; b=aYT+xqOMm+MujVFCcpmFNmy578 TZcFmLK5hZ+5E2C1Yxnh9/hB8Uscvw7lDygmSQiSEZSVQN8veiUgHamVOpCSvvmTQqRoLno+P7SXe Pa3TgT7KxaDVZ2Hr4pKozzH/9l84aU20hSSHxgboUyKaqkng7Sv3G+bCzr04bU/A0Wt18IpiEBtai QoHMnocJlztKS2UgS6JiYXMqiLg5N7qC+hBQyutJFjyzeDYZ3CXQSrlJfIFodTTEyHw4rId6s2LCx N4RwKLvxQxHcsQqd81urbHiD8FW7D7xTGULLFdXCPZ37COcquJ/MmVyBOvc6RqoHTi8FaG91mC/6e QGgnIsAw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59778) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sGb8e-0001DJ-2T; Mon, 10 Jun 2024 10:16:28 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sGb8e-0006lD-BD; Mon, 10 Jun 2024 10:16:28 +0100 Date: Mon, 10 Jun 2024 10:16:28 +0100 From: "Russell King (Oracle)" To: Andrew Halaney Cc: Serge Semin , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC net-next v2 1/8] net: stmmac: add infrastructure for hwifs to provide PCS Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_021851_398421_904EBEE9 X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2024 at 02:57:34PM -0500, Andrew Halaney wrote: > On Fri, May 31, 2024 at 12:26:15PM GMT, Russell King (Oracle) wrote: > > @@ -310,6 +315,9 @@ struct stmmac_ops { > > void (*core_init)(struct mac_device_info *hw, struct net_device *dev); > > /* Update MAC capabilities */ > > void (*update_caps)(struct stmmac_priv *priv); > > + /* Get phylink PCS (for MAC */ > > nit: unclosed parenthesis Please learn to trim your review replies so your patch submitters don't have to waste time scroll through lots of useless context. This has been part of good netiquette for decades. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel