From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 421A4C27C5F for ; Mon, 10 Jun 2024 09:20:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qDH6PvvLYbzH8kVkdwmkN4y0A4KvzYPnENWZ6l9E9GE=; b=li5yi6b5N9BPbV fdiLvJcqbOrYg2gODgpe0PcMR4jePAWG8X44uVKpkGu3BUaMLFksOT56Umrrmu//j9Ehg/Svf3Gye 0xkSY5nbN9QWb8XGSJ5Mg3eUYZXrTRrKrFrGc1/4M4NCT/RHBX/0fvXMjdAcPyMGcymjhoxJkUk3C v22XYqAOey65fdZ9ckTCzvWAC/k41japTLLU/MyUOZZMnkphmjQuFa8Wggt7Z5fSeOQCNEoX0E2Hm 9RCHlDY5mkpqwD5xzKZDL47jELOLSmiDiGRFHZEhuQvu8KwF0SVSvmBNPTeuVrZgMKi0FpkZs+0vr pSnIBeMZqfXQrM4Ay2KQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGbBy-00000004Qqf-1Sfx; Mon, 10 Jun 2024 09:19:54 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGbBv-00000004Qq4-3ZNc for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 09:19:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ikVClAmxiAK9GuPcVRzMsjEeJjGHTMRE/DJvy6XjAFY=; b=C4phnXKbiu0jdrPxeKv5kQMRzD lNLth5EKWGiks2RnT1wVBw6i9ySdrmULlZ+zY4CESU/2rlSzHzWfIsO9MRjIev/icitJ7EKRLZ2EB 9KlRhcDI73yfuZswh2dk6z/1zV2zf7IJ6upCFdZ4bVookr6sAVHY+10XuM6gEPEcq4SygNSVEfGp+ UaoKj1XjrcqIDkgojFp9IAoQq7ETrK9QNAc0unA/q5iXhqPbLgrdm/0HFdJ4zYi3h9mBkrqrfdJil k9O0TQHtBLJvuvPkwIycBvO8apzm5nt/Jf0B8DEv1iSStkKf1R1GN5oG66P8smsRv7CSPnYguGJfw LGnSy8kg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:46210) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sGbBh-0001Dt-1o; Mon, 10 Jun 2024 10:19:37 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sGbBj-0006lP-8Y; Mon, 10 Jun 2024 10:19:39 +0100 Date: Mon, 10 Jun 2024 10:19:39 +0100 From: "Russell King (Oracle)" To: Andrew Halaney Cc: Serge Semin , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC net-next v2 3/8] net: stmmac: dwmac1000: convert sgmii/rgmii "pcs" to phylink Message-ID: References: <6n4xvu6b43aptstdevdkzx2uqblwabaqndle2omqx5tcxk4lnz@wm3zqdrcr6m5> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6n4xvu6b43aptstdevdkzx2uqblwabaqndle2omqx5tcxk4lnz@wm3zqdrcr6m5> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_021951_913174_50D3F403 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2024 at 03:05:43PM -0500, Andrew Halaney wrote: > On Fri, May 31, 2024 at 12:26:25PM GMT, Russell King (Oracle) wrote: > > @@ -335,8 +303,12 @@ static int dwmac1000_irq_status(struct mac_device_info *hw, > > > > dwmac_pcs_isr(ioaddr, GMAC_PCS_BASE, intr_status, x); > > > > - if (intr_status & PCS_RGSMIIIS_IRQ) > > - dwmac1000_rgsmii(ioaddr, x); > > + if (intr_status & PCS_RGSMIIIS_IRQ) { > > + /* TODO Dummy-read to clear the IRQ status */ > > + readl(ioaddr + GMAC_RGSMIIIS); > > This seems to me that you're doing the TODO here? Maybe I'm > misunderstanding... maybe not :) Please trim your replies. These two lines come from Serge - please ask him why it's marked as a TODO. I assume he has a reason. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel