From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1B424C27C5E for ; Mon, 10 Jun 2024 09:24:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q2l4CAeFz4iUkYO6UNGYHDUB2e3L2DHF+Zw0Lflq8hc=; b=CJPWstpPaDCX1O xwdzCVRJmALD77AKpX6sBQ5eoIQfgBWCisDl5czXrw8MA7owYSgjdZO6vzZs0jv0CJtwRX7bCBmny ENVeaRVZbO03YjTIHkA0SvZcA7zhRKizobWj0oPJqiXecywdLN6CpHwhxGV3KmFBUTrTbMwu6D4ox AivF4TU9cjbYq6x0QCSgTkfQ37NefUQcLiB545gay2E4Pny4fxqixRq9RN+0zUKavC5fdMWY2CU2F 5KPZiXnxJSgk4YawxXD2kCLa/7KU8UJWGlrObjCAL15xnzo7FAGLKoe/IQwD40tBwU06vmhYmSNet 3cPaVdqHxSecHK1mXNjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGbGW-00000004Rw2-1HEp; Mon, 10 Jun 2024 09:24:36 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGbGT-00000004Ruy-07p7 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 09:24:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ia89vxLEHsjxSOnYnkE5CVk6E9NLeLG5CVMk/7Pv5aQ=; b=gWKnx8ln8WyqO2KHfLJhbYL82+ M1+6mgxQ8fboi7A9pGxTgeeTQE5lY26ZRGsha8DuNeHWbhjR/xV2mM9BIj8RqoEj8MDUYNuRrRHCB 8UVjxeA18PE6dPf90Z5QKtbNQG3OMB46Dc9YkkIvgH8Gbv/+2wrQBVXNpaCW/mv5Z8NX0VYmtZBGR sHYzQNTrB3yJEG3eQtO4fdJiVUw2mGm2gl+L2+VGMcKhB0tpV5W2kIXOka9bDU9uvVK/RcofZhYkN TiVzr2f05L1iipPvCMMByOa2+3MaiKC8FgX1Xt9f3mCb/5B7oCyro/mQR2M7gZH0c6S5MQXbYT6nY bAue5opA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:47070) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sGbGE-0001EV-1D; Mon, 10 Jun 2024 10:24:18 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sGbGF-0006lX-TT; Mon, 10 Jun 2024 10:24:19 +0100 Date: Mon, 10 Jun 2024 10:24:19 +0100 From: "Russell King (Oracle)" To: Andrew Halaney Cc: Serge Semin , Alexandre Torgue , Jose Abreu , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH RFC net-next v2 3/8] net: stmmac: dwmac1000: convert sgmii/rgmii "pcs" to phylink Message-ID: References: <6n4xvu6b43aptstdevdkzx2uqblwabaqndle2omqx5tcxk4lnz@wm3zqdrcr6m5> <6qpcartwgkgdmtxwj4puxn2exbpiv6t6fxv2b3kecu6ezzdogs@yii3j3xtougr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6qpcartwgkgdmtxwj4puxn2exbpiv6t6fxv2b3kecu6ezzdogs@yii3j3xtougr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_022433_094716_EE30579B X-CRM114-Status: GOOD ( 14.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 05, 2024 at 04:59:14PM -0500, Andrew Halaney wrote: > On Wed, Jun 05, 2024 at 03:05:43PM GMT, Andrew Halaney wrote: > > This seems to me that you're doing the TODO here? Maybe I'm > > misunderstanding... maybe not :) > > > > > + phylink_pcs_change(&hw->mac_pcs, false); > > Continuing to read through this all, sorry for the double reply and > possibly dumb question. Should we be passing in false unconditionally > here? It depends whether there is a way to get the current status of the link without side effects (e.g. where a read clears a latched-low link status.) If that's not possible, then passing "false" is safe provided there aren't any spurious interrupts, since we'll always assume that the link has dropped. If there are spurious interrupts, then the link will go down/up each time there's a spurious interrupt. Even so, that's better than missing a change in the link status which may result in loss of link without manual intervention. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel