From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61EBAC27C55 for ; Mon, 10 Jun 2024 11:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EVNWSi6Nmg5osDVo5YoCzBHsEQChjhXRs86gc1ux3lY=; b=qdktN8Jerjci5j Tu4n7Ef9s5BKrDkPmrrVYIxubNWFPd6SHgnL+W5868UlJjnlAdl7TBsMPGKH5phUurX6RBIIihndQ vU/RNv85/z1T3PzJHjVN0q690H8hhOUxLpRLQZzhNomKHMbLe3KLUZzacLO8K2X1TbTnQH/xTl6xk Br0pDUKMPg/6ajA/sHZxnWbF0o5CGw7XBScdKRMMSOKVM5b/VLgoL0JhHrgDgdT5n3NcLyZDV1nHV JlUFAlRsSI7YavgwvSQOoJ+lKDcYupnP4AmihSPODTEY2kYxuY10fDQiF41S/MmBvctDQagTWxWYe mzJ13KZa/AhDZ/Cprd3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGd8t-00000004nv3-3Kfj; Mon, 10 Jun 2024 11:24:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sGd8q-00000004nuC-0cRw for linux-arm-kernel@lists.infradead.org; Mon, 10 Jun 2024 11:24:50 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E07E112FC; Mon, 10 Jun 2024 04:25:09 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 141F23F73B; Mon, 10 Jun 2024 04:24:41 -0700 (PDT) Date: Mon, 10 Jun 2024 12:24:39 +0100 From: Mark Rutland To: "Rob Herring (Arm)" Cc: Russell King , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Will Deacon , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Catalin Marinas , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev Subject: Re: [PATCH 7/9] arm64: perf/kvm: Use a common PMU cycle counter define Message-ID: References: <20240607-arm-pmu-3-9-icntr-v1-0-c7bd2dceff3b@kernel.org> <20240607-arm-pmu-3-9-icntr-v1-7-c7bd2dceff3b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240607-arm-pmu-3-9-icntr-v1-7-c7bd2dceff3b@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240610_042448_287876_0CBBCFF0 X-CRM114-Status: GOOD ( 17.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 07, 2024 at 02:31:32PM -0600, Rob Herring (Arm) wrote: > The PMUv3 and KVM code each have a define for the PMU cycle counter > index. Move KVM's define to a shared location and use it for PMUv3 > driver. > > Signed-off-by: Rob Herring (Arm) > --- > arch/arm/include/asm/arm_pmuv3.h | 2 ++ > arch/arm64/include/asm/arm_pmuv3.h | 2 ++ > arch/arm64/kvm/sys_regs.c | 1 + > drivers/perf/arm_pmuv3.c | 23 +++++++++-------------- > include/kvm/arm_pmu.h | 1 - > 5 files changed, 14 insertions(+), 15 deletions(-) > > diff --git a/arch/arm/include/asm/arm_pmuv3.h b/arch/arm/include/asm/arm_pmuv3.h > index a41b503b7dcd..ac2cf37b57e3 100644 > --- a/arch/arm/include/asm/arm_pmuv3.h > +++ b/arch/arm/include/asm/arm_pmuv3.h > @@ -9,6 +9,8 @@ > #include > #include > > +#define ARMV8_PMU_CYCLE_IDX 31 > + > #define PMCCNTR __ACCESS_CP15_64(0, c9) > > #define PMCR __ACCESS_CP15(c9, 0, c12, 0) > diff --git a/arch/arm64/include/asm/arm_pmuv3.h b/arch/arm64/include/asm/arm_pmuv3.h > index 1ed91334fede..46930729fb3f 100644 > --- a/arch/arm64/include/asm/arm_pmuv3.h > +++ b/arch/arm64/include/asm/arm_pmuv3.h > @@ -11,6 +11,8 @@ > #include > #include > > +#define ARMV8_PMU_CYCLE_IDX 31 I think we can define this in , rather than needing separate definitions for arm/arm64. > diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c > index f8b5db48ea8a..22393ae7ce14 100644 > --- a/arch/arm64/kvm/sys_regs.c > +++ b/arch/arm64/kvm/sys_regs.c > @@ -18,6 +18,7 @@ > #include > #include > > +#include > #include > #include > #include ... so we'd need to change the include here, but the rest of this patch looks good as-is. Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel