* [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
@ 2024-06-04 17:14 Hari Nagalla
2024-06-05 7:20 ` Krzysztof Kozlowski
2024-06-10 17:26 ` Mathieu Poirier
0 siblings, 2 replies; 3+ messages in thread
From: Hari Nagalla @ 2024-06-04 17:14 UTC (permalink / raw)
To: andersson, mathieu.poirier, robh+dt, devarsht, s-anna,
krzysztof.kozlowski+dt, conor+dt
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, devicetree
The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
does not have an addressable l1dram . So, remove this optional sram
property from the bindings to fix device tree build warnings.
Signed-off-by: Hari Nagalla <hnagalla@ti.com>
---
Changes in v3:
*) Use allOf keyword with separate ifs for each variant instead
of nested if/else conditions.
v2: https://lore.kernel.org/all/20240530164816.1051-1-hnagalla@ti.com/
.../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 89 +++++++++++--------
1 file changed, 51 insertions(+), 38 deletions(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
index 9768db8663eb..b51bb863d759 100644
--- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
@@ -25,9 +25,6 @@ description: |
host processor (Arm CorePac) to perform the device management of the remote
processor and to communicate with the remote processor.
-allOf:
- - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
-
properties:
compatible:
enum:
@@ -89,41 +86,57 @@ properties:
should be defined as per the generic bindings in,
Documentation/devicetree/bindings/sram/sram.yaml
-if:
- properties:
- compatible:
- enum:
- - ti,j721e-c66-dsp
-then:
- properties:
- reg:
- items:
- - description: Address and Size of the L2 SRAM internal memory region
- - description: Address and Size of the L1 PRAM internal memory region
- - description: Address and Size of the L1 DRAM internal memory region
- reg-names:
- items:
- - const: l2sram
- - const: l1pram
- - const: l1dram
-else:
- if:
- properties:
- compatible:
- enum:
- - ti,am62a-c7xv-dsp
- - ti,j721e-c71-dsp
- - ti,j721s2-c71-dsp
- then:
- properties:
- reg:
- items:
- - description: Address and Size of the L2 SRAM internal memory region
- - description: Address and Size of the L1 DRAM internal memory region
- reg-names:
- items:
- - const: l2sram
- - const: l1dram
+allOf:
+ - if:
+ properties:
+ compatible:
+ enum:
+ - ti,j721e-c66-dsp
+ then:
+ properties:
+ reg:
+ items:
+ - description: Address and Size of the L2 SRAM internal memory region
+ - description: Address and Size of the L1 PRAM internal memory region
+ - description: Address and Size of the L1 DRAM internal memory region
+ reg-names:
+ items:
+ - const: l2sram
+ - const: l1pram
+ - const: l1dram
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - ti,j721e-c71-dsp
+ - ti,j721s2-c71-dsp
+ then:
+ properties:
+ reg:
+ items:
+ - description: Address and Size of the L2 SRAM internal memory region
+ - description: Address and Size of the L1 DRAM internal memory region
+ reg-names:
+ items:
+ - const: l2sram
+ - const: l1dram
+
+ - if:
+ properties:
+ compatible:
+ enum:
+ - ti,am62a-c7xv-dsp
+ then:
+ properties:
+ reg:
+ items:
+ - description: Address and Size of the L2 SRAM internal memory region
+ reg-names:
+ items:
+ - const: l2sram
+
+ - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
required:
- compatible
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
2024-06-04 17:14 [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs Hari Nagalla
@ 2024-06-05 7:20 ` Krzysztof Kozlowski
2024-06-10 17:26 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2024-06-05 7:20 UTC (permalink / raw)
To: Hari Nagalla, andersson, mathieu.poirier, robh+dt, devarsht,
s-anna, krzysztof.kozlowski+dt, conor+dt
Cc: linux-remoteproc, linux-kernel, linux-arm-kernel, devicetree
On 04/06/2024 19:14, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> Changes in v3:
> *) Use allOf keyword with separate ifs for each variant instead
> of nested if/else conditions.
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs
2024-06-04 17:14 [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs Hari Nagalla
2024-06-05 7:20 ` Krzysztof Kozlowski
@ 2024-06-10 17:26 ` Mathieu Poirier
1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2024-06-10 17:26 UTC (permalink / raw)
To: Hari Nagalla
Cc: devicetree, conor+dt, devarsht, andersson, linux-remoteproc,
linux-kernel, robh+dt, krzysztof.kozlowski+dt, linux-arm-kernel
On Tue, Jun 04, 2024 at 12:14:50PM -0500, Hari Nagalla wrote:
> The C7xv-dsp on AM62A have 32KB L1 I-cache and a 64KB L1 D-cache. It
> does not have an addressable l1dram . So, remove this optional sram
> property from the bindings to fix device tree build warnings.
>
> Signed-off-by: Hari Nagalla <hnagalla@ti.com>
> ---
> Changes in v3:
> *) Use allOf keyword with separate ifs for each variant instead
> of nested if/else conditions.
>
> v2: https://lore.kernel.org/all/20240530164816.1051-1-hnagalla@ti.com/
>
> .../bindings/remoteproc/ti,k3-dsp-rproc.yaml | 89 +++++++++++--------
> 1 file changed, 51 insertions(+), 38 deletions(-)
>
Applied
Thanks,
Mathieu
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> index 9768db8663eb..b51bb863d759 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> @@ -25,9 +25,6 @@ description: |
> host processor (Arm CorePac) to perform the device management of the remote
> processor and to communicate with the remote processor.
>
> -allOf:
> - - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
> -
> properties:
> compatible:
> enum:
> @@ -89,41 +86,57 @@ properties:
> should be defined as per the generic bindings in,
> Documentation/devicetree/bindings/sram/sram.yaml
>
> -if:
> - properties:
> - compatible:
> - enum:
> - - ti,j721e-c66-dsp
> -then:
> - properties:
> - reg:
> - items:
> - - description: Address and Size of the L2 SRAM internal memory region
> - - description: Address and Size of the L1 PRAM internal memory region
> - - description: Address and Size of the L1 DRAM internal memory region
> - reg-names:
> - items:
> - - const: l2sram
> - - const: l1pram
> - - const: l1dram
> -else:
> - if:
> - properties:
> - compatible:
> - enum:
> - - ti,am62a-c7xv-dsp
> - - ti,j721e-c71-dsp
> - - ti,j721s2-c71-dsp
> - then:
> - properties:
> - reg:
> - items:
> - - description: Address and Size of the L2 SRAM internal memory region
> - - description: Address and Size of the L1 DRAM internal memory region
> - reg-names:
> - items:
> - - const: l2sram
> - - const: l1dram
> +allOf:
> + - if:
> + properties:
> + compatible:
> + enum:
> + - ti,j721e-c66-dsp
> + then:
> + properties:
> + reg:
> + items:
> + - description: Address and Size of the L2 SRAM internal memory region
> + - description: Address and Size of the L1 PRAM internal memory region
> + - description: Address and Size of the L1 DRAM internal memory region
> + reg-names:
> + items:
> + - const: l2sram
> + - const: l1pram
> + - const: l1dram
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - ti,j721e-c71-dsp
> + - ti,j721s2-c71-dsp
> + then:
> + properties:
> + reg:
> + items:
> + - description: Address and Size of the L2 SRAM internal memory region
> + - description: Address and Size of the L1 DRAM internal memory region
> + reg-names:
> + items:
> + - const: l2sram
> + - const: l1dram
> +
> + - if:
> + properties:
> + compatible:
> + enum:
> + - ti,am62a-c7xv-dsp
> + then:
> + properties:
> + reg:
> + items:
> + - description: Address and Size of the L2 SRAM internal memory region
> + reg-names:
> + items:
> + - const: l2sram
> +
> + - $ref: /schemas/arm/keystone/ti,k3-sci-common.yaml#
>
> required:
> - compatible
> --
> 2.34.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-10 17:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 17:14 [PATCH v3] dt-bindings: remoteproc: k3-dsp: correct optional sram properties for AM62A SoCs Hari Nagalla
2024-06-05 7:20 ` Krzysztof Kozlowski
2024-06-10 17:26 ` Mathieu Poirier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).