From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11614C27C53 for ; Wed, 12 Jun 2024 14:30:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LV3THBchGf1nyX4WaDCE6tNBFycyZa9nRIZ8SRGdEWM=; b=mZ50fSZP4i6Up42/iLtQ5L79hr qw9Gard4eiJa9cMXnn49zYTKaYdedywKEc6lgZKve84OqXlv8XAhyNmN3nRkfml98q0k5/cWnAksD GCVRksSt6QKqQaLuvWTpRP5kC0+kg02RpDHrBwoeI0abrRHNLyJwAGbCrV5l0dZFQIinhfwY7C+uG fd/Zwb4jqU+gIyHeCmjtXvUGAfgyWU59tOG1LUWGfAe4vMDiJ2SH5zWixUWJ6cLzOZCoEP9nW/1Mg +hTpJpuLvawr8bgUn59Y2cHIS8Rp1aFYRLsIporLur/Jo5uW4ceiOCBIqVaV6tu7EWSxyrnoHb5Ac 9usBnqMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHOzo-0000000Cx51-0aEN; Wed, 12 Jun 2024 14:30:40 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHOzk-0000000Cx3t-0xMt for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 14:30:38 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C17621042; Wed, 12 Jun 2024 07:30:59 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CFB943F64C; Wed, 12 Jun 2024 07:30:31 -0700 (PDT) Date: Wed, 12 Jun 2024 15:30:29 +0100 From: Sudeep Holla To: Sebastian Ene Cc: catalin.marinas@arm.com, james.morse@arm.com, jean-philippe@linaro.org, Sudeep Holla , maz@kernel.org, oliver.upton@linux.dev, qperret@google.com, qwandor@google.com, suzuki.poulose@arm.com, tabba@google.com, will@kernel.org, yuzenghui@huawei.com, lpieralisi@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 2/4] KVM: arm64: Add support for FFA_PARTITION_INFO_GET Message-ID: References: <20240515172258.1680881-1-sebastianene@google.com> <20240515172258.1680881-3-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515172258.1680881-3-sebastianene@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_073036_332401_5FC61595 X-CRM114-Status: GOOD ( 10.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 15, 2024 at 05:22:56PM +0000, Sebastian Ene wrote: > Handle the FFA_PARTITION_INFO_GET host call inside the pKVM hypervisor > and copy the response message back to the host buffers. > > Save the returned FF-A version as we will need it later to interpret the > response from the TEE. > I don't understand the context of the above statement and this patch. Did you mean use the saved version to take apt action/decision within FFA_PARTITION_INFO_GET handler. Or is it just missed cleanup ? The change itself looks good. Reviewed-by: Sudeep Holla -- Regards, Sudeep