From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6503C27C77 for ; Wed, 12 Jun 2024 14:38:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bCrxt2my4m4yrSCXVplFBO+/qFMZHZ9RKEK/ZDlmOM4=; b=Cn8gJ9uW1flkfQYt+BU/prtYnt nzCEzIryiJ5dnJZqHvl5mHL4lLwBwusX5YKdjxKejJ3NN2H41Ett/ZQBeb1AzKqAR/bFeVxGcBJa6 eU6O8PCEIL1nGS6AjB+GLlIgDguyFZL8Hgh+h9f3/IGV+r8NxUY8fYzYV3QWPkeTzYpVur/tMqK+k lxi9haEsjrreIdK+cqTIZLcFEZ0C/hY33/eVYHkhkUyYEedDUTz4cDhw8uTNa43q14C5sAf8JLOgq Lx9g8xQu2NfArhwpLLSrTXov75Ks6QJvfEqKOIRm//NsUYUwLdD6taGYse3UTynkUY3b0YcJgmNwj drC2vVrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHP7T-0000000CyXo-0Suv; Wed, 12 Jun 2024 14:38:35 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHP7Q-0000000CyXK-2AHP for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 14:38:33 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42D121063; Wed, 12 Jun 2024 07:38:56 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EC7633F64C; Wed, 12 Jun 2024 07:38:28 -0700 (PDT) Date: Wed, 12 Jun 2024 15:38:26 +0100 From: Sudeep Holla To: Sebastian Ene Cc: catalin.marinas@arm.com, james.morse@arm.com, jean-philippe@linaro.org, Sudeep Holla , maz@kernel.org, oliver.upton@linux.dev, qperret@google.com, qwandor@google.com, suzuki.poulose@arm.com, tabba@google.com, will@kernel.org, yuzenghui@huawei.com, lpieralisi@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 3/4] KVM: arm64: Fix the identification range for the FF-A smcs Message-ID: References: <20240515172258.1680881-1-sebastianene@google.com> <20240515172258.1680881-4-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240515172258.1680881-4-sebastianene@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_073832_754085_E59DFF21 X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, May 15, 2024 at 05:22:57PM +0000, Sebastian Ene wrote: > The FF-A spec 1.2 reserves the following ranges for identifying FF-A > calls: > 0x84000060-0x840000FF: FF-A 32-bit calls > 0xC4000060-0xC40000FF: FF-A 64-bit calls. > > Use the range identification according to the spec and allow calls that > are currently out of the range(eg. FFA_MSG_SEND_DIRECT_REQ2) to be > identified correctly. > Reviewed-by: Sudeep Holla Not sure if this needs to be fixes though. With addition of notifications in the FF-A driver(since v6.7), host can send FF-A messages beyond 0x7F. But since the pKVM FF-A proxy support is not yet updated to v1.1, so I don't think it needs to be tagged as fix. Just thought I will mention it here anyways. -- Regards, Sudeep