From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7109C27C75 for ; Wed, 12 Jun 2024 18:11:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:Cc:To:From: Subject:Message-ID:References:Mime-Version:In-Reply-To:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bysuRKx6ASJn7sotbzdgYdmXjsZucWIObzR9RYJqi4M=; b=nLaNzSqm2gmpGNjkY6fd05XcfV 2mTNOBKjm5u9kq9dBFRFfGdpDBNNcZB5bagkN/KHemPQG7JxxeivvGkzDbw52sQ0WCBU1lfmKD2CO iJqpJ/nPCg5JGR9JvQvIAUZzoQ+0A3Y3JUllM9ord5dpNQHXR36ReIIljyU8R69/+CbKLBcuQ7drY dK5UE466I2ePzD0+4XQlJdYaBw/U6bv974Pd0hxvzTHSoVEo9qnhSYPADHd+DBg9WI/qdKh/Dy8iP 1ss/M13/FtE872EuHd98pPYr4nHN9wfczmGUCrvmc1OEs4SNoPo5J47ZDy/mb3qep3kB6gYHiqqEI WTCDeXCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHSR8-0000000Dfch-2Tzg; Wed, 12 Jun 2024 18:11:06 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHSR5-0000000DfaT-3TKd for linux-arm-kernel@lists.infradead.org; Wed, 12 Jun 2024 18:11:05 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-627dd6a56caso2360607b3.3 for ; Wed, 12 Jun 2024 11:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718215860; x=1718820660; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=bysuRKx6ASJn7sotbzdgYdmXjsZucWIObzR9RYJqi4M=; b=Ep8ZHNaKaI95G5s+lJUxNtkN6Hr6Fnes1zzBrL4X3gVph71AxRtwC6eiZBPxLamiqf 2FsfUjRrTehe/g9SoyycVwxVHe7uArBTFGM2jMqhPZZixQUDOnLjs9/FxdFXdwvsfHxW ojhvsEKwCq4K8c/iJ0clPi9D8WLliEScW+kdC4BAUPcdth2mLygOP9kMSYYnqYnMgukN DFNJsx66mHseaaBCy7S+0IBi13FNpSMtOv4wzS9/bcMfQRG6PgfAk+nACLbw4xFQ7kBQ dRWiI5Vk+cSNB9C4TLqWp9zXuwqGp7X9NUEdp1R4xDOCu4MetTFk+fbZWcdT2Gqb4jrh hcaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718215860; x=1718820660; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bysuRKx6ASJn7sotbzdgYdmXjsZucWIObzR9RYJqi4M=; b=WKQT6Jou/Zp75ip9HtcgPgRusvARZo3QlGxQhLJxkE+X3JJ6zUPtmHU4vF0n2cHLkW BdHkIpcOka+EtdoQALxHpbje+kjfSMI1hJJzwv4GPtvbalBjsGgEy2qqS2dDYgrLV4H8 wxy7yAg5OzZUAVtoKyusbuhtOKKH2Zbj/9LtUOOHG4QFfqIsDr4HzrzibkBNg86Q2R58 dbJ3DxZe226yreens97WsmgrpErtKrDJiRnnDDu1plKglChToO+xblO+HYxW1FZQwjTW Lh3jbde4SKeB1k8pczhpPcCgbAqjznqVlhhJjLp/4lEFOwSo6R+OWdfcYBOHkbCzkf9q hyHw== X-Forwarded-Encrypted: i=1; AJvYcCWT81abivvWP3JfsyoDaq952rW5q1DlhK8+ziLCzoppfttdl4MV6zQGgL2WUEJdskS7wNlqTIZb1XMShqluuVNwOF94gYcd/ijV80khFTSBDzBH2zM= X-Gm-Message-State: AOJu0YyuQgCg9Y47GODmXmbSRLWliGjhSLxo15a4/RlVKyRc58p7obHp wsGRI7Hh6TuP5D6GZ9KbiO+otX7oWwGg42sI7FF1GaXxDPDpwaOCpou0Bqyod0eiGxq4OTyal8k wNQ== X-Google-Smtp-Source: AGHT+IFdlsyNfCopJx9MGc/lpAH0uLI55vrBd5uBQ720M/Quh9qtzfjG5LFD+1WcYsruY1pOCRVfaawqImE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:b19b:0:b0:de4:654f:9ad0 with SMTP id 3f1490d57ef6-dfe66b65b58mr79044276.6.1718215860399; Wed, 12 Jun 2024 11:11:00 -0700 (PDT) Date: Wed, 12 Jun 2024 11:10:58 -0700 In-Reply-To: <6bd821a3-9dbe-499c-ae17-afce70076299@arm.com> Mime-Version: 1.0 References: <20240612104500.425012-1-usama.anjum@collabora.com> <6bd821a3-9dbe-499c-ae17-afce70076299@arm.com> Message-ID: Subject: Re: [PATCH 1/2] selftests: kvm: remove print_skip() From: Sean Christopherson To: Dev Jain Cc: Muhammad Usama Anjum , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Shuah Khan , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , Haibo Xu , Anup Patel , Andrew Jones , Aaron Lewis , Thomas Huth , Maciej Wieczor-Retman , Vitaly Kuznetsov , kernel@collabora.com, Shuah Khan , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_111103_918903_1F66F25B X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 12, 2024, Dev Jain wrote: > > On 6/12/24 16:14, Muhammad Usama Anjum wrote: > > > > > > diff --git a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > > index 4f5881d4ef66d..695c45635d257 100644 > > --- a/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > > +++ b/tools/testing/selftests/kvm/x86_64/hyperv_cpuid.c > > @@ -144,10 +144,9 @@ int main(int argc, char *argv[]) > > free((void *)hv_cpuid_entries); > > if (!kvm_cpu_has(X86_FEATURE_VMX) || > > - !kvm_has_cap(KVM_CAP_HYPERV_ENLIGHTENED_VMCS)) { > > - print_skip("Enlightened VMCS is unsupported"); > > - goto do_sys; > > - } > > + !kvm_has_cap(KVM_CAP_HYPERV_ENLIGHTENED_VMCS)) > > + ksft_exit_skip("Enlightened VMCS is unsupported\n"); > > + > > Isn't it incorrect to delete 'goto do_sys'? ksft_exit_skip() will exit and the > program will never jump to that label. At other places too you have deleted the 'goto'. Ya, exiting instead of continuing on will break these tests.