From: Sebastian Ene <sebastianene@google.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: catalin.marinas@arm.com, james.morse@arm.com,
jean-philippe@linaro.org, maz@kernel.org, oliver.upton@linux.dev,
qperret@google.com, qwandor@google.com, suzuki.poulose@arm.com,
tabba@google.com, will@kernel.org, yuzenghui@huawei.com,
lpieralisi@kernel.org, kvmarm@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel-team@android.com
Subject: Re: [PATCH v2 2/4] KVM: arm64: Add support for FFA_PARTITION_INFO_GET
Date: Thu, 13 Jun 2024 12:29:00 +0000 [thread overview]
Message-ID: <ZmrmDHEoZoOXmSd4@google.com> (raw)
In-Reply-To: <ZmmxBWIerq5Durve@bogus>
On Wed, Jun 12, 2024 at 03:30:29PM +0100, Sudeep Holla wrote:
> On Wed, May 15, 2024 at 05:22:56PM +0000, Sebastian Ene wrote:
> > Handle the FFA_PARTITION_INFO_GET host call inside the pKVM hypervisor
> > and copy the response message back to the host buffers.
> >
> > Save the returned FF-A version as we will need it later to interpret the
> > response from the TEE.
> >
> I don't understand the context of the above statement and this patch.
> Did you mean use the saved version to take apt action/decision within
> FFA_PARTITION_INFO_GET handler. Or is it just missed cleanup ?
This is a missed cleanup I will drop this part from the commit message.
Thanks,
Seb
>
> The change itself looks good.
>
> Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
>
> --
> Regards,
> Sudeep
next prev parent reply other threads:[~2024-06-13 12:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 17:22 [PATCH v2 0/4] KVM: arm64: pKVM host proxy FF-A fixes Sebastian Ene
2024-05-15 17:22 ` [PATCH v2 1/4] KVM: arm64: Trap FFA_VERSION host call in pKVM Sebastian Ene
2024-06-12 13:58 ` Sudeep Holla
2024-06-13 11:55 ` Sebastian Ene
2024-05-15 17:22 ` [PATCH v2 2/4] KVM: arm64: Add support for FFA_PARTITION_INFO_GET Sebastian Ene
2024-06-12 14:30 ` Sudeep Holla
2024-06-13 12:29 ` Sebastian Ene [this message]
2024-05-15 17:22 ` [PATCH v2 3/4] KVM: arm64: Fix the identification range for the FF-A smcs Sebastian Ene
2024-06-12 14:38 ` Sudeep Holla
2024-06-13 12:37 ` Sebastian Ene
2024-05-15 17:22 ` [PATCH v2 4/4] KVM: arm64: Use FF-A 1.1 with pKVM Sebastian Ene
2024-06-12 14:41 ` Sudeep Holla
2024-06-12 14:46 ` [PATCH v2 0/4] KVM: arm64: pKVM host proxy FF-A fixes Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZmrmDHEoZoOXmSd4@google.com \
--to=sebastianene@google.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=jean-philippe@linaro.org \
--cc=kernel-team@android.com \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=qperret@google.com \
--cc=qwandor@google.com \
--cc=sudeep.holla@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=tabba@google.com \
--cc=will@kernel.org \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).