From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8927AC27C4F for ; Thu, 13 Jun 2024 12:29:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J0fEuFqzalyC11tgCJL2olWAZeSZgE1wRxfqpcISgXM=; b=ZK5aHOnHuvSWocX3aD7yanE3Fz SftHvw/mlHnyNXoYaxut87ZWCHg+NQqnkkHc40sG/5Qcl91prmVNjUq+h9yTrubnS/Szh1hzr12cn z/5mGxymG2E9eHHgJKexsFFGgKx5UFn4IOATbZo7pSIXv+XrI53c2h6FyVd9gfet0o+g2UbjTXSM8 a0lsvu+6zym70Lkn5/SRp34fJRzOuie4VywIod2rSQrBRCyL53dgAEA/K3EcCM2zevJWjZVJkANlV b/ZlMb2NbsOWmKNySGB733J9PjNXEH++Lg81Hy3PhoFV+gWQZ5aeDTwBta6YqrNckvwCr7L0wGZ3E DHwiJOsg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHjZo-0000000GVd9-3srm; Thu, 13 Jun 2024 12:29:12 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHjZm-0000000GVcD-0tyM for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 12:29:12 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4216d9952d2so78495e9.0 for ; Thu, 13 Jun 2024 05:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1718281744; x=1718886544; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J0fEuFqzalyC11tgCJL2olWAZeSZgE1wRxfqpcISgXM=; b=gZUulGvYXtN6Zn/XQEwCs3/ZaE9fFWDnjh15SWowjqQ6KnU6pYn/eui+LCdb57gYED TQKKKrhSRn5/76fzq08K1HZzKohibiQjDQjloW/sgANn0cxQMdK7eyXpnm4XouuUJ4NH KaShHCG6bAvbRPLHEnimTTs/1lbAjUecrJUKVVdD5vxsvLVtMRETGTVuuVNOODYNpPaO SGzBoRiFs/iMvM4CskS4ckyEWNNX5dR4m91vmciuCNx2pgGcxnd6MvPwoFdn/d0aaVSM +qwxEiY15MP8k3iJO6YmTGtvUHS6TwnQMHTzu6KG2uMbcFF28JU8+YRdPX+IU8Cn6JC9 JB9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718281744; x=1718886544; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J0fEuFqzalyC11tgCJL2olWAZeSZgE1wRxfqpcISgXM=; b=Uo80aBbd5j4wBW/iuHsQ/kL6YdTQU6NHosPk12o/pWEx8/zs+Vf5IPDsjHxVLQKw99 jPEIaczgSeCc3Fyw1OWwxxaHQC1P0mYaDdfE9Frvvgr+hm4kULB/dZgWnbaQFk855eTU y/+yXfm2icAFKZkQAbpUHDqJzpLsZU2xrrJTPA3ugJu5dxaNYpkMVm2jx2XScg+iJWy3 GAZdIVWBMQtxj7WJ3xWR6qKDMvVOsJVHtlMM0TS+Kb0ewTFS95GhNx0hw+xCH1xvHmLV dtE4dna6LUAxKTDOwhcBRcRSCb5epJQYahyu0msEFE/nBBN4BmbF2r3TM/vBQ++jt5Z3 AbCA== X-Forwarded-Encrypted: i=1; AJvYcCVTA0B2zlOJmCyqUvISgExtHtI+viGqjv6FdyDGi5tdjLvL+CcF/s8W5PnErlm+iXgmHn8OnatJj6R7dJysLw//fr+KBVMYrAiU2Z5vMPsuNe1SMUM= X-Gm-Message-State: AOJu0Yxa0tbT53Tf/SujnuYtuplX4oZZJkgHV937fV2yJsrEtpo6TH2x 0qIuTvOoCIjJ0xORrIswRBNQWMoGhLdHCJrfQxLmnLM+8I39jP6ZZSxSB/35Dw== X-Google-Smtp-Source: AGHT+IEYwF3dbYa8WWBR2FOETBShap+ZaRRBpIecfX014Bk1dlr42J+E8CnlmGuDyWnxRW8ohwrAxQ== X-Received: by 2002:a05:600c:1e1c:b0:41b:4c6a:de7a with SMTP id 5b1f17b1804b1-422f2aba180mr1330895e9.3.1718281743540; Thu, 13 Jun 2024 05:29:03 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52ca390b493sm133521e87.161.2024.06.13.05.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 05:29:02 -0700 (PDT) Date: Thu, 13 Jun 2024 12:29:00 +0000 From: Sebastian Ene To: Sudeep Holla Cc: catalin.marinas@arm.com, james.morse@arm.com, jean-philippe@linaro.org, maz@kernel.org, oliver.upton@linux.dev, qperret@google.com, qwandor@google.com, suzuki.poulose@arm.com, tabba@google.com, will@kernel.org, yuzenghui@huawei.com, lpieralisi@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v2 2/4] KVM: arm64: Add support for FFA_PARTITION_INFO_GET Message-ID: References: <20240515172258.1680881-1-sebastianene@google.com> <20240515172258.1680881-3-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_052910_276427_D964EC74 X-CRM114-Status: GOOD ( 16.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 12, 2024 at 03:30:29PM +0100, Sudeep Holla wrote: > On Wed, May 15, 2024 at 05:22:56PM +0000, Sebastian Ene wrote: > > Handle the FFA_PARTITION_INFO_GET host call inside the pKVM hypervisor > > and copy the response message back to the host buffers. > > > > Save the returned FF-A version as we will need it later to interpret the > > response from the TEE. > > > I don't understand the context of the above statement and this patch. > Did you mean use the saved version to take apt action/decision within > FFA_PARTITION_INFO_GET handler. Or is it just missed cleanup ? This is a missed cleanup I will drop this part from the commit message. Thanks, Seb > > The change itself looks good. > > Reviewed-by: Sudeep Holla > > -- > Regards, > Sudeep