From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4494C27C6E for ; Thu, 13 Jun 2024 17:19:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=cwcCGDwb60DzgqVPFb1/1oCx//cSi4Srw7sRj+1jaLY=; b=GghBFXM0+mLMx5LIV5njTVt5+Y 6OSpCi498D5gsqNYvrwZkRw507WSyHtL1yfIBF1pQiHq6a+QgxdpnGAwHxi+ymBQ24myvVFqj5C7g 2MdNNvIrz+1uSe71ost7Jq05UQ+0w8VZ7dFRsd7owYC8l/1UW5NwjJjzoKmi/p4A6WEDlZTOWYIud zqwf6MR76Rontor7vQ6zNrcQjr28v6AttJltNxuIiL/0VDQVTw7vNuF/u/crg/VHTN28ebmoeFRVK Kh156nDytR01AlRnqqFcrkuOXIkmBPXzoz9iLdPvmo975dlLmxZQvWkNUx1RHufVKI1P/gB6ln5dC 6+aEQE7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHo67-0000000HUfN-2RSu; Thu, 13 Jun 2024 17:18:51 +0000 Received: from mail-ed1-x535.google.com ([2a00:1450:4864:20::535]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHo64-0000000HUef-3vbg for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 17:18:50 +0000 Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-57c76497cefso1447297a12.1 for ; Thu, 13 Jun 2024 10:18:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718299125; x=1718903925; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=cwcCGDwb60DzgqVPFb1/1oCx//cSi4Srw7sRj+1jaLY=; b=UfmUM6Rk2exHnsWYtD8Edz2MZsPfid7p6uOlqAL4puzo20s8PpjxtCqyikttz10c/p /j0dA0nohec3sOBvCypduqQifO1yEE8QFUJf9KKR1AKDXC47dgac88+l4Xln389wehYD fEJo4sCjwKN9uBz41qc8gqXOOguRM3XQZd3DF07pI8f+olHoRJNhrjiok20PjVWU9tJd 3Lsy5AXjiI8kO8B4w3GW27s2ETfFi7sf/mwV5o6MNRKh8/S8F5eTX6yMrkwQavm1FUx5 whCjhPrPWOB+XMLj4c2JHJJsuMSpLUy3qy8G/8ggPC+e1nsoQmaGXhtgyqFZZWsfsDfC s7qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718299125; x=1718903925; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cwcCGDwb60DzgqVPFb1/1oCx//cSi4Srw7sRj+1jaLY=; b=SBE3XoazXuj6cOW3dTEb4pvzIlxTj2Tvb4LF/UENsK2lntVImpW7NR2jJrJsbUllR5 NM7EuKuf+RbhYGdluVhYqXQjyM22RcLthTgUAMisjQhWVELjdQf7O+ri3e0cHM5UBC5S N75KgSCIMmaEVl91b+vLH9d3FWJdC1QPYK19GAJ3j6Tc0fKkCJYlnliJvikx/jd3BxLf zXY2rPKyqXRS9CuZ9aMlt6s1K7vYDD3+d5Z8ND+7wi8hirPw3EOTE/1yoJzzvtz9L4uU dE8l+jAzySxf+K9RGFAuvXxMFC+RjT2UvkQJJ2nLjN8Uven8u8pPO7OyfxupyZqPa7uB hbTw== X-Forwarded-Encrypted: i=1; AJvYcCWnugKObqot5wl7avW6a47AZLKim2VyPhKHdDJKc0Gsq8CluKczNp8stpRBvVeigdNtRBk8qVB2ACRLdu7k3tRjcaAS733AxH8bAo8svV3+E6bEwK8= X-Gm-Message-State: AOJu0Yx5EvBApK15mQ9KCL9R2wC1Uq8b4mdXlC0zKzlbyaKHKimr/VKJ ZeNA6sj2qqAc/EQAeM7CPfP6o65qQ65/mfn4KGyxD9yuvgcw68IA X-Google-Smtp-Source: AGHT+IGdIR8K+VU7ZoWeYaXJouZP25nKSmNr2Ci+hRTo46h3PKiZ1ed05PMzYhGyYbF+2HCHDXPaJw== X-Received: by 2002:a50:8e18:0:b0:57a:2fe7:6699 with SMTP id 4fb4d7f45d1cf-57cbd66272cmr286625a12.14.1718299125009; Thu, 13 Jun 2024 10:18:45 -0700 (PDT) Received: from standask-GA-A55M-S2HP (lu-nat-113-247.ehs.sk. [188.123.113.247]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57cb741e7a5sm1139124a12.75.2024.06.13.10.18.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 10:18:44 -0700 (PDT) Date: Thu, 13 Jun 2024 19:18:42 +0200 From: Stanislav Jakubek To: Konrad Dybcio Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: dts: qcom: motorola-falcon: add accelerometer, magnetometer Message-ID: References: <2b39d763-5b79-4b21-85f9-22fee9f87468@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <2b39d763-5b79-4b21-85f9-22fee9f87468@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_101848_999864_0D4825EB X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2024 at 09:48:26AM +0200, Konrad Dybcio wrote: > > > On 6/9/24 13:05, Stanislav Jakubek wrote: > > Add the accelerometer and magnetometer that are present on the Motorola > > Moto G (2013) device. > > > > Signed-off-by: Stanislav Jakubek > > --- > > [...] > > > +&blsp1_i2c2 { > > Consider setting a clock-frequency = <> Hi Konrad, checking downstream [1], qcom,i2c-bus-freq for I2C2 is 100000, which seems to be the default. Should I specify it anyway? Though, now that I've checked, it seems that I missed the clock-frequency for I2C3, for which qcom,i2c-bus-freq is 400000... The currently supported HW on it seems to work fine though ¯\_(ツ)_/¯ [1] https://github.com/LineageOS/android_kernel_motorola_msm8226/blob/cm-14.1/arch/arm/boot/dts/msm8226.dtsi#L983 Stanislav > > With that: > > Reviewed-by: Konrad Dybcio > > Konrad