From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1A62C27C6E for ; Fri, 14 Jun 2024 09:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=iY8ehRkWaH2JjiB9a7NlFmskLSkzFS9rgA/CRQpSFqg=; b=fELc+InPp60p1MJQmc0ty1h+Pq pJGgEuJjs4uWAy0xQfethGbsw3X0rGaGpROBCPznmm5ey480dYHuk0S1jIIbHpistDkkfJ1gc/YJj 1Mb43oboegnuyuTChP/JEuRNp+3H/FNqSV4j9EDbnr3YeHnUuAyZ+zHDwPXEeVCuJv1WDwQfRoakM EArj6l5oqsZ/8MYfbOWL4uQhjJmSXKBg23d9g/o6uTZNAU7kGr4vAvrm7erNPf1oUl5J5HqJMQ9jR w1g8l+h4KndvgNJ42ue5JL/Hk2WPna1Eyz0EXoNRokwLEA5hQg1v5lsDd6VUR4gDmb8WujVH4YTbT IRXN0nOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI368-000000029ZL-1HbG; Fri, 14 Jun 2024 09:19:52 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI365-000000029Yh-326E for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 09:19:51 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 47D68339; Fri, 14 Jun 2024 02:20:10 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6730F3F5A1; Fri, 14 Jun 2024 02:19:44 -0700 (PDT) Date: Fri, 14 Jun 2024 10:19:42 +0100 From: Sudeep Holla To: "Peng Fan (OSS)" Cc: Cristian Marussi , Rob Herring , Sudeep Holla , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 2/2] firmware: arm_scmi: mailbox: support P2A channel completion Message-ID: References: <20240510-scmi-notify-v2-0-e994cf14ef86@nxp.com> <20240510-scmi-notify-v2-2-e994cf14ef86@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240510-scmi-notify-v2-2-e994cf14ef86@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240614_021949_855006_E7F6BB69 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 10, 2024 at 11:19:48AM +0800, Peng Fan (OSS) wrote: There was some coding style error reported(unbalanced {}) which made me look at the code again. I don't think we need to splat out error. > @@ -300,8 +326,30 @@ static void mailbox_fetch_notification(struct scmi_chan_info *cinfo, > static void mailbox_clear_channel(struct scmi_chan_info *cinfo) > { > struct scmi_mailbox *smbox = cinfo->transport_info; > + struct device *cdev = cinfo->dev; > + struct mbox_chan *intr; > + int ret; > > shmem_clear_channel(smbox->shmem); > + > + if (!shmem_channel_intr_enabled(smbox->shmem)) > + return; > + > + if (smbox->chan_platform_receiver) > + intr = smbox->chan_platform_receiver; > + else if (smbox->chan) > + intr = smbox->chan; > + else { > + dev_err(cdev, "Channel INTR wrongly set?\n"); > + return; > + } > If it is OK I would like to fix it up with below change. Regards, Sudeep -->8 diff --git i/drivers/firmware/arm_scmi/mailbox.c w/drivers/firmware/arm_scmi/mailbox.c index adb69a6a0223..3bb3fba8f478 100644 --- i/drivers/firmware/arm_scmi/mailbox.c +++ w/drivers/firmware/arm_scmi/mailbox.c @@ -326,30 +326,25 @@ static void mailbox_fetch_notification(struct scmi_chan_info *cinfo, static void mailbox_clear_channel(struct scmi_chan_info *cinfo) { struct scmi_mailbox *smbox = cinfo->transport_info; - struct device *cdev = cinfo->dev; - struct mbox_chan *intr; + struct mbox_chan *intr_chan = NULL; int ret; shmem_clear_channel(smbox->shmem); - if (!shmem_channel_intr_enabled(smbox->shmem)) - return; - if (smbox->chan_platform_receiver) - intr = smbox->chan_platform_receiver; + intr_chan = smbox->chan_platform_receiver; else if (smbox->chan) - intr = smbox->chan; - else { - dev_err(cdev, "Channel INTR wrongly set?\n"); + intr_chan = smbox->chan; + + if (!(intr_chan && shmem_channel_intr_enabled(smbox->shmem))) return; - } - ret = mbox_send_message(intr, NULL); + ret = mbox_send_message(intr_chan, NULL); /* mbox_send_message returns non-negative value on success, so reset */ if (ret > 0) ret = 0; - mbox_client_txdone(intr, ret); + mbox_client_txdone(intr_chan, ret); } static bool