From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7559C27C6E for ; Fri, 14 Jun 2024 10:32:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CHlSH+hqjVejMN5xne7Jq9z4n5KMuq35ucu90RpcjDY=; b=w0psAm5F9eEmtmmmJnju+EMSTB lmqrKxzxvaSl2+m87zf/qGpfr48QXxTDez9a5cb4i87TskNkUh8fmLH3V5+D9PD8sPB2oooWOjeAG +wIPilt99lOeHOqw82Xem2GTXGoMHRflDQK+9MT6Oq60blA04wyeXuEH4k81roANcYTs77aJ3WHKT g7KgyStZbCzSZkQZYmibnkuFDpe4zooMNp4D03MYqjq8sCkQCLWr8ZT0GBLrPmf6GN4vx1sUMQv+z GufHqOZyeoYKKRP/qtuVn7yC+4KH/mk3Xf3YpR1L1o9dyEkcxDAJGiqzWmkLezt2y131RD1r9YyxO szgyGsbw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI4EP-00000002S17-2F40; Fri, 14 Jun 2024 10:32:29 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI4Dm-00000002RmE-2sVT for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 10:31:54 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3A6911480; Fri, 14 Jun 2024 03:32:12 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2EC633F5A1; Fri, 14 Jun 2024 03:31:45 -0700 (PDT) Date: Fri, 14 Jun 2024 11:31:43 +0100 From: Cristian Marussi To: Sudeep Holla Cc: "Peng Fan (OSS)" , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 2/2] firmware: arm_scmi: mailbox: support P2A channel completion Message-ID: References: <20240510-scmi-notify-v2-0-e994cf14ef86@nxp.com> <20240510-scmi-notify-v2-2-e994cf14ef86@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240614_033151_659266_A4E81473 X-CRM114-Status: GOOD ( 21.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2024 at 10:19:42AM +0100, Sudeep Holla wrote: > On Fri, May 10, 2024 at 11:19:48AM +0800, Peng Fan (OSS) wrote: > > There was some coding style error reported(unbalanced {}) which made me > look at the code again. I don't think we need to splat out error. > > > @@ -300,8 +326,30 @@ static void mailbox_fetch_notification(struct scmi_chan_info *cinfo, > > static void mailbox_clear_channel(struct scmi_chan_info *cinfo) > > { > > struct scmi_mailbox *smbox = cinfo->transport_info; > > + struct device *cdev = cinfo->dev; > > + struct mbox_chan *intr; > > + int ret; > > > > shmem_clear_channel(smbox->shmem); > > + > > + if (!shmem_channel_intr_enabled(smbox->shmem)) > > + return; > > + > > + if (smbox->chan_platform_receiver) > > + intr = smbox->chan_platform_receiver; > > + else if (smbox->chan) > > + intr = smbox->chan; > > + else { > > + dev_err(cdev, "Channel INTR wrongly set?\n"); > > + return; > > + } > > > > If it is OK I would like to fix it up with below change. > Hi, > Regards, > Sudeep > > -->8 > > diff --git i/drivers/firmware/arm_scmi/mailbox.c w/drivers/firmware/arm_scmi/mailbox.c > index adb69a6a0223..3bb3fba8f478 100644 > --- i/drivers/firmware/arm_scmi/mailbox.c > +++ w/drivers/firmware/arm_scmi/mailbox.c > @@ -326,30 +326,25 @@ static void mailbox_fetch_notification(struct scmi_chan_info *cinfo, > static void mailbox_clear_channel(struct scmi_chan_info *cinfo) > { > struct scmi_mailbox *smbox = cinfo->transport_info; > - struct device *cdev = cinfo->dev; > - struct mbox_chan *intr; > + struct mbox_chan *intr_chan = NULL; > int ret; > > shmem_clear_channel(smbox->shmem); > > - if (!shmem_channel_intr_enabled(smbox->shmem)) > - return; > - > if (smbox->chan_platform_receiver) > - intr = smbox->chan_platform_receiver; > + intr_chan = smbox->chan_platform_receiver; > else if (smbox->chan) > - intr = smbox->chan; > - else { > - dev_err(cdev, "Channel INTR wrongly set?\n"); > + intr_chan = smbox->chan; > + > + if (!(intr_chan && shmem_channel_intr_enabled(smbox->shmem))) > return; > - } Fine with dropping the dev_err() but is not this cumulative negated-if a bit cryptic...also you can bail out early straight away as before when platform has not required any P2A completion irq...I mean something like struct mbox_chan *intr_chan = NULL; shmem_clear_channel(smbox->shmem); if (!shmem_channel_intr_enabled(smbox->shmem)) return; if (smbox->chan_platform_receiver) intr_chan = smbox->chan_platform_receiver; else if (smbox->chan) intr_chan = smbox->chan; if (!intr_chan) return; (or just a dangling else return;) .. no strongs opinion here really, though. Thanks, Cristian