From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85D1CC27C6E for ; Fri, 14 Jun 2024 11:20:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DMXr4IBj4BPkkNnA/ZtQPdtOikhhO84fIhpTn9lH/5M=; b=BRqc/FDICqKvNOl+pbspJl9v07 ckjhpzKcm+ifNCeKv50kGR8Puoeel5m2lGuo7KMU8Zz7xWtf3whA+RiPSRDxeBQPd2pMFua8SVBdq HDVbBk/ibhOfYmY63v/3wKXRF1c/1k01mPU6wyyQhCAeIYqNAgMVX/n55BF70yzgqZojIY0AEwFvo Ei3loOwFDCzU1L1JGg2ThV8P7aJdIEdenBEjJsdlSNXHI6JFoSrwt2v178Hbc7kj9PBiSs7Nrk20v 7SxEEynZxMf+eVpxZ/zzdGcPP5fwwatUjo8zQSp9A+c2iC639eYck8F1TSJQQBxbcYb7DTtzt3sKj ZYyBmgYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI4yM-00000002ZlO-06Ou; Fri, 14 Jun 2024 11:19:58 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sI4yJ-00000002Zkm-2oQx for linux-arm-kernel@lists.infradead.org; Fri, 14 Jun 2024 11:19:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FC3DFEC; Fri, 14 Jun 2024 04:20:19 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 68D153F5A1; Fri, 14 Jun 2024 04:19:53 -0700 (PDT) Date: Fri, 14 Jun 2024 12:19:51 +0100 From: Sudeep Holla To: Cristian Marussi Cc: "Peng Fan (OSS)" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH v2 2/2] firmware: arm_scmi: mailbox: support P2A channel completion Message-ID: References: <20240510-scmi-notify-v2-0-e994cf14ef86@nxp.com> <20240510-scmi-notify-v2-2-e994cf14ef86@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240614_041955_779869_F58965DA X-CRM114-Status: GOOD ( 15.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 14, 2024 at 11:31:43AM +0100, Cristian Marussi wrote: > On Fri, Jun 14, 2024 at 10:19:42AM +0100, Sudeep Holla wrote: > > > > diff --git i/drivers/firmware/arm_scmi/mailbox.c w/drivers/firmware/arm_scmi/mailbox.c > > index adb69a6a0223..3bb3fba8f478 100644 > > --- i/drivers/firmware/arm_scmi/mailbox.c > > +++ w/drivers/firmware/arm_scmi/mailbox.c > > @@ -326,30 +326,25 @@ static void mailbox_fetch_notification(struct scmi_chan_info *cinfo, > > static void mailbox_clear_channel(struct scmi_chan_info *cinfo) > > { > > struct scmi_mailbox *smbox = cinfo->transport_info; > > - struct device *cdev = cinfo->dev; > > - struct mbox_chan *intr; > > + struct mbox_chan *intr_chan = NULL; > > int ret; > > > > shmem_clear_channel(smbox->shmem); > > > > - if (!shmem_channel_intr_enabled(smbox->shmem)) > > - return; > > - > > if (smbox->chan_platform_receiver) > > - intr = smbox->chan_platform_receiver; > > + intr_chan = smbox->chan_platform_receiver; > > else if (smbox->chan) > > - intr = smbox->chan; > > - else { > > - dev_err(cdev, "Channel INTR wrongly set?\n"); > > + intr_chan = smbox->chan; > > + > > + if (!(intr_chan && shmem_channel_intr_enabled(smbox->shmem))) > > return; > > - } > > Fine with dropping the dev_err() but is not this cumulative negated-if a > bit cryptic...also you can bail out early straight away as before when > platform has not required any P2A completion irq...I mean something like > Agreed, updated now. -- Regards, Sudeep