From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 594DCC2BD09 for ; Thu, 27 Jun 2024 07:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LsbeIB50EDgsPrzDnKsKFJzpQszBkOYrVjadj/myF5I=; b=OKTYKHWLxgXE2J6qLlBDSItiOG Ww5yyObIe+LgVE6MF4wiIc2gf4EgLL46z62TxVqzmMuCdwwgorW53IqoRvtEDsxGUsf9fb0KDRVvg XxT5MrprxS2hZcqrYrPM0FEc3qX0H6w5Kb/2DjVXaXuDDTDvEclzV1b2UUBXMuYc1IRnQSzFnOElj DucuGbtzdHHCx/I/DzbpB6TE3Kx6PjRwuGoXSOV8xc/L1IxRcljQJkM7nbhuJz3/YPYkx79A1Vm4X dnn6BbEU6OXSXOjX1h7UnY/Vq1MhUBzptzTMkB6/+OWKXd5s7uxEnJg0e1MA21AN6MeCBnxZzrM+k ItbraWKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMjGv-00000009VOG-2WgH; Thu, 27 Jun 2024 07:10:21 +0000 Received: from mail-m16.yeah.net ([220.197.32.17]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMjGm-00000009VMH-3bXd for linux-arm-kernel@lists.infradead.org; Thu, 27 Jun 2024 07:10:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Date:From:Subject:Message-ID:MIME-Version: Content-Type; bh=LsbeIB50EDgsPrzDnKsKFJzpQszBkOYrVjadj/myF5I=; b=PIRaZpEY1NCT+/kZFp4m1lILrLLOfrExLn06eRaO3hABYjq8151HKppNRBLPVt ulsfL9045x2oscTS+0V8/SoaEQXz167ylV/O1KLVnDQ891muiaGbkSoPFOOIHBcE n7mycWSqtGTekBzHRT6vvDR8DDeku14OgOuaTWJYk/Vhs= Received: from dragon (unknown [114.218.218.47]) by gzsmtp2 (Coremail) with SMTP id Ms8vCgD3v8ltDX1mxG8aAA--.52621S3; Thu, 27 Jun 2024 14:57:51 +0800 (CST) Date: Thu, 27 Jun 2024 14:57:48 +0800 From: Shawn Guo To: Francesco Dolcini Cc: Vitor Soares , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Vitor Soares , devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] arm64: dts: imx8mm-verdin: add TPM device Message-ID: References: <20240613134150.318755-1-ivitro@gmail.com> <20240617071842.GA4832@francesco-nb> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240617071842.GA4832@francesco-nb> X-CM-TRANSID: Ms8vCgD3v8ltDX1mxG8aAA--.52621S3 X-Coremail-Antispam: 1Uf129KBjvJXoW7WF17XF15Kw15uFyxtF1fJFb_yoW8Wr4Dpr WSkFs5J397Xr43Cr9Iqwn7ur9xKa1fAr4Duwn8KryUtrnIvF98GF1xGr1xur1q9r4fA3yF kF15ZryS9w1rAw7anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x07jO8nOUUUUU= X-Originating-IP: [114.218.218.47] X-CM-SenderInfo: pvkd40hjxrjqh1hdxhhqhw/1tbiEQ8LZWZv-cwmYgAAsM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240627_001013_575993_2E572283 X-CRM114-Status: GOOD ( 18.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2024 at 09:18:42AM +0200, Francesco Dolcini wrote: > Hello Shawn, > > On Mon, Jun 17, 2024 at 10:33:50AM +0800, Shawn Guo wrote: > > On Thu, Jun 13, 2024 at 02:41:50PM +0100, Vitor Soares wrote: > > > From: Vitor Soares > > > > > > Add TPM device found on Verdin iMX8M Mini PID4 0090 variant. > > > > > > Signed-off-by: Vitor Soares > > > --- > > > arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi | 16 +++++++++++----- > > > 1 file changed, 11 insertions(+), 5 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > index 4768b05fd765..c9ae5f0bb526 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mm-verdin.dtsi > > > @@ -227,15 +227,16 @@ &ecspi2 { > > > pinctrl-0 = <&pinctrl_ecspi2>; > > > }; > > > > > > -/* Verdin CAN_1 (On-module) */ > > > +/* On-module SPI */ > > > &ecspi3 { > > > #address-cells = <1>; > > > #size-cells = <0>; > > > - cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>; > > > + cs-gpios = <&gpio5 25 GPIO_ACTIVE_LOW>, <&gpio4 19 GPIO_ACTIVE_LOW>; > > > pinctrl-names = "default"; > > > - pinctrl-0 = <&pinctrl_ecspi3>; > > > + pinctrl-0 = <&pinctrl_ecspi3>, <&pinctrl_pmic_tpm_ena>; > > > > Would it make more sense to have tpm pinctrl in node tpm@1 below? > It's the pinctrl of the SPI Chip Select pin, not something about the > TPM, I think it's correct to have it into the ecspi node. The name pinctrl_pmic_tpm_ena seems confusing then. Shawn