From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6A14C2BBCA for ; Fri, 28 Jun 2024 08:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CoqLK0pSHJR5RDSkfTZVfRoBJY6Q+VQSpGdo91tIRT8=; b=yVhT8py54NVlEIfAxzgOIsa0Qu FecIX/kdhhOJWOOx+fmLP4LQzTLMAWtHYbUytntLSW1XUsXU4uVXUyUq/pOUhAmR9RkbmtNOsaE0Q 43T64F3ffWux6/SIg3WKlJsPm4gPS79Nke9baj+CXxvM/1eyzHn6gqmSpRM7UQ/KB4dNW9uexbBQl hZC4xHB0/W4oGw18Upynmr6cZjequB2bXh9xXZ4GiP+idzydnkEbdCI+E8z5Nj2TTQZ1hQDdg4kNz G45qENABbGnpfO2aMogHgW2VpSHH45kRzt22Ca3fzgCuzHzEKtAiK2o0iA0VisO8zDV9AVm0/4fRn s7Okk+3A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6hM-0000000D1XD-0LWJ; Fri, 28 Jun 2024 08:11:12 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sN6hD-0000000D1Um-1HEq for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 08:11:04 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 616C562094; Fri, 28 Jun 2024 08:11:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5F23C116B1; Fri, 28 Jun 2024 08:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719562262; bh=qH0hUeJp5WdywexB7qHSHvkmDo/Ev7rR2aoYaZNMI5o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KsX4zqa0BRH73ZVGwqcnwn0JCbyHSAucP2Edj4cnc23buK7a2nT9Wek38SInslxRl glYvthHmIs4Y2W85caJa0m+63U7lwSOOPBWDURc8RF4Brpq8dRN0dNnzklpKelImv1 jfD6JWUu1xCvBUjx212nZnaC39UnUn4lwAV/AZQv2gbOhdMy+qVVxV5ckDFj+9Vu5g x1t8+X9aSU9Xlmhd0zFc4+Es6FAOa5eg5hSNKT98tQWTCcgoA41VejCFSxKsov9FbU ivRqXuq+6Urm9sKsPCjpa+P9Dk2ckmW+apN+WGtpbS7N3VhTo0WKLfiR6xZnTXHXDO 5jaPu/vjSV9LA== Date: Fri, 28 Jun 2024 10:10:58 +0200 From: Lorenzo Bianconi To: Rob Herring Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, rkannoth@marvell.com, sgoutham@marvell.com, andrew@lunn.ch Subject: Re: [PATCH v3 net-next 1/2] dt-bindings: net: airoha: Add EN7581 ethernet controller Message-ID: References: <20240627221007.GA646876-robh@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mE1ojJjZZ6/R0duQ" Content-Disposition: inline In-Reply-To: <20240627221007.GA646876-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_011103_469050_34F785BF X-CRM114-Status: GOOD ( 20.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --mE1ojJjZZ6/R0duQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > On Sun, Jun 23, 2024 at 06:19:56PM +0200, Lorenzo Bianconi wrote: > > Introduce device-tree binding documentation for Airoha EN7581 ethernet > > mac controller. > >=20 > > Signed-off-by: Lorenzo Bianconi > > --- > > .../bindings/net/airoha,en7581-eth.yaml | 108 ++++++++++++++++++ > > 1 file changed, 108 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/airoha,en7581= -eth.yaml > >=20 > > diff --git a/Documentation/devicetree/bindings/net/airoha,en7581-eth.ya= ml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > new file mode 100644 > > index 000000000000..e25a462a75d4 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > @@ -0,0 +1,108 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/airoha,en7581-eth.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Airoha EN7581 Frame Engine Ethernet controller > > + > > +allOf: > > + - $ref: ethernet-controller.yaml# > > + > > +maintainers: > > + - Lorenzo Bianconi > > + > > +description: > > + The frame engine ethernet controller can be found on Airoha SoCs. > > + These SoCs have dual GMAC ports. > > + > > +properties: > > + compatible: > > + enum: > > + - airoha,en7581-eth > > + > > + reg: > > + items: > > + - description: Frame engine base address > > + - description: QDMA0 base address > > + - description: QDMA1 base address > > + > > + reg-names: > > + items: > > + - const: fe > > + - const: qdma0 > > + - const: qdma1 > > + > > + interrupts: > > + maxItems: 10 >=20 > You need to define what each interrupt is. Just like 'reg'. ack, I will fix it in v4. >=20 > > + > > + resets: > > + maxItems: 8 > > + > > + reset-names: > > + items: > > + - const: fe > > + - const: pdma > > + - const: qdma > > + - const: xsi-mac > > + - const: hsi0-mac > > + - const: hsi1-mac > > + - const: hsi-mac > > + - const: xfp-mac > > + >=20 > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 >=20 > What are these for? You have no child nodes to use them. ack, in v4 I will add mac ethernet subnode. Regards, Lorenzo >=20 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - resets > > + - reset-names > > + > > +unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + > > + soc { > > + #address-cells =3D <2>; > > + #size-cells =3D <2>; > > + > > + eth0: ethernet@1fb50000 { > > + compatible =3D "airoha,en7581-eth"; > > + reg =3D <0 0x1fb50000 0 0x2600>, > > + <0 0x1fb54000 0 0x2000>, > > + <0 0x1fb56000 0 0x2000>; > > + reg-names =3D "fe", "qdma0", "qdma1"; > > + > > + resets =3D <&scuclk 44>, > > + <&scuclk 30>, > > + <&scuclk 31>, > > + <&scuclk 6>, > > + <&scuclk 15>, > > + <&scuclk 16>, > > + <&scuclk 17>, > > + <&scuclk 26>; > > + reset-names =3D "fe", "pdma", "qdma", "xsi-mac", > > + "hsi0-mac", "hsi1-mac", "hsi-mac", > > + "xfp-mac"; > > + > > + interrupts =3D , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + , > > + ; > > + }; > > + }; > > --=20 > > 2.45.2 > >=20 --mE1ojJjZZ6/R0duQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZn5wEgAKCRA6cBh0uS2t rPBDAP0VFISvwEjp5slaMCIeahLjeBlxThDttQpEv3MVItyDGAEAyIJ24SNWoigy vMJ/oqNXrVsk72tvU1hdyCLn8y4BhAA= =4SEp -----END PGP SIGNATURE----- --mE1ojJjZZ6/R0duQ--