Re: [PATCH v3 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

Lorenzo Bianconi
2024-06-24T13:10:28Z

[-- Attachment #1: Type: text/plain, Size: 1413 bytes --]

On Jun 24, Sunil Kovvuri Goutham wrote:
> >Add airoha_eth driver in order to introduce ethernet support for
> >Airoha EN7581 SoC available on EN7581 development board (en7581-evb).
> >en7581-evb networking architecture is composed by airoha_eth as mac
> >controller (cpu port) and a mt7530 dsa based switch.
> >EN7581 mac controller is mainly composed by Frame Engine (FE) and
> >QoS-DMA (QDMA) modules. FE is used for traffic offloading (just basic
> >functionalities are supported now) while QDMA is used for DMA operation
> >and QOS functionalities between mac layer and the dsa switch (hw QoS is
> >not available yet and it will be added in the future).
> >Currently only hw lan features are available, hw wan will be added with
> >subsequent patches.
> >
> >Tested-by: Benjamin Larsson <benjamin.larsson@genexis.eu>
> >Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> >---
> >
> >+
> >+static int airoha_qdma_rx_process(struct airoha_queue *q, int budget)
> >+{
> ......................
> >+ skb->ip_summed = CHECKSUM_UNNECESSARY;
>
> Unconditionally setting UNNECESSARY for all pkts.
> Does HW reports csum errors ?

We enabled packet drop if TCP/UDP or IPv4 checksum is failed in
REG_GDM1_FWD_CFG register in airoha_fe_maccr_init(). In other words, if the nic
forwards the packet to the cpu, the checksum is correct.

Regards,
Lorenzo

>
> Thanks,
> Sunil.
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]