From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5261C3064D for ; Fri, 28 Jun 2024 13:16:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4Nl3gS0QUrXTFXdXBLAhP3tCDZO9ar9+UJa2VZXcBSI=; b=xKjH6ibIU8boJ0/SoD015kEDgJ vwA/YQZAP+awj5GXbgzkQJN2la4dyYxgLQV4LB7eRd9ZyIOCPU52si8j8Dx3KqHhHqsbnG/MegXmV Kb9dU5nacg5hN5A5gP1wFvLZCc9lMRln+DenuvwbmueeT7GtPRujpGNkf3GUftM5iTDYE8A23+qpk UvYJYPSz1cTjSgc8AenpW6gVwniQ+BJyD6OJ39J2uTUMMvAkA0b8JXi7D7YaBz7lzbvvRtgwq6z59 B5qcufVyRAt2eXibXoPCDDDD5rtqe3+lH3GON3B9sVTSST+xkqrpxmIxjoIuawWPbiTdWtzpsAvAb KQ/S+PYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNBSn-0000000DnJ9-2IUx; Fri, 28 Jun 2024 13:16:29 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNBSQ-0000000Dn08-14iq for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 13:16:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4Nl3gS0QUrXTFXdXBLAhP3tCDZO9ar9+UJa2VZXcBSI=; b=c4/iv5pUGXan/JbeSdK5Y7o7mQ P5KX1VVikBMmy9jpRTAEuXtzJ3D4BS3+T4gfijGkBovWr4h31M6sD/Srs+jAG5LxbN0OWatNd9u1p I1AAVX/iWzTT+jPFGZHatqrfsTJ5NPcbXHWggQmibg8YgXLJ5zpFGH9IVwmTxRlGtQdr1pmOAVyNn AcDxDv1J4Js6tpHM32aPuVpNEBSHXk7XaZvaRKW/d3tt43o5ge8hvRCsOInazv80oHDO6eg+RZVFx aAs4dhCCZAgAZZevZoqOE2347XgFCvaic1lmW1t8kAfY4zW8bawJOTlxxy8k5k3yD8o5Pk/5hMxSy 6dI1neBg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:54088) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sNBQC-0006Yw-1N; Fri, 28 Jun 2024 14:13:48 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sNBQE-0006XI-3Y; Fri, 28 Jun 2024 14:13:50 +0100 Date: Fri, 28 Jun 2024 14:13:49 +0100 From: "Russell King (Oracle)" To: richard clark Cc: Steven Rostedt , Marc Zyngier , Mark Rutland , will@kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Torvalds Subject: Re: Will smp_call_function_single(cpu, ...) broadcast IPI to all other cpus? Message-ID: References: <86pls2isal.wl-maz@kernel.org> <20240627101207.0bbbead0@rorschach.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_061606_318143_70642E36 X-CRM114-Status: GOOD ( 10.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2024 at 06:21:25PM +0800, richard clark wrote: > The output is: > > insmod-1746 [000] dn.h1.. 928.400039: ipi_raise: > target_mask=00000000,000000ffe (Function call interrupts) > insmod-1746 [000] dn.h2.. 928.400042: > => trace_event_raw_event_ipi_raise > => smp_cross_call > => arch_send_call_function_single_ipi > => send_call_function_single_ipi I'm not sure whether the above is misproperly pasted or not, but if it is correct, it shows a problem. We can see from the first line that the target mask covers CPUs 1..11. However, the call chain is for arch_send_call_function_single_ipi(), which does: smp_cross_call(cpumask_of(cpu), IPI_CALL_FUNC); and cpumask_of(cpu) should only ever contain a single bit, and not multiple bits which the output above suggests it does! -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!