From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D7356C30658 for ; Fri, 28 Jun 2024 22:25:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sauWnSdM31U/5GgOuLGH5wZB+bFVX6InjfGbSOZzauQ=; b=Zt2vth8xYOyhNZf7JQUVwCD8C7 rbvkrUVnTly+T6GBHB9XIP0D6DG3e0B4XZMVgDeS9k3FdwuJOPngaHgljXQDjITvaEniMG6zTDW0X fW0AAryOSFRol00j2+5siepC/PdWBxQcWb685B6rTxNmrckhwBgCSrv6iqkEGZEGPlTSmgEsu9KzU ktJ/1dpnOo7Ubnhi59NijV5SaaGhg2PvxQ4AtYhtNrjGSG0fcDBZMzl1ZSHDrzBqBi144/WIR8VpE G3rx+ZZ4YiayKLBnZZkkOwj9fpnsrEWgYaxwBDotVq9Nhw0S1HD+Ln60knzNRGWCv6EIIrTf3GsiD 5moRe9dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNK1t-0000000FAth-0hEd; Fri, 28 Jun 2024 22:25:17 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNK1j-0000000FAqz-22WL for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 22:25:09 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7AE9CCE3B60; Fri, 28 Jun 2024 22:25:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72701C116B1; Fri, 28 Jun 2024 22:24:58 +0000 (UTC) Date: Fri, 28 Jun 2024 23:24:56 +0100 From: Catalin Marinas To: Thomas Gleixner Cc: LKML , linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, maz@kernel.org, anna-maria@linutronix.de, shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com, bhelgaas@google.com, rdunlap@infradead.org, vidyas@nvidia.com, ilpo.jarvinen@linux.intel.com, apatel@ventanamicro.com, kevin.tian@intel.com, nipun.gupta@amd.com, den@valinux.co.jp, andrew@lunn.ch, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, gregkh@linuxfoundation.org, rafael@kernel.org, alex.williamson@redhat.com, will@kernel.org, lorenzo.pieralisi@arm.com, jgg@mellanox.com, ammarfaizi2@gnuweeb.org, robin.murphy@arm.com, lpieralisi@kernel.org, nm@ti.com, kristo@kernel.org, vkoul@kernel.org, okaya@kernel.org, agross@kernel.org, andersson@kernel.org, mark.rutland@arm.com, shameerali.kolothum.thodi@huawei.com, yuzenghui@huawei.com, shivamurthy.shastri@linutronix.de Subject: Re: [patch V4 05/21] irqchip/gic-v3-its: Provide MSI parent for PCI/MSI[-X] Message-ID: References: <20240623142137.448898081@linutronix.de> <20240623142235.024567623@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240623142235.024567623@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_152507_745825_8E80183E X-CRM114-Status: GOOD ( 19.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Thomas, On Sun, Jun 23, 2024 at 05:18:39PM +0200, Thomas Gleixner wrote: > From: Thomas Gleixner > > The its_pci_msi_prepare() function from the ITS-PCI/MSI code provides the > 'global' PCI/MSI domains. Move this function to the ITS-MSI parent code and > amend the function to use the domain hardware size, which is the MSI[X] > vector count, for allocating the ITS slots for the PCI device. > > Enable PCI matching in msi_parent_ops and provide the necessary update to > the ITS specific child domain initialization function so that the prepare > callback gets invoked on allocations. > > The latter might be optimized to do the allocation right at the point where > the child domain is initialized, but keep it simple for now. > > Signed-off-by: Thomas Gleixner > Signed-off-by: Anna-Maria Behnsen > Signed-off-by: Shivamurthy Shastri > Signed-off-by: Thomas Gleixner I just noticed guests (under KVM) failing to boot on my TX2 with your latest branch. I bisected to this patch as the first bad commit. I'm away this weekend, so won't have time to dive deeper. It looks like the CPU is stuck in do_idle() (no timer interrupts?). Also sysrq did not seem able to get the stack trace on the other CPUs. It fails both with a single or multiple CPUs in the same way place (shortly before mounting the rootfs and starting user space). Not sure whether it's related by Red Hat's CI is also reporting boot failures: https://lore.kernel.org/r/66859.124062817530400571@us-mta-477.us.mimecast.lan I'll drop your branch from the arm64 for-kernelci for now and have a look again on Monday. -- Catalin