From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38F7FC2BD09 for ; Fri, 28 Jun 2024 21:56:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bcLWSIe52sGLdEKTBdAQolHpPpJtK55zL5ImUo+lw7M=; b=iltVxJMHMx541zaisMOtB+1Vzr YmuqBgG8vZoWDGGBGxOkAMhyulZ3J+jzAwiv5vsSRX3kuw4kXmzaF+Sf2Je2ybu/z28P9ee2Ejdre 8lnDpw0M4eHuFMZARfBPJaH6U+3Urh6VULkP0ksJdRAPNIdVIhDWr5t860tnHcTTB9JsbKnmAj/zO GII2BAJzIsD4ubq502CgF6oNihjE2l6ACXxuxXEv+tYUEGBSGnArWFgGSf8rKKnQTbVqSlfCZ2haB Y4Z8wcJoiv/yJWt2PQ6XLHQSPTRcCa8z7iqWQLatlQplcL73IOSNeqlPealtfXC+ojzNl6MtMl9bV QXI4JLIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNJZm-0000000F5de-2PhD; Fri, 28 Jun 2024 21:56:14 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNJZZ-0000000F5bF-0SFZ for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2024 21:56:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bcLWSIe52sGLdEKTBdAQolHpPpJtK55zL5ImUo+lw7M=; b=nrVVFn8KPcUmP6gGPax+zt0zjX SSgbQWkl/aH34+jC0q3O8thp4VONsZLPp9RU2PYpZEzMk1SQKUjNyJC+CFtI90YozUwiScUWMVlxr Py9qXbhaEy/OeaOaDI/7ehcng4pHblPPpgFsFDeZVuC5oU1jjEu4Riinmm1O/iDxdWdPg+VAfmArl atOXnSuIkFWBHVBoHzOy0cuJC3hKGhXhY7fmCtgCxHWCw6lL/24pgpVSXmjZvj1XkyOaafQ43bTWM aSKbfHmFvWayQ6Q3v3jSNveVMxXUTtv8EXN9NIMDdbwRom1eyU07qjE0ejt6T9798jNkQ643TUQda Ani9vf+A==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:43222) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sNJZO-0007Xj-2x; Fri, 28 Jun 2024 22:55:50 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sNJZS-0006pf-0x; Fri, 28 Jun 2024 22:55:54 +0100 Date: Fri, 28 Jun 2024 22:55:53 +0100 From: "Russell King (Oracle)" To: Thorsten Blum Cc: mingo@kernel.org, sshegde@linux.ibm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM, sched/topology: Check return value of kcalloc() Message-ID: References: <20240628194350.542376-2-thorsten.blum@toblux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628194350.542376-2-thorsten.blum@toblux.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_145601_167406_7AD1523C X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 28, 2024 at 09:43:51PM +0200, Thorsten Blum wrote: > Check the return value of kcalloc() and return early if memory > allocation fails. If we fail this allocation even with your fix, how likely is it that the system will boot and manage to run userspace? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!