From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DAB9EC2BD09 for ; Sat, 29 Jun 2024 02:13:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=a25bTE27wqTKuFvWrxZNULOpqakyZCl/Q4oa56L0f8o=; b=IBNyx6vJfpqbUBsAXIKvn87fUF zRFmDIGMlSguSKQkQxEACX9sdt6JKhbor5rlHS0wU/T8bbj/GkWzYkT3WA+tBHtFZSDn1IMh5hkP/ 5yFkNMeIneruH4fSs0c7H8boqu5QxApAP/6Vm1OEySAsBIKZXM0IyMwy+IJ1o/PwPJ/dbIPKiYm8o WouxYWOxTLjkxZLoKFdiwJvGOJD8ghbh70DuMKFEAj+A9QDtTIEyQMTR4dia64CiLzxTliUl3BdKp mozYefubzFAy3dDiEQN+KPwXZu5MJIQwCM/XBzvu9gxzgQluMnXU4kNwxV1Wn0rjXrLvhqbhtVxgS 4lnIlz9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNNaJ-0000000Fg9y-1smr; Sat, 29 Jun 2024 02:13:03 +0000 Received: from out-177.mta0.migadu.com ([91.218.175.177]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNNa8-0000000Fg8b-43fz for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 02:12:55 +0000 X-Envelope-To: jakobl.gm.g@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1719627169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a25bTE27wqTKuFvWrxZNULOpqakyZCl/Q4oa56L0f8o=; b=y9FWHy3DWAhkBtX0eh+qqKjdoBwh/Tbuj1OdX/bIUREBXQqQZzz3a+674KhiQMiUfb9I8P 4BOcdCdEDzwuyeSRovbpBsXuQYZhoOSOL5Dp/AK5YzAVKL49xd06vHUAJsOTECpAf6gez1 LeZNx++YOfINQGAQ4M9G+gvk1eN9mTT81LvyhIeQ4UUo3HQ6H9d2muxkqLlO+DdVXpCKIC YRERKTF9EVvsionjXKvdkQFcmzmL7ThR1S1H91bW4hC5msOaS/v1+DCg22dglSmeNfOv5Z wQZMMTVMi6miEimfJW27+OIWWPbnioJsWeX3a4aUC92bor6nN60p//Rhr+YXfQ== X-Envelope-To: linux-sunxi@lists.linux.dev X-Envelope-To: andre.przywara@arm.com X-Envelope-To: kirby.nankivell@gmail.com X-Envelope-To: contact@paulk.fr X-Envelope-To: mripard@kernel.org X-Envelope-To: wens@csie.org X-Envelope-To: jernej.skrabec@gmail.com X-Envelope-To: maarten.lankhorst@linux.intel.com X-Envelope-To: tzimmermann@suse.de X-Envelope-To: airlied@gmail.com X-Envelope-To: daniel@ffwll.ch X-Envelope-To: samuel@sholland.org X-Envelope-To: dri-devel@lists.freedesktop.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Sat, 29 Jun 2024 12:12:30 +1000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Jakob L Cc: linux-sunxi@lists.linux.dev, andre.przywara@arm.com, "K. James" , Paul Kocialkowski , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: T113 TCON Top tinting troubleshooting Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240628_191253_607530_23EA68C6 X-CRM114-Status: GOOD ( 17.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jun 29, 2024 at 01:49:53AM +0200, Jakob L wrote: > Hi John, > > good find! This seems to fix it on my DSI implementation. Every of the > recent boots resulted in a pink tint (usually it was green for me, or blue) > Booted 10 times - no tint. > > So this patch is good, but probably has to be implemented as a quirk? > > Jakob Hi Jakob, I'm not sure if this needs to be a quirk: There's not really a reason to set both DEs to the same output. My thinking right now is to error in this situation. However I think we have to somehow track which DEs have been set so we can pretend they start unset. For example: DE0: (Unset, LCD0) DE1: (Unset, TVE0) Setting DE0 to LCD0 should work, then setting DE1 to LCD0 should fail. Setting DE0 to LCD0 should work, then setting DE0 to TVE0 should work. Setting DE0 to TVE0 should work, then setting DE1 to TVE0 should fail. The mechanism here for setting a DE I think would go like this: 1. Check the opposite DE's value 2. If it is duplicate and set, error 3. If it is duplicate and unset, change the opposite DE's value 4. Set the DE 5. Mark it as set Step three requires finding an unused DE value, this could be done by inverting the bits of the new DE. Alternatively we could do what Allwinner does and start with both DEs at different values and the move instead the current DE value to the opposite DE to avoid conflicts. 'Set' here may make more sense as 'used'. I'm good at mentally over-engineering things, so if you can think of a better solution please tell me. John.