From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B727CC2BA18 for ; Mon, 17 Jun 2024 10:40:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0ARK5Vt7SDGUOyJUx3RTUS6gFy93Y+bwaW+22oZla3g=; b=33sXplLMNWvMys0cKf4S5ei2vh DxxQQ08AfSRkpY8bNgWw0e4FB/Z8j7UkrlM/EI2oB8l4JPxo5qh9S3pAa+RjW5q1kczKpo7oV1jwm o2VeiT61OrqiKEPUsO34EbfEJqZoFMSx4i+9MPmLSd9/hlNDhnUvdjpI64kmkl8YMoZ1U7kb8oab7 7C0fzcOMTFACkZNIpPQPCZU6urbH6yM+giT8L4JshWph4h134wrHt/53TeunabCNs9zuPiLfHOVs4 IH5pTl47ow6i78Nr4WhEyWfNY2E4vK3jCgt3oBOPZJAymLwlAJK2fQ9NhbYdtR7lYLjErnYKYsKf2 8EVeOlRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ9n7-0000000AIgZ-1V1u; Mon, 17 Jun 2024 10:40:49 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJ9n3-0000000AIfE-3kNm for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2024 10:40:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EAB3BFEC; Mon, 17 Jun 2024 03:41:09 -0700 (PDT) Received: from J2N7QTR9R3 (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 904F23F6A8; Mon, 17 Jun 2024 03:40:44 -0700 (PDT) Date: Mon, 17 Jun 2024 11:40:41 +0100 From: Mark Rutland To: Sudeep Holla Cc: linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi Subject: Re: [PATCH] firmware: psci: Fix return value from psci_system_suspend() Message-ID: References: <20231113153446.82684-1-sudeep.holla@arm.com> <171861861706.3840576.13385886526197301214.b4-ty@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <171861861706.3840576.13385886526197301214.b4-ty@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240617_034046_021806_11C24B2D X-CRM114-Status: GOOD ( 13.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 17, 2024 at 11:12:55AM +0100, Sudeep Holla wrote: > On Mon, 13 Nov 2023 15:34:46 +0000, Sudeep Holla wrote: > > Currently we return the value from invoke_psci_fn() directly as return > > value from psci_system_suspend(). It is wrong to send the PSCI interface > > return value directly. psci_to_linux_errno() provide the mapping from > > PSCI return value to the one that can be returned to the callers within > > the kernel. > > > > Use psci_to_linux_errno() to convert and return the correct value from > > psci_system_suspend(). > > > > [...] > > This has slipped through the cracks for long. I plan to take this > via my FF-A tree as SoC team somehow missed couple of times though I > cc-ed their email. That works for me; thanks for picking this up! Mark. > > Applied to sudeep.holla/linux (for-next/ffa/updates), thanks! > > [1/1] firmware: psci: Fix return value from psci_system_suspend() > https://git.kernel.org/sudeep.holla/c/f624c7cbd155ef > -- > Regards, > Sudeep >