From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E657C27C4F for ; Tue, 18 Jun 2024 09:55:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9RN830xNo8EBBvbkNP+kMcelvu7bexEwsqDX3e6oww8=; b=i9u9Z3HJHYG29PEcu9VQoQRQ9W z0ZJqCsUXzzn9VD5i7wbnXpEDIOp9UkGF7PwcALqyq81PaYLrftMVZ3ZN3b0Vbfm0Ey3C5nUAkQ82 wLX0hYNiz3W6Solu5Uyzjw7AW1TM7mJshuNIgFJNM68z5BqSOevTKePinp4249GWc1DknSOd7E3Pe wjQ+qs6KVMEJ4c8kYIIy64iGOXy/P0VOcOGOAilYkF48nVhfGGavcS64Su5YzeaYA9ll2RkAnTxMe igNyvxfb2B0N56lRRH/6sMY4WH9Qe1UmXR/MZDm7VqZVte1nJP3S2q/3rVaNuyrWujzd/43c+Elnf IfENuJpA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJVYp-0000000EEUj-0vZP; Tue, 18 Jun 2024 09:55:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJVYm-0000000EETK-3Dhv for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2024 09:55:30 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3FFBDA7; Tue, 18 Jun 2024 02:55:50 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3EB8B3F6A8; Tue, 18 Jun 2024 02:55:24 -0700 (PDT) Date: Tue, 18 Jun 2024 10:55:21 +0100 From: Cristian Marussi To: "Peng Fan (OSS)" Cc: Jonathan Corbet , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sudeep Holla , Cristian Marussi , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 6/6] firmware: imx: add i.MX95 MISC driver Message-ID: References: <20240524-imx95-bbm-misc-v2-v4-0-dc456995d590@nxp.com> <20240524-imx95-bbm-misc-v2-v4-6-dc456995d590@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240524-imx95-bbm-misc-v2-v4-6-dc456995d590@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240618_025528_909777_5D0396F3 X-CRM114-Status: GOOD ( 17.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 24, 2024 at 04:56:48PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > The i.MX95 System manager exports SCMI MISC protocol for linux to do > various settings, such as set board gpio expander as wakeup source. > > The driver is to add the support. > > Signed-off-by: Peng Fan > --- > drivers/firmware/imx/Makefile | 1 + > drivers/firmware/imx/sm-misc.c | 108 ++++++++++++++++++++++++++++++++++++++++ > include/linux/firmware/imx/sm.h | 33 ++++++++++++ > 3 files changed, 142 insertions(+) > > diff --git a/drivers/firmware/imx/Makefile b/drivers/firmware/imx/Makefile > index fb20e22074e1..cb9c361d9b81 100644 > --- a/drivers/firmware/imx/Makefile > +++ b/drivers/firmware/imx/Makefile > @@ -2,3 +2,4 @@ > obj-$(CONFIG_IMX_DSP) += imx-dsp.o > obj-$(CONFIG_IMX_SCU) += imx-scu.o misc.o imx-scu-irq.o rm.o imx-scu-soc.o > obj-${CONFIG_IMX_SCMI_BBM_EXT} += sm-bbm.o > +obj-${CONFIG_IMX_SCMI_MISC_EXT} += sm-misc.o > diff --git a/drivers/firmware/imx/sm-misc.c b/drivers/firmware/imx/sm-misc.c > new file mode 100644 > index 000000000000..22c1a5819425 > --- /dev/null > +++ b/drivers/firmware/imx/sm-misc.c > @@ -0,0 +1,108 @@ > +// SPDX-License-Identifier: GPL-2.0+ > +/* > + * Copyright 2024 NXP. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +static const struct scmi_imx_misc_proto_ops *imx_misc_ctrl_ops; > +static struct scmi_protocol_handle *ph; Same comments as n V1 ... please have a look :P Thanks, Cristian