From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF096C27C53 for ; Wed, 19 Jun 2024 07:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n8cX+KPLb2qmQU0X6Wc3o0Ur0z2grWfNdnC6NkT9/XU=; b=T6ks1bpRSFtEVjNBm3mp8xOX/K 7Mf+LSi5RLuIxhHPq9l6MweZaSgCTWXZdb26uvwdNbYnMGvoDJzhxj9J/kLggpuCHiO+eEK57k3RK ImS7diMj9FlK4vfbaMOgxyVcWc7Rs8CeB0NNJTqksikfgZipBk3Oh6Dp7MiJSpkylRGsa+pen6/qj myC/g/hJxnI6YugzSPWdG59VI7ZINcahfp9ratgZ7bDOIcUNNEwDLT+cvMLkGTSil4SQdqR1WAjlP WwVpstcyKhVF7FKZiaUF8p3IBfzQ8zXqfwLWyeONKU/+Et1Dut+r3UTUqWSKozvNKTd5G+LedfDRN lh740GGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJpbw-00000000ATr-1JKB; Wed, 19 Jun 2024 07:20:04 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sJpbt-00000000ARk-0dH6 for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2024 07:20:02 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1B421CE1D24; Wed, 19 Jun 2024 07:19:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFE8DC2BBFC; Wed, 19 Jun 2024 07:19:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718781598; bh=uvAP8y0qFZ/aHw0g4eIrWcQaH8P8vN+nnewkUnmZmDQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cgmz0kaEeOZuEssLsDyMfcaN0ptcozzDrcsnfWcgf3wYAKNsVFBx5ZDNpThkTv2KA b7jiEVbZhMUj6mDw2w9PLcAWj7Ca7XNSkk3X1sbkO0On6eIs5lGepUf94wkGRHFPUc UA+LykfhiCEMmzOEouz8JalKkzCKjULNZfQ2P/kXz2TbWIH6pLqrCldKRBR3B9HZt8 7u2pj0kE18Ug1gtRon8tLCUsFbleALWH97X/2HsbCk94JMrABH9MwzMyYvCc1A+hXf XgBbIWyqELBZExF2gi28wKvclW67DpOiRvb4x8Zch/EZgknVFYVYSDJI/z9ayJXLxR gLH8F11aOmVpQ== Date: Wed, 19 Jun 2024 09:19:54 +0200 From: Lorenzo Bianconi To: Andrew Lunn Cc: netdev@vger.kernel.org, nbd@nbd.name, lorenzo.bianconi83@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, conor@kernel.org, linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, upstream@airoha.com, angelogioacchino.delregno@collabora.com, benjamin.larsson@genexis.eu, linux-clk@vger.kernel.org, rkannoth@marvell.com, sgoutham@marvell.com Subject: Re: [PATCH v2 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Message-ID: References: <64b3c847-8674-4fdd-bbe6-8ea22410aa19@lunn.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="t1JdaXAETMxshABh" Content-Disposition: inline In-Reply-To: <64b3c847-8674-4fdd-bbe6-8ea22410aa19@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240619_002001_404574_7901F6AA X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --t1JdaXAETMxshABh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable > > +static void airoha_fe_maccr_init(struct airoha_eth *eth) > > +{ >=20 > ... >=20 > > + airoha_fe_wr(eth, REG_FE_VIP_PATN(11), 0xc057); /* PPP->IPv6CP (0xc05= 7) */ >=20 > include/uapi/linux/ppp_defs.h > #define PPP_IPV6CP 0x8057 /* IPv6 Control Protocol */ >=20 > Are these the same thing? Why is there one bit difference? ack, I guess there is a typo here. >=20 >=20 > > + airoha_fe_wr(eth, REG_FE_VIP_PATN(17), 0x1ae0); > > + airoha_fe_wr(eth, REG_FE_VIP_EN(17), > > + PATN_FCPU_EN_MASK | PATN_SP_EN_MASK | > > + FIELD_PREP(PATN_TYPE_MASK, 3) | PATN_EN_MASK); > > + > > + airoha_fe_wr(eth, REG_FE_VIP_PATN(18), 0x1ae00000); > > + airoha_fe_wr(eth, REG_FE_VIP_EN(18), > > + PATN_FCPU_EN_MASK | PATN_DP_EN_MASK | > > + FIELD_PREP(PATN_TYPE_MASK, 3) | PATN_EN_MASK); >=20 > > + airoha_fe_wr(eth, REG_FE_VIP_PATN(22), 0xaaaa); >=20 > Please add a comment what these match. ack, I will look into them. >=20 > > +static int airoha_dev_change_mtu(struct net_device *dev, int new_mtu) > > +{ > > + dev->mtu =3D new_mtu; > > + > > + return 0; > > +} > > + >=20 > I don't think this is needed. Look at __dev_set_mtu(). ack, I will get rid of it in v3. Regards, Lorenzo >=20 > Andrew >=20 > --- > pw-bot: cr --t1JdaXAETMxshABh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZnKGmgAKCRA6cBh0uS2t rIRCAP9rbZZTIY9xE3nb018VxcdNZuvz5KU6xukpk2vKwOwztQD/fI0rjlWwYxHQ kdo/7s1J7RCqUM5RlC+1sqpISnZ9KQU= =0xov -----END PGP SIGNATURE----- --t1JdaXAETMxshABh--