From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BD89C2BA18 for ; Thu, 20 Jun 2024 08:38:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Y+5B9PzdnMDDd8hXSPZqp3b5F5bdJdGSDbFRXbNF4BA=; b=wD/Wu6lZ4gE2niU1MrDkamp5dU T8MA+DhuRmqGwCD1O8imvyq1DH8tCqVlxjfipeZw6dvAFCZsvgObnK1xN0RUfOvmeR/BN/FGqb4T+ JRJBA/FrjNp7o+yAvUfErJcSw40rodGM2ARU6IInwYe7QCW6V8kT7/yoMSMCMWxvb6NwsHBqPazJC EJmdTsI8giz8tbXXK0vnMiikEgPrdBa77o1Bda+51HrqbnFbW0PBttjvsihs1Ksp1QClvBi0xbsAn wM13L9isNQytiyBYSpURGlZnDdgvbwgomcBv1LRXVW0ZzwCSqKR01ZIBA3i834x9i+ti6zcMifW3L pnrZGXSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDJK-00000004CDT-1n0k; Thu, 20 Jun 2024 08:38:26 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDJH-00000004CCw-47oO for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 08:38:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5B7ABDA7; Thu, 20 Jun 2024 01:38:47 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 504E83F64C; Thu, 20 Jun 2024 01:38:21 -0700 (PDT) Date: Thu, 20 Jun 2024 09:38:18 +0100 From: Sudeep Holla To: Youwan Wang Cc: lpieralisi@kernel.org, guohanjun@huawei.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, lenb@kernel.org, rafael@kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH] ACPI / amba: Drop unnecessary check for registered amba_dummy_clk Message-ID: References: <20240620005930.295880-1-youwan@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240620005930.295880-1-youwan@nfschina.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_013824_187742_973FDC9F X-CRM114-Status: GOOD ( 11.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 20, 2024 at 08:59:30AM +0800, Youwan Wang wrote: > amba_register_dummy_clk() is called only once from acpi_amba_init() > and acpi_amba_init() itself is called once during the initialisation. > amba_dummy_clk can't be initialised before this in any other code > path and hence the check for already registered amba_dummy_clk is > not necessary. Drop the same. > You are not reading my response correctly and fixing all the issues. 1. You had v3 and now this is again v1 ? Perhaps v4 ? 2. You missed to add my Acked-by which I gave to your v2 3. This is v4 and new reviewers of this patch have absolutely no idea what got changed from v1->v2->v3->v4. It is always good to add change log describing what changed across these versions 4. I asked you to add ARM64 maintainers as we would request them to pick this up via ARM64 tree. Catalin Marinas I will ignore your patches if these are not fixed, I have told you same thing twice now. -- Regards, Sudeep