From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64743C27C79 for ; Thu, 20 Jun 2024 08:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WVZAJrSzS+Dzdet9WqNMmx+EvQrEM8mJjwoGmKwdyCQ=; b=pLsTL2f1Ns/lp42wI9YpS+X8NB sNHkD3sf2CUOVryyaJz7CNltFqXHwlvhhKty0IkDlX05ZLw/8T6/lxk2beTt52/DOMOXuKqeDEqMt wbhEm2GqkAw+6Kn9tsNRXq7jHXQE4XG2a5Ii2Z7oeD9dhg1/yfW5g9imEzK83fNVHsA3r7PKhMCB8 qDA7+ZjiORvIR3VyS7MOskxpegdCaQpPYbm9S4e3AJ32G0ryn4d9IPN7WHxJt07gpXimgsKcUY87f TaLkIqA/RQ1ULUSweJx6Sb34f4KZGJUvkmsO/jo/GF3N/UyVmBEotn7S/U9QlzjA+vDUUPebsVJT3 QQwsiFVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDdW-00000004IN9-13Ge; Thu, 20 Jun 2024 08:59:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKDdS-00000004IMc-3DRn for linux-arm-kernel@lists.infradead.org; Thu, 20 Jun 2024 08:59:16 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 0A6D96211C; Thu, 20 Jun 2024 08:59:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D8D2C2BD10; Thu, 20 Jun 2024 08:59:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718873952; bh=cxO0O9LpvQgPUIclFb5zIAe3EVexH+Kz4teCj8aZZ3A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LLxHfoOx65muZqCx7fXYQA+BVobfWUYljU/T3kndPOGXaItcWwNz4sYjMRVbL3rfo 2Wl9Y3l0tXzCpA1JqnJH8IbC1gIGadbM9RlKUjZnN+iERxeohoKaqA2b+0I/P+GKUQ E7r0CKv9OjU85F7M3QTLjy4MXkx02x5FYj0KhbNSGQDO2pL9Nkc5CKRgEY0pQkloFg eAwbHg/kEjhUpo1fZ9PJ4waOyWUO4UwYVqHTHFfuOcTYHL7ggnBLIjxx3KJSq7YXBV DccgAGUgDnKd7IEv63oQfrqeXQWUx1siv0oeFbw+i9tCmvdWuuSfyccn1MLT+Vnmaj isDWOie3aU/qg== Date: Thu, 20 Jun 2024 17:59:07 +0900 From: William Breathitt Gray To: Lee Jones Cc: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Fabrice Gasnier , Maxime Coquelin , Alexandre Torgue , linux-pwm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Thorsten Scherer Subject: Re: [PATCH v2 3/5] counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of TIM_DIER_CCxIE(x) Message-ID: References: <126bd153a03f39e42645573eecf44ffab5354fc7.1718791090.git.u.kleine-koenig@baylibre.com> <20240620084451.GC3029315@google.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qUxpVBYe6s7jx2cy" Content-Disposition: inline In-Reply-To: <20240620084451.GC3029315@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_015914_893138_2C7BBDA8 X-CRM114-Status: GOOD ( 21.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --qUxpVBYe6s7jx2cy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 20, 2024 at 09:44:51AM +0100, Lee Jones wrote: > On Wed, 19 Jun 2024, Uwe Kleine-K=C3=B6nig wrote: >=20 > > These two defines have the same purpose and this change doesn't > > introduce any differences in drivers/counter/stm32-timer-cnt.o. > >=20 > > The only difference between the two is that > >=20 > > TIM_DIER_CC_IE(1) =3D=3D TIM_DIER_CC2IE > >=20 > > while > >=20 > > TIM_DIER_CCxIE(1) =3D=3D TIM_DIER_CC1IE > >=20 > > . That makes it necessary to have an explicit "+ 1" in the user code, > > but IMHO this is a good thing as this is the code locatation that > > "knows" that for software channel 1 you have to use TIM_DIER_CC2IE > > (because software guys start counting at 0, while the relevant hardware > > designer started at 1). > >=20 > > Signed-off-by: Uwe Kleine-K=C3=B6nig > > --- > > drivers/counter/stm32-timer-cnt.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > Did you drop William's Ack on purpose? >=20 > --=20 > Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF] No problem, here it is again for the sake of the LKML scraper tools: Acked-by: William Breathitt Gray Lee, do you prefer taking this patchset through your tree? William Breathitt Gray --qUxpVBYe6s7jx2cy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZnPvWwAKCRC1SFbKvhIj K1GgAP9odcqC0bo8rEeP0eJTrSUFEqcSuJZBP7eDgnXlVa0onwD+PKCxPPIJMLff Zg4Fw4SPOHzpnOcfqWbkCDNjqMhH6AY= =XwMH -----END PGP SIGNATURE----- --qUxpVBYe6s7jx2cy--