From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A14DC27C4F for ; Fri, 21 Jun 2024 04:49:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2WGzLpSHiAFMQ6rhulZPDgtq0nr+/nkWynRADUnWeOc=; b=teFKwZOhGrwJjNRSeMTLpRtaQH zMfC1ZxcjpS2yzZ0KcCIO/7scQpXZrPkpKzr/MYhOuQgCGHymBtP6widtozb82qzQHkyrza0LEjyK r0j4mHAptlWLofG+RXZVBMcavUyH0BxYe9JWLtIb6HFtkKVyckIfFZ9t1fgN72m5K3Z9CcNo2L1lk cEvk/Dy/vlyuFQAcn0QLfFSvMlstnCSDXlW9eP3CYhyN/yCw6NC9BYsY7/wP/VOuPC08xUBPWy836 +QReWIfdR5MovmLi/gpT5Tq7NY/pOejjLsWou7xvZVYsx2UEv2a9HLZGhjV/biwq2tNTp59CGWygl ZK0r/cYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKWCj-00000007gTS-03cQ; Fri, 21 Jun 2024 04:48:53 +0000 Received: from mail-lf1-x135.google.com ([2a00:1450:4864:20::135]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKWCf-00000007gSk-1x02 for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2024 04:48:51 +0000 Received: by mail-lf1-x135.google.com with SMTP id 2adb3069b0e04-52c819f6146so1955634e87.1 for ; Thu, 20 Jun 2024 21:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718945327; x=1719550127; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2WGzLpSHiAFMQ6rhulZPDgtq0nr+/nkWynRADUnWeOc=; b=Uq6vMgI6raEIGoGYrJwrPIc9+Szyq77sYB8aQKrfyl2dRmNyQclVRhGcAEj3Jnn/6d +xC0SbGPfbybWSWHp8Jo7TA3aa/eDL8KZq0BwV3CKkCmcczvSF27SmjxMoax2ughG0N1 6M5RCSP7W0Yy1XGlhiV3oH85kScoaYtFafVq6+6oIX4z/fCqlurjxO7PgZ+2AjmQy0g5 CBajvD26NzewN7gQberjCbc1HQEKGqk6XW2nKHXeMQ028Hn9HO3tvf5RlxzcAPtbcy2D 1k234qreXt5TSFLYjmqcLi/Y4gu07EWPgBIxoNTaAmhYQb7kyXBd6VQhdU/ZaUthrEPp U71A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718945327; x=1719550127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2WGzLpSHiAFMQ6rhulZPDgtq0nr+/nkWynRADUnWeOc=; b=VCk1g3I31ExPbIA5mlAz07SGx+j1J1JMkVtEf8AvobS+74DAD3iFrLnRbLtbfuvONS 534bQH7XfvFSv6QvGaYes4eb4qlkzPg6kZUJ2XtKuF5ioE+PtIGXFz4PpqgmlTyRzC8L JQIlKp0ktQGoxJeXPFKlZZJz1dkzo4zDHzB9RgX1qn41jbMD3QN8u6bIVTbwzrZUU8yZ pj0KpWM3Z0hpPYgr+fqsnKDGfzDnSPqTQb57dYi3VJKWCgTsuv/IFhwevn39Oy0/fvHg Q45snGgvXllLrVIJAQGKsvf6G434StJB+fteN0xSiB0gc20gT9Ja2fW2tOVs7VPjmy1e t3Fg== X-Forwarded-Encrypted: i=1; AJvYcCX4+pj6WoWrP1M7yZxu2YTFyxn+AcwwTF0oHgkTIhkUFWH5xyvRlpItXqBDxdDqCWk9ugJfM6iJS+5JDkXKYlWYBxPHDGt8znpwupN/71ZCaVQVf4M= X-Gm-Message-State: AOJu0YzXfrHUnZs1Zh67NfXAwhBgN7J2KKsZxTz53NF1JqVsE5bTqGFa r0Dw4mjAXr1f6Slkv+G+LJlVmT7HNR09yTu7kcse1mnI5Ad7nc8DwG6j5Ev5CjnkjJqJXoLg9v8 B X-Google-Smtp-Source: AGHT+IHQ/LUmDuyLZQ0IaCKcHTZmjchVpKw8WeCnkMirzzuExs8oyd0Nlj5f9/vavkQGjh28g4RcMw== X-Received: by 2002:a05:6512:10c3:b0:52c:859c:91dd with SMTP id 2adb3069b0e04-52ccaa594cfmr4875472e87.5.1718945326588; Thu, 20 Jun 2024 21:48:46 -0700 (PDT) Received: from linaro.org ([82.79.124.209]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3663cd5fa47sm632123f8f.0.2024.06.20.21.48.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jun 2024 21:48:46 -0700 (PDT) Date: Fri, 21 Jun 2024 07:48:44 +0300 From: Abel Vesa To: Marek Vasut Cc: linux-clk@vger.kernel.org, Abel Vesa , Fabio Estevam , "Lukas F . Hartmann" , Michael Turquette , Peng Fan , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Stephen Boyd , imx@lists.linux.dev, kernel@dh-electronics.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] clk: imx: clk-imx8mp: Allow media_disp pixel clock reconfigure parent rate Message-ID: References: <20240531202648.277078-1-marex@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240531202648.277078-1-marex@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240620_214849_534564_1384B265 X-CRM114-Status: GOOD ( 17.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-05-31 22:26:26, Marek Vasut wrote: > The media_disp[12]_pix clock supply LCDIFv3 pixel clock output. These > clocks are usually the only downstream clock from Video PLL on i.MX8MP. > Allow these clocks to reconfigure the Video PLL, as that results in > accurate pixel clock. If the Video PLL is not reconfigured, the pixel > clock accuracy is low. > > Signed-off-by: Marek Vasut Reviewed-by: Abel Vesa > --- > Cc: Abel Vesa > Cc: Fabio Estevam > Cc: Lukas F. Hartmann > Cc: Michael Turquette > Cc: Peng Fan > Cc: Pengutronix Kernel Team > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: Stephen Boyd > Cc: imx@lists.linux.dev > Cc: kernel@dh-electronics.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-clk@vger.kernel.org > --- > drivers/clk/imx/clk-imx8mp.c | 4 ++-- > drivers/clk/imx/clk.h | 4 ++++ > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 670aa2bab3017..f11dfe2028319 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -547,7 +547,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_AHB] = imx8m_clk_hw_composite_bus_critical("ahb_root", imx8mp_ahb_sels, ccm_base + 0x9000); > hws[IMX8MP_CLK_AUDIO_AHB] = imx8m_clk_hw_composite_bus("audio_ahb", imx8mp_audio_ahb_sels, ccm_base + 0x9100); > hws[IMX8MP_CLK_MIPI_DSI_ESC_RX] = imx8m_clk_hw_composite_bus("mipi_dsi_esc_rx", imx8mp_mipi_dsi_esc_rx_sels, ccm_base + 0x9200); > - hws[IMX8MP_CLK_MEDIA_DISP2_PIX] = imx8m_clk_hw_composite_bus("media_disp2_pix", imx8mp_media_disp_pix_sels, ccm_base + 0x9300); > + hws[IMX8MP_CLK_MEDIA_DISP2_PIX] = imx8m_clk_hw_composite_bus_flags("media_disp2_pix", imx8mp_media_disp_pix_sels, ccm_base + 0x9300, CLK_SET_RATE_PARENT); > > hws[IMX8MP_CLK_IPG_ROOT] = imx_clk_hw_divider2("ipg_root", "ahb_root", ccm_base + 0x9080, 0, 1); > > @@ -609,7 +609,7 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_USDHC3] = imx8m_clk_hw_composite("usdhc3", imx8mp_usdhc3_sels, ccm_base + 0xbc80); > hws[IMX8MP_CLK_MEDIA_CAM1_PIX] = imx8m_clk_hw_composite("media_cam1_pix", imx8mp_media_cam1_pix_sels, ccm_base + 0xbd00); > hws[IMX8MP_CLK_MEDIA_MIPI_PHY1_REF] = imx8m_clk_hw_composite("media_mipi_phy1_ref", imx8mp_media_mipi_phy1_ref_sels, ccm_base + 0xbd80); > - hws[IMX8MP_CLK_MEDIA_DISP1_PIX] = imx8m_clk_hw_composite("media_disp1_pix", imx8mp_media_disp_pix_sels, ccm_base + 0xbe00); > + hws[IMX8MP_CLK_MEDIA_DISP1_PIX] = imx8m_clk_hw_composite_bus_flags("media_disp1_pix", imx8mp_media_disp_pix_sels, ccm_base + 0xbe00, CLK_SET_RATE_PARENT); > hws[IMX8MP_CLK_MEDIA_CAM2_PIX] = imx8m_clk_hw_composite("media_cam2_pix", imx8mp_media_cam2_pix_sels, ccm_base + 0xbe80); > hws[IMX8MP_CLK_MEDIA_LDB] = imx8m_clk_hw_composite("media_ldb", imx8mp_media_ldb_sels, ccm_base + 0xbf00); > hws[IMX8MP_CLK_MEMREPAIR] = imx8m_clk_hw_composite_critical("mem_repair", imx8mp_memrepair_sels, ccm_base + 0xbf80); > diff --git a/drivers/clk/imx/clk.h b/drivers/clk/imx/clk.h > index adb7ad649a0d2..aa5202f284f3d 100644 > --- a/drivers/clk/imx/clk.h > +++ b/drivers/clk/imx/clk.h > @@ -442,6 +442,10 @@ struct clk_hw *__imx8m_clk_hw_composite(const char *name, > _imx8m_clk_hw_composite(name, parent_names, reg, \ > IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_DEFAULT) > > +#define imx8m_clk_hw_composite_bus_flags(name, parent_names, reg, flags) \ > + _imx8m_clk_hw_composite(name, parent_names, reg, \ > + IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_DEFAULT | flags) > + > #define imx8m_clk_hw_composite_bus_critical(name, parent_names, reg) \ > _imx8m_clk_hw_composite(name, parent_names, reg, \ > IMX_COMPOSITE_BUS, IMX_COMPOSITE_CLK_FLAGS_CRITICAL) > -- > 2.43.0 >