From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70189C2BB85 for ; Fri, 21 Jun 2024 17:36:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=r78KDnOJuLzlTTwXnPv8lrpYBFcerusx8vpbsnPxcBU=; b=X0TMlgcyNFZThOj89gaF4eaCSA ydnobRPIQQ1g3sWpWqeJxRGhezp4VYDOmQ7CbBv5AlULRNm2mgf8Gs3AJpG8XpnKKR1OYQe4SLk1W dZUl0d2m36D8FeXvT4IpnyuLCJvSUW/FufvVeTzhwwhqiy9PkwInjtK1nM09LwoyCiQZspGjmXKSZ f9p+lTM3nUtICB57Li9fqpuQM4Ecos7ovGR5xynFEYPNmg5pQ6OBKOOJcPCLTo25rSg53qvaDVj8P 14k3hjCtNEnKl12JatExe359BzlnU83QV3SRV3LvhSApJ5VcrpMDsrOoF7CkdyK2dYWm8Y+egXpSs wThhD3Sg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKiBS-0000000A7TK-3Ax6; Fri, 21 Jun 2024 17:36:22 +0000 Received: from mgamail.intel.com ([192.198.163.19]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKiBO-0000000A7Ry-0haj; Fri, 21 Jun 2024 17:36:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1718991378; x=1750527378; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=qcPvzmgYj12g8ImX1mzdEnkJ4xTcuDJBE3vsD6BBM/8=; b=JK/S3+5BYeMHCxQJjR+hDXtnn0LK2h8IvYp8iroxu5msbnaSJ0wv19FT j00iu15rBQphgYo9BsV2ZvPJ4fXyV87glOS0XFXwb6fZHSSmaBroLo3Ul PSXatz0sur9mfeUyN4i1ELAyq3Eo68tj5raTfcjLGVrT82BIaRM3oiTVn UzKD0qfL5b1CWc8K5E6j/cz1JXwnBhcJfDvzHr5tp85aZBVNv92nceVR+ kX/2cvdNSU/IB+TfZry9O9uW83brW7nTaeRjD1PNA1nLJE5gJPvHrvNoD ynesxHSmTLK8oL5ZhK7xANIyw0yzfreAVeDS7ijMcZKtJnmth8y5mGph6 g==; X-CSE-ConnectionGUID: GdBijkCURZyquI2Howj9UA== X-CSE-MsgGUID: XcLXkLCJTW6uD8+RmxsJ3w== X-IronPort-AV: E=McAfee;i="6700,10204,11110"; a="15793885" X-IronPort-AV: E=Sophos;i="6.08,255,1712646000"; d="scan'208";a="15793885" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 10:36:15 -0700 X-CSE-ConnectionGUID: H9IYCJeiSDarIWFxa6sdhA== X-CSE-MsgGUID: 3ooXh5iNSpCEYlpT4ljgOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,255,1712646000"; d="scan'208";a="43333717" Received: from turnipsi.fi.intel.com (HELO kekkonen.fi.intel.com) ([10.237.72.44]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jun 2024 10:36:08 -0700 Received: from kekkonen.localdomain (localhost [127.0.0.1]) by kekkonen.fi.intel.com (Postfix) with ESMTP id A070711F855; Fri, 21 Jun 2024 20:36:04 +0300 (EEST) Date: Fri, 21 Jun 2024 17:36:04 +0000 From: "sakari.ailus@linux.intel.com" To: Andy Shevchenko Cc: Kieran Bingham , Zhi Mao =?utf-8?B?5q+b5pm6?= , angelogioacchino.delregno@collabora.com, conor+dt@kernel.org, krzk+dt@kernel.org, mchehab@kernel.org, robh@kernel.org, dongchun.zhu@mediatek.com, "heiko@sntech.de" , "linux-kernel@vger.kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , "yunkec@chromium.org" , "linux-mediatek@lists.infradead.org" , "linux-media@vger.kernel.org" , "hdegoede@redhat.com" , "bingbu.cao@intel.com" , "paul.elder@ideasonboard.com" , "devicetree@vger.kernel.org" , Yaya Chang =?utf-8?B?5by16ZuF5riF?= , Shengnan Wang =?utf-8?B?546L5Zyj55S3?= , "p.zabel@pengutronix.de" , "alain.volmat@foss.st.com" , "tomi.valkeinen@ideasonboard.com" , "10572168@qq.com" <10572168@qq.com>, "hverkuil-cisco@xs4all.nl" , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" , "mehdi.djait@bootlin.com" Subject: Re: [PATCH v3 2/3] media: i2c: Add GT97xx VCM driver Message-ID: References: <20240612012019.19078-1-zhi.mao@mediatek.com> <20240612012019.19078-3-zhi.mao@mediatek.com> <7c71534f-9815-4ea3-969f-c04d249d35d2@collabora.com> <18d2c28fc8b47889689a1506957ea2a308c80fa2.camel@mediatek.com> <171823714905.1550852.13442340621133903705@ping.linuxembedded.co.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_103618_322465_46DE34BA X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, others, On Thu, Jun 13, 2024 at 09:51:03PM +0200, Andy Shevchenko wrote: > On Thu, Jun 13, 2024 at 2:05 AM Kieran Bingham > wrote: > > Also - Cc: Dongchun Zhu who is listed as the > > DW9768 VCM driver author... > > Quoting Zhi Mao (毛智) (2024-06-12 12:13:40) > > > On Wed, 2024-06-12 at 09:07 +0200, AngeloGioacchino Del Regno wrote: > > ... > > > > Our project uses Giantec VCM hardware. > > > For detailed vendor information, please visit: ( > > > https://en.giantec-semi.com/yqmd/164). > > > The VCM datasheet we are referencing is provided by Giantec. > > > Currently, the relationship between Giantec VCM and Dongwoon VCM is > > > unclear, but Dongwoon seems to be another manufacturer of VCM > > > hardware. > > There may be plenty of manufacturers of the same/similar IPs, but it's > not an excuse to have a duplication like this. > > > > From the perspective of software driver development and maintenance, it > > > makes sense for each vendor's hardware should have its own software > > > driver. > > > > Personally, I don't think so. If two vendors make identical parts, we > > shouldn't have two identical drivers. > > Exactly! That's why we have compatible strings or other means of > reusing the same code base as much as possible. This in particular > reduces maintenance costs (of all means!) _a lot_. Indeed. I'll mark these thus "rejected" in Patchwork. If there's something that needs to be handled differently for the other VCM, that can be taken into account in the driver. -- Kind regards, Sakari Ailus