From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C68EDC27C78 for ; Sat, 22 Jun 2024 00:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=PRP3VQE1AP3bnFtc/gjNPrEWREESeBel3PS2LQJhyUA=; b=1DqRFt1LwOzlxamtLpR4owm/9E g4AD31HzqkuqdMYXx6u5kVmBlopSzeXVy99s24qs/cQjiba2Rf1y3ivc1UZAIoJ3c52ND1wWV8mjR TgqLc26LbdkWDKwpAMDgOl4ur4Vf+ugN+iyHNw2KW1RPpJB50i1Nx5czahqFT83lew60WfCjARcH9 3Htabn+J9npexTvjfKSM04fVf7wxrH0PutUIxw0dD5fMQE4Lq6+mtaA6sDM4xvSq0LVgcTjYkMkhb K9IlMNj1rHsqAgxYsnKz/l8qEDvufzJIkMLqv4Xsiq58AixxE7Sx6nGpFeFbg2CmJi1JwOpzUvO3v NvdIkFfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKoYm-0000000B0vZ-2Mrq; Sat, 22 Jun 2024 00:24:52 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sKoYi-0000000B0uS-0dmp for linux-arm-kernel@lists.infradead.org; Sat, 22 Jun 2024 00:24:49 +0000 Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1f70ec6ff8bso231995ad.0 for ; Fri, 21 Jun 2024 17:24:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719015887; x=1719620687; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=PRP3VQE1AP3bnFtc/gjNPrEWREESeBel3PS2LQJhyUA=; b=SGIWAhsURvV+RAtEJyE75k4EDUr2+hh1JEV/JyQwPX/Lhmmt9L/4wb5EGB/Eo/e1C2 EsBtxgINAPcCBQWDSXGpV59qAM0iN6i8jBXxwOmB8GYMPBL73UVRgM9VTTvwaAUn5xP2 CNP2NmnCFE5nNP7WyLv/KfdmoqDkMhUbjOU4XJFjiA/HHJRq0sHub8krfzZ4Wk3vld/H FrG4AFtZHSaONf5Jjj/n0fYUdxH4+4FApil9l3ejgFHpJAnmI7mqo2oUDd9KJStQyKG4 97nDJob+g2+W/S9SSFIdoDR7QUx0Xoi0G7NPlkiU6ySnKqVzPDkr3inwHIjmVrg5GJgg 03eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719015887; x=1719620687; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PRP3VQE1AP3bnFtc/gjNPrEWREESeBel3PS2LQJhyUA=; b=QHJjt+VxznEhK4wcDfnqtufwMVpnUZu4xmqYFWi9xWWKwJEa8hyJ2RWdBgG+1M/B+K TpEsrP6vIfEM83uFeeKV9rRpoP7/kwlbsNBKBR9pJr2Vy6Gvk0EPkqMpu1tb1K3qUgns M8ij0qItOdVtglFNu36PWtSAe6CTZvGgSIzX036EfBxA/WzbPfhltH1Vpxih0Qnrw2hs omVUCYrAXpy+zkGS+Mrs69e1JkMishMbYwYvXoVqcTURB8BDo231a5TkKUm/8N0pVGlM VJsvi4iw8VmDT+velF6LGFoMHzxeqwXiv0Zl3p+5M+gP2emx5uoMQKh/4pgNn1wLp5ms 7xcg== X-Forwarded-Encrypted: i=1; AJvYcCX2g1kLRc9CoWgBf15fk/T5CiLlFGQgB0xkeK1a1fuLjuKsXE4yTcwMIIr/0e2OF5ilINl/6Uwe/15UFSnKPS1zwfa7b7qR4P7PCh36rA2v/Tfb63U= X-Gm-Message-State: AOJu0YyD06NJUJzOgwcKUJ08046zalQ+YCP67xqWazs1x96B3G7J558A rSntyk2uU7Vo+z6l0DgkpR/vaMnK0ui8NcUFAdnZk2DvxhEe3vnBTG4Co019gg== X-Google-Smtp-Source: AGHT+IFMfnpYUYjQkDCI2TK2G2mhr4HnvdZTpVXgoabwYY/WwRqlge71giClqijFHgaHOR3qCIehLw== X-Received: by 2002:a17:902:8bc1:b0:1f9:ab5b:1716 with SMTP id d9443c01a7336-1fa09ff289dmr872725ad.6.1719015886719; Fri, 21 Jun 2024 17:24:46 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f9ebbb27acsm19903955ad.247.2024.06.21.17.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jun 2024 17:24:46 -0700 (PDT) Date: Fri, 21 Jun 2024 17:24:42 -0700 From: William McVicker To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peter Griffin , Marek Szyprowski , Sylwester Nawrocki , Alim Akhtar , Sam Protsenko , Krzysztof Kozlowski , Tudor Ambarus , Roy Luo , kernel-team@android.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v3 0/6] USB31DRD phy support for Google Tensor gs101 (HS & SS) Message-ID: References: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240617-usb-phy-gs101-v3-0-b66de9ae7424@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240621_172448_217542_E3B08DEA X-CRM114-Status: GOOD ( 31.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/17/2024, André Draszik wrote: > This patch series adds support for the Exynos USB 3.1 DRD combo phy, as > found in Exynos 9 SoCs like Google GS101. It supports USB SS, HS and > DisplayPort, but DisplayPort is out of scope for this series. > > In terms of UTMI+, this is very similar to the existing Exynos850 > support in this driver. The difference is that it supports both UTMI+ > (HS) and PIPE3 (SS). Firstly, there are some preparatory patches to convert > this driver to using the clk_bulk and regulator_bulk APIs to simplify > addition, while the bulk of the changes is around the SS part. > > Dependencies on other patches: > While there is no compile or link time dependency, for USB to actually work > this series also requires Peter's syscon changes from > https://lore.kernel.org/all/20240614140421.3172674-1-peter.griffin@linaro.org/ > > To: Vinod Koul > To: Kishon Vijay Abraham I > To: Rob Herring > To: Krzysztof Kozlowski > To: Conor Dooley > To: Peter Griffin > To: Marek Szyprowski > To: Sylwester Nawrocki > To: Alim Akhtar > To: Sam Protsenko > Cc: Krzysztof Kozlowski > Cc: Tudor Ambarus > Cc: Will McVicker > Cc: Roy Luo > Cc: kernel-team@android.com > Cc: linux-phy@lists.infradead.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: André Draszik > > Changes in v3: > - drop patch 'phy: exynos5-usbdrd: use exynos_get_pmu_regmap_by_phandle() > for PMU regs'. This is not needed anymore with Peter's syscon series > mentioned above (Krzysztof). > - drop those patches that have already been merged via > https://lore.kernel.org/all/20240507-samsung-usb-phy-fixes-v1-0-4ccba5afa7cc@linaro.org/ > - update device tree binding 'reg-names' (Krzysztof) > - use clk_bulk and regulator_bulk APIs throughout to simplify addition of > gs101 support as preparatory patches > - patch 1: add required but missing regulators > - patch 4: > * make the register access clock name(s) platform specific and avoid > use of devm_clk_bulk_get_optional() as we want to be sure to have > retrieved all required clocks > * fix a whitespace issue > * slightly rephrase commit message > - patch 6: > * set unused callback pointers to NULL in gs101_tunes[] > * implement missing regulator support and enable power to phy before any > register access > * add more phy tunes > * move PTS_UTMI_POSTINIT utmi phy tuning to before completion of POR > sequence, as per datasheet > * group gs101 related symbols closer to each other > - Link to v2: https://lore.kernel.org/r/20240501-usb-phy-gs101-v2-0-ed9f14a1bd6d@linaro.org > > Changes in v2: > - avoid having nested else/if in the DT binding (Rob) > - add missing bitfield.h include > - Link to v1: https://lore.kernel.org/r/20240423-usb-phy-gs101-v1-0-ebdcb3ac174d@linaro.org > > --- > André Draszik (6): > dt-bindings: phy: samsung,usb3-drd-phy: add gs101 compatible > phy: exynos5-usbdrd: support isolating HS and SS ports independently > phy: exynos5-usbdrd: convert core clocks to clk_bulk > phy: exynos5-usbdrd: convert (phy) register access clock to clk_bulk > phy: exynos5-usbdrd: convert Vbus supplies to regulator_bulk > phy: exynos5-usbdrd: support Exynos USBDRD 3.1 combo phy (HS & SS) > > .../bindings/phy/samsung,usb3-drd-phy.yaml | 77 +- > drivers/phy/samsung/phy-exynos5-usbdrd.c | 958 +++++++++++++++++---- > include/linux/soc/samsung/exynos-regs-pmu.h | 4 + > 3 files changed, 893 insertions(+), 146 deletions(-) > --- > base-commit: 6906a84c482f098d31486df8dc98cead21cce2d0 > change-id: 20240423-usb-phy-gs101-abf3e172d1c4 > > Best regards, > -- > André Draszik > Thanks Andre! I tested this out on my Pixel 6 Pro. I verified the USB modules load and probe as expected. I also verified my device is detected via adb on my host machine. However, occasionally when I boot from RAM the device doesn't come up via adb compared to when I flash and run `fastboot reboot`. So there must be something happening differently when booting from fastboot mode versus a reboot. Specifically, when I flash the kernel and run `fastboot reboot`, adb has always come up, but booting the kernel from RAM results in about 30% adb detection fail rate. I'll keep an eye on this. $ adb shell lsmod Module Size Used by at24 24576 0 dwc3_exynos 12288 0 i2c_exynos5 28672 0 ufs_exynos 32768 0 phy_exynos_ufs 20480 1 phy_exynos5_usbdrd 36864 2 s3c2410_wdt 24576 0 arm_dsu_pmu 24576 0 Thanks, Will