From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17E37C2BD09 for ; Mon, 24 Jun 2024 13:10:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zHS3a0IilTvWchyAjA9rALp7dPl8Z+VKE/TBgCpRZ18=; b=0vcQCalKYUbbVpemqwFgejwGWF UftnazBq49c/E8eaZrqREKA/NeG2Bs8inXc6osTB5+8FWIj+VqBZwn+EP6bjh/wKIvKMwSiMEtXya H9IgzuKwQirLr3VtwTLla+qwWeQ8HKe80pEyFzQ9RbGLBb78WiImJI+pp7QloE5MroNcmQQ8L9z2z QoWVkUdGupEEU4QERxH2aj+RD7lSQOj56guBd57+JoypohijtJ9HzwxC6jvRTvGZc5cOmfB61d7gr /DZzc+MQ6WSIuOowIFM10n9dv+RVTHWA2qck3SGPVgVQ2eStGfIeX75U5Y340TSHO7E20y6SAwlbj mrhlGpZg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLjSZ-0000000GsHS-2D5e; Mon, 24 Jun 2024 13:10:15 +0000 Received: from sin.source.kernel.org ([145.40.73.55]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLjSU-0000000GsFw-0fDl for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 13:10:12 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 4B529CE0225; Mon, 24 Jun 2024 13:10:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 513EBC2BBFC; Mon, 24 Jun 2024 13:10:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1719234605; bh=ZNOSYfBHU/JMuVbC+tYd2ovrK1RAxjtVc4gjOkw6ABg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=E3LtX1a+ym/XRSuXi3JcEcN6ZrO5QaXBt04cprYKbO9DHL/ZReeLpP7kIX6MhiBW9 0eCWDYXHvLq8A6cFoBHfAYTtHEIhFOyf+tA8TEjgGZNm842OBMFzarBrmwz3oMAW5a GIj3jr3uRY752pwNNBvyg7mtxKmHjya1hWK3VWf1SB2bm8GsmPIokcOtDAZpS3E/77 2LptiL8ws/Q4L+TVctY5N1u1GhuSeTqi84WkUBMxbW+bMCDIZ0xH8zpbWmX0Ohs5vD GHV+izLD5RukacXXTN28RniOyyRraa1Kb0XDlwdL0IH1ZEJx57iQy8hCWeTdNHMmhz lm/ylSdbxj1XQ== Date: Mon, 24 Jun 2024 15:10:02 +0200 From: Lorenzo Bianconi To: Sunil Kovvuri Goutham Cc: "netdev@vger.kernel.org" , "nbd@nbd.name" , "lorenzo.bianconi83@gmail.com" , "davem@davemloft.net" , "edumazet@google.com" , "kuba@kernel.org" , "pabeni@redhat.com" , "conor@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "devicetree@vger.kernel.org" , "catalin.marinas@arm.com" , "will@kernel.org" , "upstream@airoha.com" , "angelogioacchino.delregno@collabora.com" , "benjamin.larsson@genexis.eu" , Ratheesh Kannoth , "andrew@lunn.ch" Subject: Re: [PATCH v3 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC Message-ID: References: <89c9c226ddb31d9ff3d31231e8f532a3e983363a.1719159076.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="NNCf/2QvrUCQb5Bk" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_061010_709444_214306B1 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --NNCf/2QvrUCQb5Bk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Jun 24, Sunil Kovvuri Goutham wrote: > >Add airoha_eth driver in order to introduce ethernet support for > >Airoha EN7581 SoC available on EN7581 development board (en7581-evb). > >en7581-evb networking architecture is composed by airoha_eth as mac > >controller (cpu port) and a mt7530 dsa based switch. > >EN7581 mac controller is mainly composed by Frame Engine (FE) and > >QoS-DMA (QDMA) modules. FE is used for traffic offloading (just basic > >functionalities are supported now) while QDMA is used for DMA operation > >and QOS functionalities between mac layer and the dsa switch (hw QoS is > >not available yet and it will be added in the future). > >Currently only hw lan features are available, hw wan will be added with > >subsequent patches. > > > >Tested-by: Benjamin Larsson > >Signed-off-by: Lorenzo Bianconi > >--- > > > >+ > >+static int airoha_qdma_rx_process(struct airoha_queue *q, int budget) > >+{ > ...................... > >+ skb->ip_summed =3D CHECKSUM_UNNECESSARY; >=20 > Unconditionally setting UNNECESSARY for all pkts. > Does HW reports csum errors ? We enabled packet drop if TCP/UDP or IPv4 checksum is failed in REG_GDM1_FWD_CFG register in airoha_fe_maccr_init(). In other words, if the= nic forwards the packet to the cpu, the checksum is correct. Regards, Lorenzo >=20 > Thanks, > Sunil. >=20 --NNCf/2QvrUCQb5Bk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZnlwKgAKCRA6cBh0uS2t rCeUAQDKuiP8GcpikHBr84SEuvT2ObofyIaTjhI/xxlz0rkpFAD/Q6Wzz+Tg2yEk jIjJqWEzCeodNO22dp30ELA/3VjhzA4= =jhix -----END PGP SIGNATURE----- --NNCf/2QvrUCQb5Bk--