From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7265C2D0D1 for ; Mon, 24 Jun 2024 14:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=etiO1bY3Sy9m0+a2zHsJt8m/32V096tGftgNINz+4ec=; b=L2Tua3Sv2uYIySzR91lkpvkq7H fhVqLnqgjU0eTqmP+LuCVb0EcRY8wzWKip4nZll/jQRQbxemEOax1I9aJ+3iSlPeHrrlukkvraC7G zAOgLvc6VAU1VHZf4+yqJSQyBBm2f6t9fBpeFIs1SwS+FpxraNcC5za+TrdN+6xAW7YBFdvy2jTjX FijRfWeP2/lCWmVtJilQe9wnAsAwyahFEeA+zqPeOxbYm3VgzjgFyvYt2d2ki7ZqRLybTqsueT5fM caDUqgkgkPnQGHUn/BMmQ4K7tvjtG/j0ScV0A9hwApUU26Qjf7OBGuMg0ovEIzsa6AhI8ahaG/MbA tjc0VivQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLkzz-0000000HA8N-0gbc; Mon, 24 Jun 2024 14:48:51 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sLkzs-0000000HA64-2QOh for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2024 14:48:47 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 59A2BDA7; Mon, 24 Jun 2024 07:49:07 -0700 (PDT) Received: from bogus (e103737-lin.cambridge.arm.com [10.1.197.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C26CE3F73B; Mon, 24 Jun 2024 07:48:40 -0700 (PDT) Date: Mon, 24 Jun 2024 15:48:38 +0100 From: Sudeep Holla To: Youwan Wang Cc: guohanjun@huawei.com, lenb@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, lpieralisi@kernel.org, rafael@kernel.org, catalin.marinas@arm.com, will@kernel.org, Sudeep Holla Subject: Re: [PATCH v4] ACPI / amba: Drop unnecessary check for registered amba_dummy_clk Message-ID: References: <20240620133758.319392-1-youwan@nfschina.com> <20240624023101.369633-1-youwan@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240624023101.369633-1-youwan@nfschina.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240624_074844_714384_1A4AC7C1 X-CRM114-Status: GOOD ( 13.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 24, 2024 at 10:31:01AM +0800, Youwan Wang wrote: > amba_register_dummy_clk() is called only once from acpi_amba_init() > and acpi_amba_init() itself is called once during the initialisation. > amba_dummy_clk can't be initialised before this in any other code > path and hence the check for already registered amba_dummy_clk is > not necessary. Drop the same. > > Signed-off-by: Youwan Wang > Acked-by: Sudeep Holla > Acked-by: Hanjun Guo > --- > v1->v2->v3: Modify the commit log description > v3->v4: Update the commit message suggested by Sudeep; > Add Acked-by from Sudeep; > +Cc ARM64 maintainers Catalin and Will. I think I have told you many time now and you are missing to understand few basic stuff. So I suggest to give `Documentation/process/submitting-patches.rst` under the kernel source a read and especially the section `The canonical patch format` Ideally this patch should have been v5 as you added Hanjun's Ack Also "v1->v2->v3: Modify the commit log description" makes no sense. The changelog should list all the deltas like: v4->v5: - v3->v4: - v2->v3: - v1->v2: - Anyways, it is only for your learning and future references. -- Regards, Sudeep