From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A2B2C2BBCA for ; Tue, 25 Jun 2024 14:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hGiPM6C5L/nRqsdu3jq0C7CbnwzvLeffETFeFxTX0+E=; b=joqAt9lRLtbxLw9pjpLm+e0t36 bc4lXUQGpDkORNTPu5ZyGgvCCkN0Y+jnPq/rjMKOdjMbqfTlZJ1mUNM1Y5eT8npSiuNG7gLBEmRSI P7s4mX8T/bYxI6PasUt75Cuza64lwZQ5/D+AlYPPT7Jj9l89WgkgLK6+HtMEJXF2qCfbYvJFGkOWz VfQ5CiL6VaAWa5CM1f+lHaZoNBcqTtnXv2Y1w5HBfVMMOdm9sDImCObRP0EoTbcfKfRcPvH6OPmoB 0TRNFTE7BkAfR+YlZre8chVF3WnEhKcAxPwW7Zt20o7A4G40wLudP1uovbgzkAS2cS6vAlhg4WGWi Et7TVr8g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM6oh-000000036yP-0rwP; Tue, 25 Jun 2024 14:06:39 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM6oc-000000036xu-1HrI for linux-arm-kernel@bombadil.infradead.org; Tue, 25 Jun 2024 14:06:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=hGiPM6C5L/nRqsdu3jq0C7CbnwzvLeffETFeFxTX0+E=; b=b3anXdf6y1JVACdaTmYa87Qdwz IXn7N2bJIfzk9KNwWXeg8tumh7lqXZTBdx3GEINGv9BNJyMrvBKM/tmlyIK+vjWWO7lMBqI2/gW4N XQP8c9u0eYpqkmTL11wjuLbSi2rQCqK2/qoiw2rq7DlGfa9/ApwsOpqEbj3j0JZ+Uy58IC72wpm44 RVUjYWXi/WdkaINNa8n4X8Kgwq91tskrXsMl9afIlOrW59G3xNzWOCh56uVJUJram+C2/i0JjGNRT VvpU11sKddLUsxQfVklfujUBPT4Ny+My7k0dM+8H17DBjtzWVsKSKnjwEbtWus2udI+8mjTe8+C63 EkRPsf+A==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sM6oT-0000000BCMT-2TZf; Tue, 25 Jun 2024 14:06:25 +0000 Date: Tue, 25 Jun 2024 15:06:25 +0100 From: Matthew Wilcox To: Ryan Roberts Cc: Baolin Wang , Kefeng Wang , Catalin Marinas , Will Deacon , Ard Biesheuvel , Marc Zyngier , James Morse , Andrey Ryabinin , Andrew Morton , Mark Rutland , David Hildenbrand , John Hubbard , Zi Yan , Barry Song <21cnbao@gmail.com>, Alistair Popple , Yang Shi , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , "Yin, Fengwei" , linux-arm-kernel@lists.infradead.org, x86@kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings Message-ID: References: <20240215103205.2607016-19-ryan.roberts@arm.com> <1285eb59-fcc3-4db8-9dd9-e7c4d82b1be0@huawei.com> <8d57ed0d-fdd0-4fc6-b9f1-a6ac11ce93ce@arm.com> <018b5e83-789e-480f-82c8-a64515cdd14a@huawei.com> <43a5986a-52ea-4090-9333-90af137a4735@linux.alibaba.com> <306874fe-9bc1-4dec-a856-0125e4541971@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 02:41:18PM +0100, Ryan Roberts wrote: > On 25/06/2024 14:06, Matthew Wilcox wrote: > > On Tue, Jun 25, 2024 at 01:41:02PM +0100, Ryan Roberts wrote: > >> On 25/06/2024 13:37, Baolin Wang wrote: > >> > >> [...] > >> > >>>>> For other filesystems, like ext4, I did not found the logic to determin what > >>>>> size of folio to allocate in writable mmap() path > >>>> > >>>> Yes I'd be keen to understand this to. When I was doing contpte, page cache > >>>> would only allocate large folios for readahead. So that's why I wouldn't have > >>> > >>> You mean non-large folios, right? > >> > >> No I mean that at the time I wrote contpte, the policy was to allocate an > >> order-0 folio for any writes that missed in the page cache, and allocate large > >> folios only when doing readahead from storage into page cache. The test that is > >> regressing is doing writes. > > > > mmap() faults also use readahead. > > > > filemap_fault(): > > > > folio = filemap_get_folio(mapping, index); > > if (likely(!IS_ERR(folio))) { > > if (!(vmf->flags & FAULT_FLAG_TRIED)) > > fpin = do_async_mmap_readahead(vmf, folio); > > which does: > > if (folio_test_readahead(folio)) { > > fpin = maybe_unlock_mmap_for_io(vmf, fpin); > > page_cache_async_ra(&ractl, folio, ra->ra_pages); > > > > which has been there in one form or another since 2007 (3ea89ee86a82). > > OK sounds like I'm probably misremembering something I read on LWN... You're > saying that its been the case for a while that if we take a write fault for a > portion of a file, then we will still end up taking the readahead path and > allocating a large folio (filesystem permitting)? Does that apply in the case > where the file has never been touched but only ftruncate'd, as is happening in > this test? There is obviously no need for IO in that case, but have we always > taken a path where a large folio may be allocated for it? I thought that bit was > newer for some reason. The pagecache doesn't know whether the file contains data or holes. It allocates folios and then invites the filesystem to fill them; the filesystem checks its data structures and then either issues reads if there's data on media or calls memset if the records indicate there's a hole. Whether it chooses to allocate large folios or not is going to depend on the access pattern; a sequential write pattern will use large folios and a random write pattern won't. Now, I've oversimplified things a bit by talking about filemap_fault. Before we call filemap_fault, we call filemap_map_pages() which looks for any suitable folios in the page cache between start and end, and maps those.