From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DAD5C27C4F for ; Wed, 26 Jun 2024 15:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=e1GHg0adTDcx7aelMd7sHYAvXl2IXilBtvZqQq6vi+0=; b=m59/r4erGjhW3LcNIVJbe2LwDU Hn2rUBtBgp+QjUepvxDbn5KcVu6vZUzvCtXmu9qK5VxQ5qoUrboGFu7doT8FObMeCt1D1OcVafwGH SpYV9NcyFnAgL1r8FlzsBFqL7I18gwIYXqL1KktRwZDtT3X913k2/Y07nuuCpZoXpskPTt0WSVIKT sjXZMtyGT1+eavVxyUmFK6eI9uaYL+p85YkBLS5VhmM30uNG+7o2QEZ5uUVJyHugem8RqwnLGXofL sqUoeuz3CXs5p9OYEX7MAxZzJoIs+EJMheOXHuYn3l/K7eoD8fzFprnZJSuxhq8oH2FYPrmcbQwCI FR8ioyKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMUKX-00000007LWv-1sTW; Wed, 26 Jun 2024 15:13:05 +0000 Received: from mail-ej1-f42.google.com ([209.85.218.42]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMUKP-00000007LRr-0eN7 for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 15:12:59 +0000 Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a7194ce90afso558506066b.2 for ; Wed, 26 Jun 2024 08:12:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719414775; x=1720019575; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e1GHg0adTDcx7aelMd7sHYAvXl2IXilBtvZqQq6vi+0=; b=eCE3D2nVsZmvNS+Sdc4VIhddavjUdYbk1TCfwyARtIPu/X+HAPBZ7mZeMiuKJmf5EE rJbCEICPVbawZGHf/vikFtlumExMVggY3/LzOgiogjAwSwO/XDe7045127dzgKSzapzk 2h7cenIj56telKB2sdEkNrSUbeIbRs0Dp5cmL4mJKMx9kcZ6G5/EZpOhysrTXRF0PK8m fEqervPzOEQNkUMtpY85DFnRClcaEFB49LyCNoIaFwKKOkk3Do+Y+2F12QXi4BgaObbf grEh0WXIB2bTM7hh3FPY+WLT6+aQ/zrChnxSQ47txebSjdnpHRy1HZGqKo8Hd5nyXZTb uOEQ== X-Forwarded-Encrypted: i=1; AJvYcCXplS7uLshxEHESGU0Wxx0hg3hs2JvhdTBMFAjax23AUUINNVKYql0jOXXL8uTt8WhH+yCX+xl+/hIHzo5iullEfm7UrFeqgCiZNSysiHURPE1NmEM= X-Gm-Message-State: AOJu0YwFhrn8XleqgvVjBqWbf30IPG3XMKekyEcw86PC9A6wiGlLDSmP X0cHRmoegcA4d0JWcuq9Y2XqVe5vbyeYSsmv+S7ja2FWD2/3twXE X-Google-Smtp-Source: AGHT+IHlNljuWeKDcLWfXayPDJUHx5Lh29W+LGEbEWNZhl8VBElSvXc8Crp+UM6H/K7zRlBb/fSC5Q== X-Received: by 2002:a17:907:a096:b0:a72:65c5:315e with SMTP id a640c23a62f3a-a7265c53ea1mr511015666b.21.1719414774523; Wed, 26 Jun 2024 08:12:54 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-006.fbsv.net. [2a03:2880:30ff:6::face:b00c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a725459233csm326571866b.96.2024.06.26.08.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 08:12:54 -0700 (PDT) Date: Wed, 26 Jun 2024 08:12:51 -0700 From: Breno Leitao To: Jakub Kicinski Cc: Sunil Goutham , "David S. Miller" , Eric Dumazet , Paolo Abeni , horms@kernel.org, "moderated list:ARM/CAVIUM THUNDER NETWORK DRIVER" , "open list:NETWORKING DRIVERS" , open list Subject: Re: [PATCH net-next] net: thunderx: Unembed netdev structure Message-ID: References: <20240624102919.4016797-1-leitao@debian.org> <20240625175434.53ccea3a@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240625175434.53ccea3a@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_081257_276876_D088C5B4 X-CRM114-Status: GOOD ( 11.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 25, 2024 at 05:54:34PM -0700, Jakub Kicinski wrote: > On Mon, 24 Jun 2024 03:29:18 -0700 Breno Leitao wrote: > > static void bgx_lmac_handler(struct net_device *netdev) > > { > > - struct lmac *lmac = container_of(netdev, struct lmac, netdev); > > + struct lmac *lmac = netdev_priv(netdev); > > I think you are storing a pointer to lmac, so: > > struct lmac **priv = netdev_priv(netdev); > struct lmac *lmac = *priv; Good catch. you are absolutely correct. I will update.