From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D3395C30653 for ; Wed, 26 Jun 2024 23:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K3pmB34cCwtjnl+eYO8f6Z1wbmFiYiECc2kegHJsZVI=; b=oJkZA2ZdV3pKXU2z+CAci6Vl8v TktARDWLhze1BEmtBppSXdYvRuxhdn+BeQEP4EpgZRp9n8taPOBco6DI6iCo2c8GLOMh2jA7W4tau qZC1N4z6v6utw76QGv23eWhvuA7YgagxCQhFMEig0wfGQsku4n7INeELFPsl7jKsCJ8WmWXy2uWjl AN3QusEA3CVR309XNTX6ZoGK/JQE3XuF7Nr/TOqKTd7xg3x945H4/gZRekRKQy2QijI6BpoTtUvCi Bfr5xHCGICMStkjKaGP/cWr7dkucM84HZPngtbk25zVjBdQxT+7ztzBQAV7qwfVXe6uleQWrtRcsV Fh9kvKzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMcEN-00000008e9a-1E6S; Wed, 26 Jun 2024 23:39:15 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sMcEE-00000008e6m-0QNw for linux-arm-kernel@lists.infradead.org; Wed, 26 Jun 2024 23:39:07 +0000 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-1fa901ad6f3so39315ad.0 for ; Wed, 26 Jun 2024 16:39:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719445145; x=1720049945; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=K3pmB34cCwtjnl+eYO8f6Z1wbmFiYiECc2kegHJsZVI=; b=sxOFXlVODJMQ9dbgiTeqYWpQ6ShP3KWqk47aJS6muS5pr8lXieQ7X8Z94+eQiM4xBy 9drw+6F6M47aNZzDDqz+rooLKhoQ6m38CKAx3DILUtmOuHdvwLdwDIFWl/XoA1SUNZku /IyM9GOu//2JkpDCCddFK5P30toCSK7+Q0tGNymJ7rTJiTplPRtDPlgsooizA93s5NZm fDXTbdo6tmaSl8yBXkFbCOdaQZi0qJguj6GeaZd9K85M31W6uRHnTHkAda/Cuvl9bMgy jVHltPVxXhEwpD9b/W17W/rLRQV4waVNA2IZoAzP+dT21RP7X+/CE/h+Z8HNL39UPQ2Z bRkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719445145; x=1720049945; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=K3pmB34cCwtjnl+eYO8f6Z1wbmFiYiECc2kegHJsZVI=; b=ai+P7UoV0G6IGaU15Z7S1xvSjxksk41egh51YGYRxvCN/iOtndmCW1Zwl9zCN2PPH9 mFNgu1/wpmJhJCjjBqHlUJ3qxTZn0lv/3fKAqnxR3um3bwZRWgWkKYmf4C/+coalnEeA /D0zqoW96ip6qlWSs4fEP9XSRZk3DGpnBDqS+1Iwp/aGbnYE2TxrJRq986yutsDRW5yN RtHzsW0IN3QdS9yBoReV4kAjGPM3EkUYdZbmgCRndAC+L2HAEciDZEXZASoX3qyHflic 7yNv606U43MRH4V636vbk0p8/xvQsV9tCBSvTG+pwJHQCouzCr8rKljbWANoNgQGyc2k QI9w== X-Forwarded-Encrypted: i=1; AJvYcCXS+tdCRIACM5xOd2s36zfW2fEV6Afpf50htNscVJdIpV4d0LfU5wQEvmMzibbTWzdswfZV9VOsUmOisNvHZyETNU1w0tSnYf3Zv1LrTNBQM2X4O7Y= X-Gm-Message-State: AOJu0YwOoejs5MdDHoEEtaGKnerx0+kbHSLzzGocFvTye7aWmPwfPQUv UIIjVM4qtPlyUQFg9/0xqLJWXLbRZHjin+4WN75AHN/PYG3q9/3+HkWbQIeW5A== X-Google-Smtp-Source: AGHT+IHRdsS+/Y76sEwDfKIkrb+jsZorceifOYSrWmMRro/2TsN9MxZqihS12VYFCI7AWUK+mR2ByA== X-Received: by 2002:a17:902:f74d:b0:1f6:5bba:8ea3 with SMTP id d9443c01a7336-1faab5992d7mr812505ad.25.1719445144627; Wed, 26 Jun 2024 16:39:04 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1faac99a30fsm527375ad.223.2024.06.26.16.39.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Jun 2024 16:39:03 -0700 (PDT) Date: Wed, 26 Jun 2024 16:39:00 -0700 From: William McVicker To: Peter Griffin Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, alim.akhtar@samsung.com, s.nawrocki@samsung.com, cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, tudor.ambarus@linaro.org, andre.draszik@linaro.org, kernel-team@android.com, devicetree@vger.kernel.org, linux-clk@vger.kernel.org Subject: Re: [PATCH 2/3] soc: samsung: exynos-pmu: add support for PMU_ALIVE non atomic registers Message-ID: References: <20240626194300.302327-1-peter.griffin@linaro.org> <20240626194300.302327-3-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240626194300.302327-3-peter.griffin@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240626_163906_265741_2299FCD2 X-CRM114-Status: GOOD ( 21.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/26/2024, Peter Griffin wrote: > Not all registers in PMU_ALIVE block support atomic set/clear operations. > GS101_SYSIP_DAT0 and GS101_SYSTEM_CONFIGURATION registers are two regs > where attempting atomic access fails. > > As documentation on exactly which registers support atomic operations is > not forthcoming. We default to atomic access, unless the register is > explicitly added to the tensor_is_atomic() function. Update the comment > to reflect this as well. > > Signed-off-by: Peter Griffin Reviewed-by: Will McVicker Tested-by: Will McVicker I verified reboot and power off on my Pixel 6 Pro. > --- > drivers/soc/samsung/exynos-pmu.c | 16 ++++++++++++++-- > include/linux/soc/samsung/exynos-regs-pmu.h | 4 ++++ > 2 files changed, 18 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/samsung/exynos-pmu.c b/drivers/soc/samsung/exynos-pmu.c > index 624324f4001c..5556acc7c092 100644 > --- a/drivers/soc/samsung/exynos-pmu.c > +++ b/drivers/soc/samsung/exynos-pmu.c > @@ -129,14 +129,26 @@ static int tensor_set_bits_atomic(void *ctx, unsigned int offset, u32 val, > return ret; > } > > +static bool tensor_is_atomic(unsigned int reg) > +{ > + switch (reg) { > + case GS101_SYSIP_DAT0: > + case GS101_SYSTEM_CONFIGURATION: > + return false; > + default: > + return true; > + } > +} > + > static int tensor_sec_update_bits(void *ctx, unsigned int reg, > unsigned int mask, unsigned int val) > { > /* > * Use atomic operations for PMU_ALIVE registers (offset 0~0x3FFF) > - * as the target registers can be accessed by multiple masters. > + * as the target registers can be accessed by multiple masters. Some > + * SFRs don't support this however as reported by tensor_is_atomic() > */ > - if (reg > PMUALIVE_MASK) > + if (reg > PMUALIVE_MASK || !tensor_is_atomic(reg)) nit: Should we just move all the logic, e.g. `reg > PMUALIVE_MASK` into `tensor_is_atomic()`? [...] Thanks, Will