From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF57FC2BD09 for ; Tue, 9 Jul 2024 09:30:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3UrNehCdEOz3kmpljIH4fi/GT8Naw2VAyq67V1zlRwE=; b=KIPQHWr+Sl2GPGDvn4tyEoNIlL Txdq5mREMjdP7g8zkMLbTMEFV374PPK6KQUbZVqHM+UnbE845SNCB5ign41oENVRkpkPT+w/MLWte wdYxr968UiA6e4SMZ3VIkyLyqtznJ/bbZBDXom+gHdN1A3PbMQI7OoVsoO0rPEmCDMcnREZycgHaU 09lgXMCg7XZnzacpUGpXdw1h1R+at5/ECZ0/dVjYzrvniv5D0EwKlaxTcpIbKNVwMPYZBhbmaj7pe S4+hd/yQMYNe/ESJjZhNakB/IWRJATAZzeFJ1sB87RofhjiXVD+plLyfo9JJoTOW8PHZm9oc4HcOU dUZvKXxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR7Ax-00000006cHe-2Qit; Tue, 09 Jul 2024 09:30:19 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR7Ah-00000006cDT-1cJE for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 09:30:04 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720517401; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3UrNehCdEOz3kmpljIH4fi/GT8Naw2VAyq67V1zlRwE=; b=fU895IMACKyjuXsEGnBd5uEQ2PAZdVR3NpFe49GzAoUWWsp1f3vRQv8MjigVrU7vm01lLg bk04jMgpMQPX2I5RUtHzxT/qkfxoUf1W8/tgeGRxpdN0HBGb8aG4GCAuChYPWvwaF7sEXg Q1SIqsLrVbuHGmyEZTlmJTrmC+oavbs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-454-M8UPmP1PMDilwb-uNonikA-1; Tue, 09 Jul 2024 05:29:57 -0400 X-MC-Unique: M8UPmP1PMDilwb-uNonikA-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 3CC6B1936187; Tue, 9 Jul 2024 09:29:53 +0000 (UTC) Received: from localhost (unknown [10.72.116.15]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D0D441955F40; Tue, 9 Jul 2024 09:29:49 +0000 (UTC) Date: Tue, 9 Jul 2024 17:29:45 +0800 From: Baoquan He To: Jinjie Ruan Cc: linux@armlinux.org.uk, vgoyal@redhat.com, dyoung@redhat.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, arnd@arndb.de, afd@ti.com, akpm@linux-foundation.org, rmk+kernel@armlinux.org.uk, linus.walleij@linaro.org, eric.devolder@oracle.com, gregkh@linuxfoundation.org, deller@gmx.de, javierm@redhat.com, robh@kernel.org, thunder.leizhen@huawei.com, austindh.kim@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH 0/3] ARM: Use generic interface to simplify crashkernel reservation Message-ID: References: <20240708133348.3592667-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240708133348.3592667-1-ruanjinjie@huawei.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_023003_498993_785DFC0D X-CRM114-Status: UNSURE ( 9.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/08/24 at 09:33pm, Jinjie Ruan wrote: > Currently, x86, arm64, riscv and loongarch has been switched to generic > crashkernel reservation. Also use generic interface to simplify crashkernel > reservation for arm32, and fix two bugs by the way. I am not sure if this is a good idea. I added the generic reservation itnerfaces for ARCH which support crashkernel=,high|low and normal crashkernel reservation, with this, the code can be simplified a lot. However, arm32 doesn't support crashkernel=,high, I am not sure if it's worth taking the change, most importantly, if it will cause misunderstanding or misoperation. Thanks Baoquan