linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
	sudeep.holla@arm.com, james.quinlan@broadcom.com,
	f.fainelli@gmail.com, vincent.guittot@linaro.org,
	etienne.carriere@foss.st.com, peng.fan@oss.nxp.com,
	michal.simek@amd.com, quic_sibis@quicinc.com,
	quic_nkela@quicinc.com, ptosi@google.com,
	souvik.chakravarty@arm.com
Subject: Re: [PATCH 6/8] firmware: arm_scmi: Make OPTEE transport a standalone driver
Date: Tue, 9 Jul 2024 10:55:42 +0100	[thread overview]
Message-ID: <Zo0JHtuZo_tKEMzP@pluto> (raw)
In-Reply-To: <e27dc456-33bc-450e-8e54-1cd5b7ae11ef@suswa.mountain>

On Tue, Jul 09, 2024 at 04:21:46AM +0200, Dan Carpenter wrote:
> On Sun, Jul 07, 2024 at 01:20:53AM +0100, Cristian Marussi wrote:
> >  static int scmi_optee_service_probe(struct device *dev)
> >  {
> >  	struct scmi_optee_agent *agent;
> > @@ -555,7 +553,7 @@ static int scmi_optee_service_probe(struct device *dev)
> >  	smp_mb();
> >  	scmi_optee_private = agent;
> >  
> > -	return 0;
> > +	return platform_driver_register(&scmi_optee_driver);

Hi Dan,

thanks for having a look !

> 
> There needs to be some cleanup if platform_driver_register() fails.
> 


Yes, indeed....also smatch/sparse screamed a lot in some other
places...I will rework in V2.

Thanks,
Cristian


  reply	other threads:[~2024-07-09 11:00 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-07  0:20 [PATCH 0/8] Make SCMI transport as standalone drivers Cristian Marussi
2024-07-07  0:20 ` [PATCH 1/8] firmware: arm_scmi: Introduce setup_shmem_iomap Cristian Marussi
2024-07-07 16:48   ` Nikunj Kela
2024-07-08  9:26     ` Cristian Marussi
2024-07-08  2:19   ` kernel test robot
2024-07-07  0:20 ` [PATCH 2/8] firmware: arm_scmi: Introduce packet handling helpers Cristian Marussi
2024-07-08  3:59   ` kernel test robot
2024-07-07  0:20 ` [PATCH 3/8] firmware: arm_scmi: Add support for standalone transport drivers Cristian Marussi
2024-07-07  0:20 ` [PATCH 4/8] firmware: arm_scmi: Make MBOX transport a standalone driver Cristian Marussi
2024-07-07  0:20 ` [PATCH 5/8] firmware: arm_scmi: Make SMC " Cristian Marussi
2024-07-07 16:03   ` kernel test robot
2024-07-07 16:52   ` Nikunj Kela
2024-07-08 14:27     ` Cristian Marussi
2024-07-08 15:23       ` Nikunj Kela
2024-07-08 15:47         ` Cristian Marussi
2024-07-08 17:59           ` Nikunj Kela
2024-07-09 10:33             ` Cristian Marussi
2024-10-15 16:31             ` Cristian Marussi
2024-07-09 12:45   ` kernel test robot
2024-07-10  3:37   ` kernel test robot
2024-07-07  0:20 ` [PATCH 6/8] firmware: arm_scmi: Make OPTEE " Cristian Marussi
2024-07-09  2:21   ` Dan Carpenter
2024-07-09  9:55     ` Cristian Marussi [this message]
2024-07-07  0:20 ` [PATCH 7/8] firmware: arm_scmi: Make VirtIO " Cristian Marussi
2024-07-08  5:53   ` kernel test robot
2024-07-07  0:20 ` [PATCH 8/8] firmware: arm_scmi: Remove legacy transport-layer code Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zo0JHtuZo_tKEMzP@pluto \
    --to=cristian.marussi@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=dan.carpenter@linaro.org \
    --cc=etienne.carriere@foss.st.com \
    --cc=f.fainelli@gmail.com \
    --cc=james.quinlan@broadcom.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=peng.fan@oss.nxp.com \
    --cc=ptosi@google.com \
    --cc=quic_nkela@quicinc.com \
    --cc=quic_sibis@quicinc.com \
    --cc=souvik.chakravarty@arm.com \
    --cc=sudeep.holla@arm.com \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).