From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A434C2BD09 for ; Tue, 9 Jul 2024 11:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZzVK1gLppyl3zaiMRV+d/Rgxq6DnXjRfWbcFJVxBUWo=; b=xMYWmNnzfWNdGBy+8C3RQyCBsB 95KLkZDWVfYf6nUAi58lgNV4cZU6YvAmLR6sSyZ2ZdAyYZQuIbih65JSoeizqFLH94wo9OGHBKFFz NmNIYiklyCrUBJNj+2jMWvIR+IhLN8ZipwN+I5qXBDCMvNn7VW1BErLVSTDpwhwaf/J0jlg0RI+ft rfT2xpttafWufjJEPQOJWGKH9SPGlGVb4w2Zx8gdgrOUw0XGckcag4a1FElCcMvxTZL0SEi5HbUEt FZ180lO4IijYx2+ABV81JHmMERWvjtPs8GRWISaRmWXTa5mI/oVo5+UEuCxo5tVIjIKELaI5ZpbDU 9mf6D2gQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR8aB-00000006uJK-1UCI; Tue, 09 Jul 2024 11:00:27 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR7Zk-00000006hU8-0DOc for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 09:55:57 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C4FE91650; Tue, 9 Jul 2024 02:56:18 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D54B03F762; Tue, 9 Jul 2024 02:55:50 -0700 (PDT) Date: Tue, 9 Jul 2024 10:55:42 +0100 From: Cristian Marussi To: Dan Carpenter Cc: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, james.quinlan@broadcom.com, f.fainelli@gmail.com, vincent.guittot@linaro.org, etienne.carriere@foss.st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, ptosi@google.com, souvik.chakravarty@arm.com Subject: Re: [PATCH 6/8] firmware: arm_scmi: Make OPTEE transport a standalone driver Message-ID: References: <20240707002055.1835121-1-cristian.marussi@arm.com> <20240707002055.1835121-7-cristian.marussi@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_025556_237059_D8C39EF3 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 09, 2024 at 04:21:46AM +0200, Dan Carpenter wrote: > On Sun, Jul 07, 2024 at 01:20:53AM +0100, Cristian Marussi wrote: > > static int scmi_optee_service_probe(struct device *dev) > > { > > struct scmi_optee_agent *agent; > > @@ -555,7 +553,7 @@ static int scmi_optee_service_probe(struct device *dev) > > smp_mb(); > > scmi_optee_private = agent; > > > > - return 0; > > + return platform_driver_register(&scmi_optee_driver); Hi Dan, thanks for having a look ! > > There needs to be some cleanup if platform_driver_register() fails. > Yes, indeed....also smatch/sparse screamed a lot in some other places...I will rework in V2. Thanks, Cristian