From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3EB86C3DA47 for ; Tue, 9 Jul 2024 15:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=udOmhMw6nVnLDB7CnXYCG2+/atZ0tO+NBuzOh1Ic4BU=; b=nWc9WL5Qf6YZsiOSJIT0sZq40c SgcPaiPSQQiP/d+1cjL89czyW33PUa2w4uTyEwiQNjaXCkuXrx9rGX3H6vWYLTkUEOZ2xs9Gqsu2x 3dTYxE2aAA4EZpA7OFKDeLyXxkrGa/w45fNuraD3mKq6IO7AGSaohmZkTAnjq7c5kfRwNtSe6OXdP iZ2mW/ZuCOruDFVn8IuIIFMhdQ/G72cFmN4eoOAUYJd5kQiRDs6Tg1QvE6mvp5nf1vQBZzO35L/R7 ownMNW3FfvZmTMMOQZCoCwSbADzhyfihOKH9gdAkLtcFv5rndxtnOz+UFG5Wrm/hgMnwTUexTqAZO +LTMFfOQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRCZG-00000007hgJ-1I5i; Tue, 09 Jul 2024 15:15:46 +0000 Received: from mail-ed1-f47.google.com ([209.85.208.47]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRCYz-00000007hYi-0gX1 for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 15:15:30 +0000 Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-58b0dddab8cso7816657a12.0 for ; Tue, 09 Jul 2024 08:15:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720538127; x=1721142927; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=udOmhMw6nVnLDB7CnXYCG2+/atZ0tO+NBuzOh1Ic4BU=; b=UII9TeHyJiYbfaa0s8gt14WxV4HiEoj8fckN5A+ipk/+vgju3nRqlKGW6sZtcTzKnb mJuG2Ke5dG6oOmZ8i2a5kdfPZwsmlj0qCFO/f/fR9RKscpfdXDmafG7OkO3XAJfoTP66 yPb4LDqUpt/V4VxcoYSKrCrwSPuZnSp3+lsRqkb4Gco5EsbBufD6cJu7OA9YSMbN2trv VEK9hJ2P1h9sI5WfoFd9w2v70HPNsckRchEeNOD1hVquLAXxyaSfyWgs3mR9Rd9r1bPi hL8A5EUzgzDg/g0v9vMzgYkm+5nFLiYfQFrq/ECiNRG76fF8JOfnUs/P/ihQo2/UxcFp JAfQ== X-Forwarded-Encrypted: i=1; AJvYcCUdQPVKLw2VZPWKHc8Zd8UMEbSEaWX3T8m3zoJz2YxgGdENa/fJyZ1txlpmSrrYSlXHOxkRQfnjcZNxegdIYAjDFxR+C+ze5JlaiFXJusKwApO5GyY= X-Gm-Message-State: AOJu0YzVWhIl1AOAZhE2yUm9VbkBVIKq0IxXRDs+QlreZ8VALdwuvI4g hqbiwlRS0yaZYagvAuMi7WU6DDXyNIQTbmwf2kAGIv7vW6VmpfSS X-Google-Smtp-Source: AGHT+IF35/Mch11jtk1xVIeWdVFdvciZZUw5TTShgdZrcKMKdHljQsWt+u2oBbViFk5ZTk6F/AOa7g== X-Received: by 2002:a17:906:c083:b0:a6f:49b1:dec5 with SMTP id a640c23a62f3a-a780b705231mr177181466b.46.1720538126122; Tue, 09 Jul 2024 08:15:26 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-001.fbsv.net. [2a03:2880:30ff:1::face:b00c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a780a853a62sm83568866b.157.2024.07.09.08.15.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jul 2024 08:15:25 -0700 (PDT) Date: Tue, 9 Jul 2024 08:15:23 -0700 From: Breno Leitao To: Vladimir Oltean Cc: kernel test robot , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, kuba@kernel.org, horms@kernel.org, Roy.Pledge@nxp.com, open list Subject: Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST Message-ID: References: <20240624162128.1665620-1-leitao@debian.org> <202406261920.l5pzM1rj-lkp@intel.com> <20240626140623.7ebsspddqwc24ne4@skbuf> <20240708133746.ea62kkeq2inzcos5@skbuf> <20240709135811.c7tqh3ocfumg6ctt@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240709135811.c7tqh3ocfumg6ctt@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_081529_222880_772EB97A X-CRM114-Status: GOOD ( 24.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Vladimir, On Tue, Jul 09, 2024 at 04:58:11PM +0300, Vladimir Oltean wrote: > On Mon, Jul 08, 2024 at 12:08:05PM -0700, Breno Leitao wrote: > > I thought about a patch like the following (compile tested only). What > > do you think? > > To be honest, there are several things I don't really like about this > patch. > > - I really struggled with applying it in the current format. Could you > please post the output of git format-patch in the future? This is the output of `git format-patch` shifted right by a tab. > - You addressed dpaa_set_coalesce() but not also dpaa_fq_setup() > - You misrepresented the patch content by saying you only allocate size > for online CPUs in the commit message. But you allocate for all > possible CPUs. > - You only kfree(needs_revert) in the error (revert_values) case, but > not in the normal (return 0) case. > - The netdev coding style is to sort the lines with variable > declarations in reverse order of line length (they call this "reverse > Christmas tree"). Your patch broke that order. > - You should use kcalloc() instead of kmalloc_array() + memset() > > I have prepared and tested the attached alternative patch on a board and > I am preparing to submit it myself, if you don't have any objection. Sure, not a problem. You just asked how that would be possible, and I decided to craft patch to show what I had in mind. I am glad we have a way moving forward. Thanks for solving it.