From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BEBCC3DA42 for ; Wed, 10 Jul 2024 15:57:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uBj2YmtSTrFPZPUbLzrldXTaT0nXgCHgIoklfp+Mzk8=; b=k0qECVq2iEmfyi85sy+KQQpTFe H5zTa0aGjzvkj27+02GpYcz81fUF5aGm8ZY5ZYoG9vy3N44c36nuYl+CBfnkL1js2wGTvStv6cgJF YZFKGnzoiCeWSez250PgWBhey4A3wOWNiqWe3du4t5ZoJylOgzHH9Rog3TzW80X344U5ZCvwx4Jdn Mxe5SiIeB9eHxtAXZaLERmQBfgB59gKpSLw9SYFg6fFWCvqmLYK7rgVCvDmpoES3gk0uOi19pD12p wEepPKXZ9/CXggWxTnS9tAI24mzhQV1DtYk7aUBbp7ulZiEtj1HFGPQgJFnHRiKtG98K2hbcZPd/i 8wPZO1dw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRZgc-0000000B2Kx-1sIP; Wed, 10 Jul 2024 15:56:54 +0000 Received: from mail-pj1-x1032.google.com ([2607:f8b0:4864:20::1032]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sRZgK-0000000B2EV-1MD8 for linux-arm-kernel@lists.infradead.org; Wed, 10 Jul 2024 15:56:38 +0000 Received: by mail-pj1-x1032.google.com with SMTP id 98e67ed59e1d1-2c96f037145so4808143a91.3 for ; Wed, 10 Jul 2024 08:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1720626995; x=1721231795; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uBj2YmtSTrFPZPUbLzrldXTaT0nXgCHgIoklfp+Mzk8=; b=IwikkgiejhZ73pXiE6cTdNW78FrAD0vjGAI6YdMOgTClIBhiVtS4GUradgw1s0T2Sb DM14rqYuhm5CYeFN6zQDsw6v8eUpzhk+3+rT45QSFbuxcQvz+nybgoZowvVSbatLgxT4 yJreVkJ8L1RWbBrbbhjmPDApUCaiYFGcbK8lSNgxJ6OWoSkaaCBT8DbI0xZRpTwWcM5l TNFQLw8UxWNFS7UOzRQ8X9C2VuMHCeo7TGMMMs13A/ltXkJk4kDGuLbmuxiTktDxpfRf X0Wq3asEf3tkdm2p1qoMNul2Kfk5a9BDyyC00APItw51GNBvQoTCV36ryZTLqvsntTB2 EXUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720626995; x=1721231795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=uBj2YmtSTrFPZPUbLzrldXTaT0nXgCHgIoklfp+Mzk8=; b=pHSiRLcwD+pnT1kj5s0zQPLC8gzlMWWLQmeERcU+Vdibp9i8h6wZJpTlo69OXuo6rK 348Y435E306f8ENnXkzaE1uNKAm1HYZMtMg6tEO8ENmNdiFRc9VKORMKLdG9dkAg2IcX oHJMzGMyq4JnzkLMmQrTUy6uiYs6NNh3l+R5HxdVdr22AQGqiGERPTKwEmt/Wc6C8LSK 0LpXZiLlPxukhI5Ds+QiGEZ/GFkq2R3nG07WVpD7gHXM7pqATRTtT0ce+U7E//znmEXt yUD4WlZ2dL5I6sG08df4IBZCwtRAxCZB4ZOD3E9cu0Wa4L4cArqqsIaRjMs60ARyxtlq t+gA== X-Forwarded-Encrypted: i=1; AJvYcCWFR+zvO465+iHvLeGnKVw0RC6rBoU224+dckUiNmMCiO3PaD1E6wEZaJal7bOAp92E3d4nihciM1vkHlGSwPwPytFNcWxqyUmBhrCkp7q/EQdc8I0= X-Gm-Message-State: AOJu0YwGk1nTNKKS/m/3JOb89FBIuxh2V1Dy0ZzDUz2jsXXM11scTMRV kugLt3/YlWBkn9JY295cA6e2LnTSrxwIA1yPf2RjB0NoXmzLUFf9h7h/ThONFb0= X-Google-Smtp-Source: AGHT+IER42wfBDvYrn5WVV2tIZB6J3uCihrTxDQpbbWz7C02veVVpbReOeakDmwhl/pQRtvuZYvxfA== X-Received: by 2002:a17:90a:c385:b0:2c9:66d3:4663 with SMTP id 98e67ed59e1d1-2ca35d58971mr4748875a91.43.1720626994926; Wed, 10 Jul 2024 08:56:34 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:8408:4ecd:288d:848b]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ca34e6fc0csm3985584a91.21.2024.07.10.08.56.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Jul 2024 08:56:34 -0700 (PDT) Date: Wed, 10 Jul 2024 09:56:32 -0600 From: Mathieu Poirier To: Shun-yi Wang Cc: Bjorn Andersson , Matthias Brugger , AngeloGioacchino Del Regno , linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, jason-ch.chen@mediatek.com, yaya.chang@mediatek.com, teddy.chen@mediatek.com, olivia.wen@mediatek.com Subject: Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions Message-ID: References: <20240703115308.17436-1-shun-yi.wang@mediatek.com> <20240703115308.17436-2-shun-yi.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240703115308.17436-2-shun-yi.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240710_085636_401865_C22BA30B X-CRM114-Status: GOOD ( 21.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jul 03, 2024 at 07:53:08PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" > > SCP supports multiple reserved memory regions, intended for > specific hardwards. > > Signed-off-by: shun-yi.wang > --- > drivers/remoteproc/mtk_scp.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 9ecd5ea04b5f3..1902826cea0af 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -1006,22 +1006,31 @@ EXPORT_SYMBOL_GPL(scp_mapping_dm_addr); > > static int scp_map_memory_region(struct mtk_scp *scp) > { > - int ret; > + int ret, i, err; > const struct mtk_scp_sizes_data *scp_sizes; > + struct device_node *node = scp->dev->of_node; > + struct of_phandle_iterator it; > + > + i = 0; > + of_for_each_phandle(&it, err, node, "memory-region", NULL, 0) { > + ret = of_reserved_mem_device_init_by_idx(scp->dev, node, i); > + > + if (ret) { > + dev_err(scp->dev, "failed to assign memory-region: %s\n", > + it.node->name); > + of_node_put(it.node); > + return -ENOMEM; > + } With this patch the code is out of sync with the bindings which are still specifying a maxItems of 1 - please address. Thanks, Mathieu > > - ret = of_reserved_mem_device_init(scp->dev); > + i++; > + } > > /* reserved memory is optional. */ > - if (ret == -ENODEV) { > + if (!i) { > dev_info(scp->dev, "skipping reserved memory initialization."); > return 0; > } > > - if (ret) { > - dev_err(scp->dev, "failed to assign memory-region: %d\n", ret); > - return -ENOMEM; > - } > - > /* Reserved SCP code size */ > scp_sizes = scp->data->scp_sizes; > scp->cpu_addr = dma_alloc_coherent(scp->dev, scp_sizes->max_dram_size, > -- > 2.18.0 >