* [PATCH 0/1] Support multiple reserved memory regions @ 2024-07-03 11:53 Shun-yi Wang 2024-07-03 11:53 ` [PATCH 1/1] remoteproc: mediatek: " Shun-yi Wang 2024-07-10 15:54 ` [PATCH 0/1] " Mathieu Poirier 0 siblings, 2 replies; 5+ messages in thread From: Shun-yi Wang @ 2024-07-03 11:53 UTC (permalink / raw) To: Bjorn Andersson, Mathieu Poirier Cc: Matthias Brugger, AngeloGioacchino Del Regno, linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, jason-ch.chen, yaya.chang, teddy.chen, olivia.wen, shun-yi.wang From: "shun-yi.wang" <shun-yi.wang@mediatek.com> Besides the reserved memory region for SCP, there are additional reserved memory regions for specific hardware use. Currently, only a single memory region is supported. Modifications are made to support multiple memory regions. shun-yi.wang (1): remoteproc: mediatek: support multiple reserved memory drivers/remoteproc/mtk_scp.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) -- 2.18.0 ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions 2024-07-03 11:53 [PATCH 0/1] Support multiple reserved memory regions Shun-yi Wang @ 2024-07-03 11:53 ` Shun-yi Wang 2024-07-10 15:56 ` Mathieu Poirier 2024-07-12 8:21 ` AngeloGioacchino Del Regno 2024-07-10 15:54 ` [PATCH 0/1] " Mathieu Poirier 1 sibling, 2 replies; 5+ messages in thread From: Shun-yi Wang @ 2024-07-03 11:53 UTC (permalink / raw) To: Bjorn Andersson, Mathieu Poirier Cc: Matthias Brugger, AngeloGioacchino Del Regno, linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, jason-ch.chen, yaya.chang, teddy.chen, olivia.wen, shun-yi.wang From: "shun-yi.wang" <shun-yi.wang@mediatek.com> SCP supports multiple reserved memory regions, intended for specific hardwards. Signed-off-by: shun-yi.wang <shun-yi.wang@mediatek.com> --- drivers/remoteproc/mtk_scp.c | 25 +++++++++++++++++-------- 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c index 9ecd5ea04b5f3..1902826cea0af 100644 --- a/drivers/remoteproc/mtk_scp.c +++ b/drivers/remoteproc/mtk_scp.c @@ -1006,22 +1006,31 @@ EXPORT_SYMBOL_GPL(scp_mapping_dm_addr); static int scp_map_memory_region(struct mtk_scp *scp) { - int ret; + int ret, i, err; const struct mtk_scp_sizes_data *scp_sizes; + struct device_node *node = scp->dev->of_node; + struct of_phandle_iterator it; + + i = 0; + of_for_each_phandle(&it, err, node, "memory-region", NULL, 0) { + ret = of_reserved_mem_device_init_by_idx(scp->dev, node, i); + + if (ret) { + dev_err(scp->dev, "failed to assign memory-region: %s\n", + it.node->name); + of_node_put(it.node); + return -ENOMEM; + } - ret = of_reserved_mem_device_init(scp->dev); + i++; + } /* reserved memory is optional. */ - if (ret == -ENODEV) { + if (!i) { dev_info(scp->dev, "skipping reserved memory initialization."); return 0; } - if (ret) { - dev_err(scp->dev, "failed to assign memory-region: %d\n", ret); - return -ENOMEM; - } - /* Reserved SCP code size */ scp_sizes = scp->data->scp_sizes; scp->cpu_addr = dma_alloc_coherent(scp->dev, scp_sizes->max_dram_size, -- 2.18.0 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions 2024-07-03 11:53 ` [PATCH 1/1] remoteproc: mediatek: " Shun-yi Wang @ 2024-07-10 15:56 ` Mathieu Poirier 2024-07-12 8:21 ` AngeloGioacchino Del Regno 1 sibling, 0 replies; 5+ messages in thread From: Mathieu Poirier @ 2024-07-10 15:56 UTC (permalink / raw) To: Shun-yi Wang Cc: Bjorn Andersson, Matthias Brugger, AngeloGioacchino Del Regno, linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, jason-ch.chen, yaya.chang, teddy.chen, olivia.wen On Wed, Jul 03, 2024 at 07:53:08PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" <shun-yi.wang@mediatek.com> > > SCP supports multiple reserved memory regions, intended for > specific hardwards. > > Signed-off-by: shun-yi.wang <shun-yi.wang@mediatek.com> > --- > drivers/remoteproc/mtk_scp.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 9ecd5ea04b5f3..1902826cea0af 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -1006,22 +1006,31 @@ EXPORT_SYMBOL_GPL(scp_mapping_dm_addr); > > static int scp_map_memory_region(struct mtk_scp *scp) > { > - int ret; > + int ret, i, err; > const struct mtk_scp_sizes_data *scp_sizes; > + struct device_node *node = scp->dev->of_node; > + struct of_phandle_iterator it; > + > + i = 0; > + of_for_each_phandle(&it, err, node, "memory-region", NULL, 0) { > + ret = of_reserved_mem_device_init_by_idx(scp->dev, node, i); > + > + if (ret) { > + dev_err(scp->dev, "failed to assign memory-region: %s\n", > + it.node->name); > + of_node_put(it.node); > + return -ENOMEM; > + } With this patch the code is out of sync with the bindings which are still specifying a maxItems of 1 - please address. Thanks, Mathieu > > - ret = of_reserved_mem_device_init(scp->dev); > + i++; > + } > > /* reserved memory is optional. */ > - if (ret == -ENODEV) { > + if (!i) { > dev_info(scp->dev, "skipping reserved memory initialization."); > return 0; > } > > - if (ret) { > - dev_err(scp->dev, "failed to assign memory-region: %d\n", ret); > - return -ENOMEM; > - } > - > /* Reserved SCP code size */ > scp_sizes = scp->data->scp_sizes; > scp->cpu_addr = dma_alloc_coherent(scp->dev, scp_sizes->max_dram_size, > -- > 2.18.0 > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] remoteproc: mediatek: Support multiple reserved memory regions 2024-07-03 11:53 ` [PATCH 1/1] remoteproc: mediatek: " Shun-yi Wang 2024-07-10 15:56 ` Mathieu Poirier @ 2024-07-12 8:21 ` AngeloGioacchino Del Regno 1 sibling, 0 replies; 5+ messages in thread From: AngeloGioacchino Del Regno @ 2024-07-12 8:21 UTC (permalink / raw) To: Shun-yi Wang, Bjorn Andersson, Mathieu Poirier Cc: Matthias Brugger, linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, jason-ch.chen, yaya.chang, teddy.chen, olivia.wen Il 03/07/24 13:53, Shun-yi Wang ha scritto: > From: "shun-yi.wang" <shun-yi.wang@mediatek.com> > > SCP supports multiple reserved memory regions, intended for > specific hardwards. > > Signed-off-by: shun-yi.wang <shun-yi.wang@mediatek.com> > --- > drivers/remoteproc/mtk_scp.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 9ecd5ea04b5f3..1902826cea0af 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -1006,22 +1006,31 @@ EXPORT_SYMBOL_GPL(scp_mapping_dm_addr); > > static int scp_map_memory_region(struct mtk_scp *scp) > { > - int ret; > + int ret, i, err; > const struct mtk_scp_sizes_data *scp_sizes; > + struct device_node *node = scp->dev->of_node; > + struct of_phandle_iterator it; struct device_node *node = scp->dev->of_node; const struct mtk_scp_sizes_data *scp_sizes; struct of_phandle_iterator it; int i = 0; int ret; of_for_each_phandle(&it, ret, node, "memory-region", NULL, 0) { ret = ... if (ret) ..... i++; } > + > + i = 0; > + of_for_each_phandle(&it, err, node, "memory-region", NULL, 0) { > + ret = of_reserved_mem_device_init_by_idx(scp->dev, node, i); > + > + if (ret) { > + dev_err(scp->dev, "failed to assign memory-region: %s\n", > + it.node->name); > + of_node_put(it.node); > + return -ENOMEM; > + } > > - ret = of_reserved_mem_device_init(scp->dev); > + i++; > + } > > /* reserved memory is optional. */ > - if (ret == -ENODEV) { > + if (!i) { if (i == 0) { dev_dbg(scp->dev, "skipping reserved memory initialization\n"); return 0; } Regards, Angelo ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 0/1] Support multiple reserved memory regions 2024-07-03 11:53 [PATCH 0/1] Support multiple reserved memory regions Shun-yi Wang 2024-07-03 11:53 ` [PATCH 1/1] remoteproc: mediatek: " Shun-yi Wang @ 2024-07-10 15:54 ` Mathieu Poirier 1 sibling, 0 replies; 5+ messages in thread From: Mathieu Poirier @ 2024-07-10 15:54 UTC (permalink / raw) To: Shun-yi Wang Cc: Bjorn Andersson, Matthias Brugger, AngeloGioacchino Del Regno, linux-remoteproc, linux-kernel, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group, jason-ch.chen, yaya.chang, teddy.chen, olivia.wen Good morning, On Wed, Jul 03, 2024 at 07:53:07PM +0800, Shun-yi Wang wrote: > From: "shun-yi.wang" <shun-yi.wang@mediatek.com> > > Besides the reserved memory region for SCP, there are additional > reserved memory regions for specific hardware use. > Currently, only a single memory region is supported. > Modifications are made to support multiple memory regions. > This is the changelog that should be in the patch. Usually there is no need for a cover letter when there is a single patch in the set. > shun-yi.wang (1): > remoteproc: mediatek: support multiple reserved memory > > drivers/remoteproc/mtk_scp.c | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-) > > -- > 2.18.0 > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-07-12 8:21 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-07-03 11:53 [PATCH 0/1] Support multiple reserved memory regions Shun-yi Wang 2024-07-03 11:53 ` [PATCH 1/1] remoteproc: mediatek: " Shun-yi Wang 2024-07-10 15:56 ` Mathieu Poirier 2024-07-12 8:21 ` AngeloGioacchino Del Regno 2024-07-10 15:54 ` [PATCH 0/1] " Mathieu Poirier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).