From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84FFAC27C4F for ; Sat, 29 Jun 2024 21:01:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EGXkI7vXLSu2IKu/iP17W57e+TDQ8N+uwrxnq3TxCJU=; b=ga45vqQTbqjA8PB+FgvqJM1eoA ywge8060SgSXYthUyLINQCSBNV7id9ce2/g/M2kxFwucG0ZwXSnE7Znb+xxXGL11LIf5blq2BxzUt 5E0Pd37HWv5k4qVnr2cHgoQtGHGlLkFK32Cw2vxAp6Bj8C2YmvQhfQu8w1Lh/YGhqeRklaGHPxucw N/BVN9nHnSlEf5MNY8jolZMsEaR/eJFUX6C+oteeeT9n4f996XT0TEqhI6jzJOTxrJyg4931w4H1S bKgwJUyA7ho8tz13kMPq6AN1gMNVFdTeGvm4w/grYd+OuN9iRlOWycH4BHlPHlnFok88ta+0c1YRn xcOa5g+g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNfCL-0000000Gy3B-3HUT; Sat, 29 Jun 2024 21:01:29 +0000 Received: from out-185.mta0.migadu.com ([2001:41d0:1004:224b::b9]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sNfCB-0000000Gxyv-1LCY for linux-arm-kernel@lists.infradead.org; Sat, 29 Jun 2024 21:01:20 +0000 X-Envelope-To: kirby.nankivell@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1719694866; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EGXkI7vXLSu2IKu/iP17W57e+TDQ8N+uwrxnq3TxCJU=; b=d1/BenLKPRzjiJiyeEHxyM0gomWGKTbS9g+P7TGiymu9gL0Gp8hSY51/N/+Y8B3fopYQBf bfZ158ZDjsp2V4weY9yPgJNIEhD+iqoalvc5iUAkwo25AsTiKr5uywOLg+hZrjUEzmOSx1 4AMp0hb3vb2aI3l44VcEQ2Hai8oF6bDRwC8wwvmbPPaMrgF6gpsOmwcTxAmGbOSbqmDY0f Vo1DdHh7QTRTCnRGZTYB9Q1zWmJc7TRi9jagkN+uVCSeGnM6kHCmy+AHiwaHPTTfFtto8e j4Wh8SY2RaXUmoeb5auYdNQkpHFy3Hadt6AO9tGvQs6Eg7D5OagzHnuudaa7XQ== X-Envelope-To: jakobl.gm.g@gmail.com X-Envelope-To: linux-sunxi@lists.linux.dev X-Envelope-To: andre.przywara@arm.com X-Envelope-To: contact@paulk.fr X-Envelope-To: mripard@kernel.org X-Envelope-To: wens@csie.org X-Envelope-To: jernej.skrabec@gmail.com X-Envelope-To: maarten.lankhorst@linux.intel.com X-Envelope-To: tzimmermann@suse.de X-Envelope-To: airlied@gmail.com X-Envelope-To: daniel@ffwll.ch X-Envelope-To: samuel@sholland.org X-Envelope-To: dri-devel@lists.freedesktop.org X-Envelope-To: linux-arm-kernel@lists.infradead.org X-Envelope-To: linux-kernel@vger.kernel.org Date: Sun, 30 Jun 2024 06:58:17 +1000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Kirby Nankivell Cc: Jakob L , linux-sunxi@lists.linux.dev, andre.przywara@arm.com, Paul Kocialkowski , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Samuel Holland , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: T113 TCON Top tinting troubleshooting Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240629_140119_510605_C6216F7D X-CRM114-Status: GOOD ( 18.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Sat, Jun 29, 2024 at 12:14:39PM +1000, Kirby Nankivell wrote: > Tested this on a MangoPI-MQ-R with a RGB lcd and can confirm that this fix > removes the green tint I experienced. > > Disabling the mixer1 in DTS entirely also works. > > I suspect on the basis that the Mixer/TCON-TOP topology is identical to the > R40 but does not seem to experience this issue, that is a > silicon errata specific to the T113/D1s as far as we currently know. > > However, there is no functional reason from a drm perspective to require > more than one mixer tied to one output via tcon-top - unless someone has a > good argument here? > > in my opinion: > 1) implement this as a quirk on the t113 and fix mixer0 > rgb/dsi and > mixer1 > tv0 > 2) make this a global default for the sun8i tcon top driver where only one > mixer is initialised against an output (which would also impact the R40) The only reason I caught this issue was because I implemented LCD output in U-Boot and saw it looked a little better- I thought the tint was the backlight. Had you not contacted me and had it not affected the person I'm doing work for I would not have bothered looking in to this. It's entirely possible that the other supported devices have this issue, or that future ones will and nobody will notice. Going with a preventative approach here by fixing it for all potential devices and relying on the behaviour the sunxi code assumes rather than the datasheet says seems like the best approach to me. John.