From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99A83C2BD09 for ; Mon, 1 Jul 2024 14:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4iRQeefAgXsUamr4Ot8CeDDrfz8J0bienc8DMyyz7CU=; b=G4mGIDD2HRFVM8WFN0jmUe8f1g BZr9Aki2yzNXKi6EG6AO62OXu1NYB+6+52E0CCi0SZ7FIPaRiUgIdgY03BdDXp8OG+cBjfUQAiamT jN7WyxkRejPGlJgSg50RAZMHgH4jq9HTNAe1gOlMYcM0snnZk+3871XZ7SM8nxMrjpJkOHx6E8Wr3 IG+kOE0+tTsKkV2xeJtgbPK7QcehsrsGzIg3Sw15CAcK6klPaEBcxJQvFdoCsVNWFPDS5OihFRQs4 nT22jYGRVcerSGZCJoMI3uEZRPq85/7wVa6nXaMsXKzuGpb97SyjDxW32slovPp6G4FdqcnLGG328 1ykvZReQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOHrq-00000003hFK-0zfS; Mon, 01 Jul 2024 14:18:54 +0000 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOHre-00000003hAa-3Eww for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 14:18:44 +0000 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-4255f915611so89535e9.0 for ; Mon, 01 Jul 2024 07:18:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1719843521; x=1720448321; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4iRQeefAgXsUamr4Ot8CeDDrfz8J0bienc8DMyyz7CU=; b=NvticqIAGE23riGMSbkoxsC+GI5XJIlBEmxFI7Ypr6t8HhbEScEmMLcRZsuvp/ChDP ONmjdF24PN8pzyeu/MrCLxEIKp5JZPTVoER/YboJr5vvCT4gBZbnE7sBkhbdjLsCtODi itMp/Zbo88r6UdLmmW7TYwNQXiiFJ4+/B2Jfgr5MWPit9LrBmCb9AG9AplgX8a3Ws7M/ 23hbNiGS/GwEj3Wjo3MUL5moHwZP0fKIhBXQoLrgohxTVVr+us4QhyxjLkIBM+E+DFjw aitMseBA4FIwnwwJczi38ofROxi8eTRbSPSlANlQJ8lcrCCXCqvgPEHwU5NY57P2a7VS a6eQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719843521; x=1720448321; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4iRQeefAgXsUamr4Ot8CeDDrfz8J0bienc8DMyyz7CU=; b=iUUGzLmcCG/56ZCnlUv6PMOuSuMXZ84Nnatxbr37p39qDQXtZ/l+pvKIvrWXLOx8cO OwxRF766f64VDY2ZBBL3ey80oT7/lvAqN6kjEmc6oJrjS59A0sA8l+Lgs32nFiU2jIhU EL2misib9e0GSTTYcFdhJ3bbOHLD7Q9xbraecuuzhu/oHbfuBIBLTALtv7lM1IV+qUH9 GWZYPPlaPNUEKSt/rjQxKED+hcve2GTleIWoWVWQ78JOHUKG5nveTdZI8K5nlLlCiD4s 4Oscuu6OCxwaqHHXIGen5HmcDxu4B9WqycA2CV5mst6q/kMsP2IYbgJOPT+RYeEIHnMB ll/g== X-Forwarded-Encrypted: i=1; AJvYcCV/oPOOH6O+luLaqT1DoUAum7sF3BjpTrzErAk4YfsdSZl6Z144vJ2hk7wU8gDf7a6627iq1yBErtqLmHmWXxjgKgetvhKjE/Tz3MZ70393XvS7Jn8= X-Gm-Message-State: AOJu0YxCTOVjguj8MoXjyAKgaNwv8cGwh1AywgM1dN/8uNodPYnoTUXt 8RTcy3Yr/hVWcdHwsnREjoR1zOyEEjNRgjbmviYfcAktcjheK1wBL8m8oTf/ew== X-Google-Smtp-Source: AGHT+IEJSpUxXnzmaKpeXZ9ZNc9ay9XiJ8uD9AmMNUm7TYpCOsXMWXwD4qP0QOho6uCBNDDg/b3sMA== X-Received: by 2002:a05:600c:35c5:b0:424:8b0c:156a with SMTP id 5b1f17b1804b1-425777d21e6mr3583315e9.2.1719843521026; Mon, 01 Jul 2024 07:18:41 -0700 (PDT) Received: from google.com (216.131.76.34.bc.googleusercontent.com. [34.76.131.216]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4256af54ecasm154237255e9.12.2024.07.01.07.18.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jul 2024 07:18:40 -0700 (PDT) Date: Mon, 1 Jul 2024 14:18:39 +0000 From: Sebastian Ene To: Vincent Donnefort Cc: akpm@linux-foundation.org, alexghiti@rivosinc.com, ankita@nvidia.com, ardb@kernel.org, catalin.marinas@arm.com, christophe.leroy@csgroup.eu, james.morse@arm.com, mark.rutland@arm.com, maz@kernel.org, oliver.upton@linux.dev, rananta@google.com, ryan.roberts@arm.com, shahuang@redhat.com, suzuki.poulose@arm.com, will@kernel.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v7 5/6] KVM: arm64: Initialize the ptdump parser with stage-2 attributes Message-ID: References: <20240621123230.1085265-1-sebastianene@google.com> <20240621123230.1085265-6-sebastianene@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_071842_835295_68051F97 X-CRM114-Status: GOOD ( 24.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 09:42:43AM +0100, Vincent Donnefort wrote: > O Fri, Jun 21, 2024 at 12:32:29PM +0000, 'Sebastian Ene' via kernel-team wrote: > > Define a set of attributes used by the ptdump parser to display the > > properties of a guest memory region covered by a pagetable descriptor. > > Build a description of the pagetable levels and initialize the parser > > with this configuration. > > > > Signed-off-by: Sebastian Ene > > --- > > arch/arm64/kvm/ptdump.c | 143 ++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 137 insertions(+), 6 deletions(-) > > > > diff --git a/arch/arm64/kvm/ptdump.c b/arch/arm64/kvm/ptdump.c > > index 36dc7662729f..cc1d4fdddc6e 100644 > > --- a/arch/arm64/kvm/ptdump.c > > +++ b/arch/arm64/kvm/ptdump.c > > @@ -14,6 +14,61 @@ > > #include > > > > > > +#define MARKERS_LEN (2) > > +#define KVM_PGTABLE_MAX_LEVELS (KVM_PGTABLE_LAST_LEVEL + 1) > > + > > +struct kvm_ptdump_guest_state { > > + struct kvm *kvm; > > + struct pg_state parser_state; > > + struct addr_marker ipa_marker[MARKERS_LEN]; > > + struct pg_level level[KVM_PGTABLE_MAX_LEVELS]; > > + struct ptdump_range range[MARKERS_LEN]; > > +}; > > + > > +static const struct prot_bits stage2_pte_bits[] = { > > + { > > + .mask = PTE_VALID, > > + .val = PTE_VALID, > > + .set = " ", > > + .clear = "F", > > + }, { > > + .mask = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > + .val = KVM_PTE_LEAF_ATTR_HI_S2_XN | PTE_VALID, > > + .set = "XN", > > + .clear = " ", > > + }, { > > + .mask = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > + .val = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_R | PTE_VALID, > > + .set = "R", > > + .clear = " ", > > + }, { > > + .mask = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W | PTE_VALID, > > + .val = KVM_PTE_LEAF_ATTR_LO_S2_S2AP_W | PTE_VALID, > > + .set = "W", > > + .clear = " ", > > + }, { > > + .mask = KVM_PTE_LEAF_ATTR_LO_S2_AF | PTE_VALID, > > + .val = KVM_PTE_LEAF_ATTR_LO_S2_AF | PTE_VALID, > > + .set = "AF", > > + .clear = " ", > > + }, { > > + .mask = PTE_NG, > > + .val = PTE_NG, > > + .set = "FnXS", > > + .clear = " ", > > + }, { > > + .mask = PTE_CONT | PTE_VALID, > > + .val = PTE_CONT | PTE_VALID, > > + .set = "CON", > > + .clear = " ", > > + }, { > > + .mask = PTE_TABLE_BIT, > > > > + .val = PTE_TABLE_BIT, > > + .set = " ", > > + .clear = "BLK", > > + }, Hello Vincent, > > When doing a kvm_pgtable_stage2_set_owner(), the walker will init a leaf which > has both the table-bit and the valid-bit unset. I believe this would lead to > spurious BLK annotations here. > > The following should fix this problem: > > .mask = PTE_TABLE_BIT | PTE_VALID, > .val = PTE_VALID, > .set = "BLK", > .clear = " ", > Let me try this, thanks for the suggestion ! > > +}; > > + > > static int kvm_ptdump_visitor(const struct kvm_pgtable_visit_ctx *ctx, > > enum kvm_pgtable_walk_flags visit) > > { > > @@ -40,15 +95,79 @@ static int kvm_ptdump_show_common(struct seq_file *m, > > return kvm_pgtable_walk(pgtable, 0, BIT(pgtable->ia_bits), &walker); > > } > > > > [...] Seb