linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Cristian Marussi <cristian.marussi@arm.com>
To: Luke Parkin <luke.parkin@arm.com>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org,
	sudeep.holla@arm.com, cristian.marussi@arm.com
Subject: Re: [PATCH 0/3] Add Per-transport SCMI debug statistics
Date: Mon, 1 Jul 2024 16:20:52 +0100	[thread overview]
Message-ID: <ZoLJVKqx0erHdmyl@pluto> (raw)
In-Reply-To: <20240701142851.1448515-1-luke.parkin@arm.com>

On Mon, Jul 01, 2024 at 03:28:48PM +0100, Luke Parkin wrote:
> Hi,
> 

Hi Luke,

thanks for taking a shot at this, a few comments down below and along
this series.

> This series adds support for tracking Arm SCMI statistics, [Patch 2]
> A config option to enable this, [Patch 1] 
> And in [Patch 3] a selection of new debugfs entries to present these statistics
> 
> These statistics are per transport instance, and will be a helpful resource when
> debugging the SCMI and running tests.
> 
> Based on v6.9, Tested on Arm Juno [1]
> 

First of all a nitpick on commit messages themselves...when posting patches on a specific
subsystem, the commit message "style" should align with the subsystem conventions:
IOW all the patches in your series (beside this cover-letter) should be titled as:

  firmware: arm_scmi: My patch starting with a capital letter

as you can guess having a look at git log --oneline drivers/firmware/arm_scmi

So please do this in V2 together with other reviews.

Thanks,
Cristian


  parent reply	other threads:[~2024-07-01 15:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 14:28 [PATCH 0/3] Add Per-transport SCMI debug statistics Luke Parkin
2024-07-01 14:28 ` [PATCH 1/3] Add Kconfig option for scmi " Luke Parkin
2024-07-01 15:32   ` Cristian Marussi
2024-07-01 14:28 ` [PATCH 2/3] Track basic SCMI statistics Luke Parkin
2024-07-01 16:15   ` Cristian Marussi
2024-07-02  9:57     ` Luke Parkin
2024-07-02 11:10       ` Cristian Marussi
2024-07-02 12:50         ` Luke Parkin
2024-07-01 14:28 ` [PATCH 3/3] Create debugfs files for statistics Luke Parkin
2024-07-01 16:19   ` Cristian Marussi
2024-07-01 15:20 ` Cristian Marussi [this message]
2024-07-01 16:21 ` [PATCH 0/3] Add Per-transport SCMI debug statistics Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZoLJVKqx0erHdmyl@pluto \
    --to=cristian.marussi@arm.com \
    --cc=arm-scmi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke.parkin@arm.com \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).