From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49E3CC41513 for ; Mon, 1 Jul 2024 15:21:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=EVfWsfvyxaiBhuGyhedJaqciMer/Q02Kt7u11AmXeCM=; b=a6A1xwcchBdY4Sc953OKFBcLJx 8iQvPereN2Qmwijtm1KJMDvPL7gEvn3EnxeLO43fG9IgAcp6ePseB5ul2WRi7Vz7LS0w3k6FsD6WH FffFAqDMgk9gWCJDaa62zWHXrxsETOi2pfE5/YuT0B21/NkIo/m9oIR7+CG1zC9sQuwaRePPn+7N4 1+yzedrmqKjMpdoW9qVPztijQJ1G8+PQofQfsBzyX1YKbU/zqL9Gi9TQS/Nfmaay5Tq8DZ6LXohW6 b4pN0WbNaX2gqoe8M33KBUTMwh7DKf7i7Tuj1e0r8xistmnz2o8GxSLlCd+XwfLGwkiyr3LSN8nVH B9o16MZw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOIq5-00000003v8z-1BHJ; Mon, 01 Jul 2024 15:21:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOIpu-00000003v5f-0JNV for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 15:20:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B4FC339; Mon, 1 Jul 2024 08:21:20 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id ADD903F73B; Mon, 1 Jul 2024 08:20:54 -0700 (PDT) Date: Mon, 1 Jul 2024 16:20:52 +0100 From: Cristian Marussi To: Luke Parkin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Subject: Re: [PATCH 0/3] Add Per-transport SCMI debug statistics Message-ID: References: <20240701142851.1448515-1-luke.parkin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701142851.1448515-1-luke.parkin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_082058_181166_B95A4CC8 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 03:28:48PM +0100, Luke Parkin wrote: > Hi, > Hi Luke, thanks for taking a shot at this, a few comments down below and along this series. > This series adds support for tracking Arm SCMI statistics, [Patch 2] > A config option to enable this, [Patch 1] > And in [Patch 3] a selection of new debugfs entries to present these statistics > > These statistics are per transport instance, and will be a helpful resource when > debugging the SCMI and running tests. > > Based on v6.9, Tested on Arm Juno [1] > First of all a nitpick on commit messages themselves...when posting patches on a specific subsystem, the commit message "style" should align with the subsystem conventions: IOW all the patches in your series (beside this cover-letter) should be titled as: firmware: arm_scmi: My patch starting with a capital letter as you can guess having a look at git log --oneline drivers/firmware/arm_scmi So please do this in V2 together with other reviews. Thanks, Cristian