From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6E09C3065B for ; Mon, 1 Jul 2024 16:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZkMH7C1GfQXguN/QwWLxYUs2ZiqBOhl64fReFeWVTVc=; b=sBYH+V1/9lgeWzzj8DSw3zKmGb Hy7ADY84Oa8Xa4l4XvCXenef/D8TlIwmJ6wc0KPD3kJlbGyFU7Ryxx3cE/vxajYecTbatTnAH+CLl xRbEtr+CJ8sZ/Xqu37QrCWrOMv7kPoDNWNFQZfF7z7Lw8dOtsiO0q05KfWddhLfEW+u3LxxLlKS2Y ZuuoZM0CIqieztENMVoPRXLt00bb4tU5RzvBXvLbPpTpS0tHCnoQviGCstV4+wFGqKyFgXNTc9UxI eMvhaGPrMczDOfaAyZi3G7cTkDYsnVfOy6R/4jFvfOhElfMPxCKYRwPwOyNi7vTJAfhuLB1A8503U ziu4l4+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOJlG-000000045F5-2CZ4; Mon, 01 Jul 2024 16:20:14 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOJl4-000000045BV-2hAE for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 16:20:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 98276339; Mon, 1 Jul 2024 09:20:26 -0700 (PDT) Received: from pluto (usa-sjc-mx-foss1.foss.arm.com [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id BD81E3F73B; Mon, 1 Jul 2024 09:20:00 -0700 (PDT) Date: Mon, 1 Jul 2024 17:19:58 +0100 From: Cristian Marussi To: Luke Parkin Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org, sudeep.holla@arm.com, cristian.marussi@arm.com Subject: Re: [PATCH 3/3] Create debugfs files for statistics Message-ID: References: <20240701142851.1448515-1-luke.parkin@arm.com> <20240701142851.1448515-4-luke.parkin@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240701142851.1448515-4-luke.parkin@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_092003_281942_FE1A6BE9 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 03:28:51PM +0100, Luke Parkin wrote: > Create debugfs files for the statistics in the scmi_debug_stats struct > > Signed-off-by: Luke Parkin > --- > drivers/firmware/arm_scmi/driver.c | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c > index f69dff699d48..509ea42d17bf 100644 > --- a/drivers/firmware/arm_scmi/driver.c > +++ b/drivers/firmware/arm_scmi/driver.c > @@ -2884,7 +2884,7 @@ static void scmi_debugfs_common_cleanup(void *d) > static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) > { > char top_dir[16]; > - struct dentry *trans, *top_dentry; > + struct dentry *trans, *top_dentry, *stats; stats are conditional...so... > struct scmi_debug_info *dbg; > const char *c_ptr = NULL; > > @@ -2935,6 +2935,19 @@ static struct scmi_debug_info *scmi_debugfs_common_setup(struct scmi_info *info) > debugfs_create_u32("rx_max_msg", 0400, trans, > (u32 *)&info->rx_minfo.max_msg); > > + if (IS_ENABLED(CONFIG_ARM_SCMI_DEBUG_STATISTICS)) { > + stats = debugfs_create_dir("stats", trans); you can put the above local *stats var instead so that it is NOT even defined when STATS=n > + debugfs_create_atomic_t("response_ok", 0400, stats, > + &info->stats.response_ok); > + debugfs_create_atomic_t("dlyd_response_ok", 0400, stats, > + &info->stats.dlyd_response_ok); > + debugfs_create_atomic_t("sent_ok", 0400, stats, > + &info->stats.sent_ok); > + debugfs_create_atomic_t("sent_fail", 0400, stats, > + &info->stats.sent_fail); > + debugfs_create_atomic_t("xfers_response_timeout", 0400, stats, > + &info->stats.xfers_response_timeout); > + } ... moreover...this is not always enabled BUT certainly will be extend sooner with more counters...so please split this setup out in a local helper function. Thanks, Cristian