From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30651C2BD09 for ; Mon, 1 Jul 2024 23:23:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UD5vgVxwOlRZOz1Xq5UgrytqB41yQecb8+27k5DyQes=; b=OKBOZp6mtGmS1WE2IuskouIT78 QEv3x5d/IGz+N2b70A0PpzU0td6R9zLWMmHUDgEnbSnBn1FvYxkXlZImgsMgkdXunm2/9kljWiOyM AtVhjZYX4ryGNAQ5rjM7ZI7v2nL4a3m+uZLcPfESu77vSUpueC3wBlFrzhzzI6keiSXE62T35CpHl 9AFYC4KpLkqzIWB9DsLEoI56ddoNUItM5hCY9TjcIQSvaiEJI7ilbv5vbL3h3UbrS6JFdKWdqa9rq UcyeGJ+wnnrXwetD4geuPePiRTjxn8YPaGQhAjzx3uEUjaewbTCFOhiBjGKvVt7uakWXN4GjK/MEh cVgS5O+A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOQMZ-000000054fU-18Vq; Mon, 01 Jul 2024 23:23:11 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOQMN-000000054Rj-3EBr for linux-arm-kernel@lists.infradead.org; Mon, 01 Jul 2024 23:23:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=UD5vgVxwOlRZOz1Xq5UgrytqB41yQecb8+27k5DyQes=; b=z1rLnE70q6Z36BN3bEbxJ19yCo CntK0uNP1+NNBD8RTxDVUv2g4JJiZ6W9FDidKiDbwqp9GOPYvdK8rz+Ts5z+ndQuRLUaHK+kC6L8H 1VTiDRqGHlSLUkD7hbmMP6GfUdolrpoqKby0CDVnLcGeCWy3gW0d8g1DW7vIW4mcbqfNoMR5MUTIM kpsYQhlwnZJlrB8Iu0eyPLHOgMoQOl6bJqMruLboljNi7XIrlMi9ON7FAF0tgPxrhma0QtjTUY4MY GirAChlAiFCXaXd2tLE2JwaPc2/qd52u4mcO7OkctdM/S8Lr/26or1IDJPSqtFYXzdn3fHPxHaoQA Qn2iCjaQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:51196) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sOQK7-0002bu-0y; Tue, 02 Jul 2024 00:20:39 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1sOQK7-0001NR-PA; Tue, 02 Jul 2024 00:20:39 +0100 Date: Tue, 2 Jul 2024 00:20:39 +0100 From: "Russell King (Oracle)" To: Kees Cook Cc: Linux regressions mailing list , Yanjun Yang , linux-arm-kernel@lists.infradead.org, Mark Brown , Ard Biesheuvel , akpm@linux-foundation.org, ben@decadent.org.uk, Wang Kefeng Subject: Re: [PATCH] ARM: Remove address checking for MMUless devices Message-ID: References: <20240611100947.32241-1-yangyj.ee@gmail.com> <6767f6e1-f7b7-4b3e-8173-32f1472f56d6@leemhuis.info> <202407011216.E1DCF4BF@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202407011216.E1DCF4BF@keescook> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240701_162259_827408_954B78FF X-CRM114-Status: GOOD ( 19.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jul 01, 2024 at 12:17:10PM -0700, Kees Cook wrote: > On Mon, Jul 01, 2024 at 01:54:21PM +0200, Linux regression tracking (Thorsten Leemhuis) wrote: > > On 12.06.24 03:25, Yanjun Yang wrote: > > > Apologies for not CCing the relevant maintainers in my previous email. > > > > > > On Tue, Jun 11, 2024 at 6:09 PM Yanjun Yang wrote: > > >> > > >> Commit 169f9102f9198b ("ARM: 9350/1: fault: > > >> Implement copy_from_kernel_nofault_allowed()") added the function to check > > >> address before use. However, for devices without MMU, addr > TASK_SIZE > > >> will always fail. This patch move this function after the #ifdef > > >> CONFIG_MMU statement. > > > > What happened to this fix regression for a 6.9 regression? From here it > > looks like it fell through the cracks, but I might be missing something. > > This patch can be sent through rmk's ARM patch tracker, but if it's > urgent, I could take it via my tree? It has Ard's Ack. I've been so busy with a high priority work issue that I've not been aware of this email thread until I saw it tonight (because I haven't been able to read much email!) -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!