From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B403AC30658 for ; Tue, 2 Jul 2024 13:33:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MOkvdQtYmcqAXVFGO+c6RVoHQeZLdjxmxpP1HWTNTBU=; b=3EYDqUp1OK4itgDNcHH3RbxZXu YlJqmLBniXhjTz0ZxRxjZ87e1IHKd1KuLMaREkykyEidfS3nRcFVuizrB3+8qjsQX0kMWrDW6TLJV EMoiXSN/rMrnpYka6YIfc73PnmLjLmgboBW28uGVCjoa5IHR2Cbp4ptjdHL5GuYjU85gO0kHm39cl jyOCYibOlCP8muJUXZLE+XgiqKwHC8Jd0sYLmgWQk3/cqpEk9Div1J0FIjZVKHF8q4OwtZCyg8E2/ uSleekp2pZ2aClnHHOqJ3SzvuqAtl03P6cJ11bwgNdho8QDIZSAcq63vrP/BhPW2zVZV5SYubp750 pfWbU+cw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOddL-00000006rxG-2c8P; Tue, 02 Jul 2024 13:33:23 +0000 Received: from mail-ej1-f54.google.com ([209.85.218.54]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOdd7-00000006ruM-1ofY for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 13:33:13 +0000 Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a725282b926so472339166b.0 for ; Tue, 02 Jul 2024 06:33:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719927185; x=1720531985; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MOkvdQtYmcqAXVFGO+c6RVoHQeZLdjxmxpP1HWTNTBU=; b=w4y9FdwEfqRaMjqkE4nJQsDGWwjGAQm+NGGiVi+/jyxBL7t1RtRB3Wa/XWhfkyE0kf jWeEcRPLVlDoLv2ppqVs9s59YpDqA/eVZwaFwlfboAFB+6UmZJ0LdVOnnXqmnJfQ4weV Pu6idv0fI7Jkniu2jWNzVaxThQsX8YLQQPaGc5uMLpzKvxD0TEN2p0S4qI2/1wgUbMQt 3NGVCoo+oSHeGYyRUCcNqA1BFnCIDjCtdGmEj/qw016FBxEguHF3sVf9kn8Ia3nFoK8b LWLOEU4skWUpXHXkGnsPEDLxepu5+Z7mzjxLokonbVx7Sbzq2+6ejN1gkWxDg1u9X85u QXEA== X-Forwarded-Encrypted: i=1; AJvYcCXRp+J0oKArgldz1Ni3CMPE4GVlaku+14g7Gird6ufCcVmnI7lSFhUCGAUxMtB/Zd0TEq9QjgYKAwVXRVAHueMGUSh1tCs3lll22vqO9xuOmPiCM6U= X-Gm-Message-State: AOJu0Yw4tzmc3rRnKPJWqjCYLv/l+TWdhAQ+EfiRuieFgg7Dt+fB8o0L 0NvyG6fNVkDvvy0oCaxJ6I7vWExKdSiTWj52RIa3CWtnhujtb10w X-Google-Smtp-Source: AGHT+IFMraYu2aPoIooLadmuA03EaJnzyv4zAh2e17tIjIYQudbaWZBo6EOFt7y8sosj3E7OdYQHRQ== X-Received: by 2002:a17:906:ca41:b0:a6f:5c1a:c9a6 with SMTP id a640c23a62f3a-a7514441505mr563250166b.62.1719927185331; Tue, 02 Jul 2024 06:33:05 -0700 (PDT) Received: from gmail.com (fwdproxy-lla-005.fbsv.net. [2a03:2880:30ff:5::face:b00c]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a72ab0b84e0sm423799466b.210.2024.07.02.06.33.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 06:33:04 -0700 (PDT) Date: Tue, 2 Jul 2024 06:32:37 -0700 From: Breno Leitao To: Simon Horman Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, Horia =?utf-8?Q?Geant=C4=83?= , Pankaj Gupta , Gaurav Jain , Herbert Xu , "David S. Miller" Subject: Re: [PATCH 3/4] crypto: caam: Unembed net_dev structure from qi Message-ID: References: <20240624162128.1665620-1-leitao@debian.org> <20240624162128.1665620-3-leitao@debian.org> <20240628163226.GJ783093@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240628163226.GJ783093@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_063310_204107_E58FC4B4 X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Simon, On Fri, Jun 28, 2024 at 05:32:26PM +0100, Simon Horman wrote: > On Mon, Jun 24, 2024 at 09:21:21AM -0700, Breno Leitao wrote: > > @@ -530,6 +530,7 @@ static void caam_qi_shutdown(void *data) > > > > if (kill_fq(qidev, per_cpu(pcpu_qipriv.rsp_fq, i))) > > dev_err(qidev, "Rsp FQ kill failed, cpu: %d\n", i); > > + free_netdev(pcpu_qipriv.net_dev); > Hi Breno, > > I don't think you can access pcpu_qipriv.net_dev like this, > as pcpu_qipriv is a per-cpu variable. Perhaps this? > > free_netdev(per_cpu(pcpu_qipriv.net_dev, i)); You are absolutely correct. Let me fix it. > Flagged by Sparse. Thanks. I've just added sparse to my development workflow, and I can see it also: drivers/crypto/caam/qi.c:533:29: warning: dereference of noderef expression Thanks for the review. I will send an updated version. --breno