From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2898C3065C for ; Tue, 2 Jul 2024 16:45:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Phw++KCNea16DU8eOTMmV36Mdb5a7m8SacK5PGBp32U=; b=n/YgPPPdvnT9pJw5x9mBdrw8NA 7z6OdGd1tOxMjr2tT8nmCxGhm1ANShwYRu0NCpPynsgr9n1k/IU2H8z3YXN5hMhubrYEuUaaDkHHx FEzYsZDglq1EFnIvGkmPrX2tYxpn9gnflfFPdoEx8IhqbZUtfK2T1GUzLnRFc0QBUkYfc3T4jHFps K3+Fkcu5pAI70ohjLmu14u8qGDCc20gQC2xqfV7DEXfS7oPlTImW7Q1WQftGgBds+nxHX0umzUOYd 2r5q8C23igp8V0dpzcIbVEgyNwiAnObGht6a+N8mXUO89Ax7I2+cw1m4S2x7r3SwVQeRw693DQL6v 1knx7IdQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOgd6-00000007QQq-3sgJ; Tue, 02 Jul 2024 16:45:20 +0000 Received: from mail-pg1-x52b.google.com ([2607:f8b0:4864:20::52b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sOgcd-00000007QAj-367n for linux-arm-kernel@lists.infradead.org; Tue, 02 Jul 2024 16:44:53 +0000 Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-70df213542bso2395323a12.3 for ; Tue, 02 Jul 2024 09:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719938691; x=1720543491; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Phw++KCNea16DU8eOTMmV36Mdb5a7m8SacK5PGBp32U=; b=RLkSh57yL68cnOQmR16jYsK7Br+IqFIe+HFvBP9p5mKsnPulmNm9miQJSSzpbo6tbC jKkNmTFdLK9uEPbJFPaD7qO7bFz4Sc4To5MuI/bIGwyYrwZNbGSnqM4Omvv+aqO1bHhX M65m8RJHW/7ObSypyinab1+n0Uzv16cPufpNDE0Djvn3/eb6tcp2FFh3oeRCsXoiDI7E rLXZELMP3Xr52ESewWNlhSHgtABS04PmgjDnWL5sWPNZvUAoia6F+6y1UdDbOIb2o/VI 7vWtRFjCJaRk4Y3AxV8wqt3PWzs8uQAcgcKb8rDJCx1JZ7uCc+C9nwguDPUfON8vcWlc ylnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719938691; x=1720543491; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Phw++KCNea16DU8eOTMmV36Mdb5a7m8SacK5PGBp32U=; b=gYuEDxB7xPFgukn3UvifDYbHxULBbozN3mtBiuwCntb9blx9Bk4jlfGNWjFoZY/SUr wRqC2LmTSXEJGhMHDpzTLLXIWywBpOMqMZRIIMBZrgmgT5pu+rEwNo4sgHXwk14oxikx 9xMNr862ANsCCWP+zOmBfsEvph6dpKfzZTKtSQXli5ng4p7XSmaDqLQTkIxGjff2nuGc tGhEs6AV5xGbeerKtswZnP55LYfrBgoWhl1aXrEW9kFUd5upYvSRnT9W7plgNEdTIlIG x/VOfODn+rWBvLfdvMYOEAciD20FN8/cwfr6ZLawpur6i7P2gk/Fec344Q36itPwrqyp Jweg== X-Forwarded-Encrypted: i=1; AJvYcCVocs3bN7RqCfWzB4J2v1+8zxvDzsABOJk3gj9/miNOoZkDy/HJxjYzCKR+CwWFj6ZVzHjbsSUHYiKWfMBT6MUlTZyE9h+H4rD1KyzoFJzidnHkG/s= X-Gm-Message-State: AOJu0Yz9Nu2i9utgAMgaUpdZe96apUMo8iG/2oOZLdUUrfJtqj6Pra9K mxFAd57CCS97hShWKPboRM3rMhFjNdjKvBj1kVr76dQeVMU/Qo1OQXtII0j2XPU= X-Google-Smtp-Source: AGHT+IEwftAV+W5epvlPenld+i4k1K8ts6v6lErfwD0yVJfMBJDDLudodQFJyGkNq/gL/ZnZMvMS1A== X-Received: by 2002:a05:6a20:c992:b0:1bd:91b0:10a5 with SMTP id adf61e73a8af0-1bef6248467mr7426144637.47.1719938690225; Tue, 02 Jul 2024 09:44:50 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:a83c:9cd1:70fd:d18a]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-708029582d5sm8709470b3a.89.2024.07.02.09.44.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jul 2024 09:44:49 -0700 (PDT) Date: Tue, 2 Jul 2024 10:44:46 -0600 From: Mathieu Poirier To: Arnaud Pouliquen Cc: Bjorn Andersson , Jens Wiklander , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org, devicetree@vger.kernel.org Subject: Re: [PATCH v8 5/5] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware Message-ID: References: <20240621143759.547793-1-arnaud.pouliquen@foss.st.com> <20240621143759.547793-6-arnaud.pouliquen@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240621143759.547793-6-arnaud.pouliquen@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240702_094451_811357_CF4BEEDE X-CRM114-Status: GOOD ( 28.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 21, 2024 at 04:37:59PM +0200, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a Device or driver? > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution context. In such cases, the firmware should be signed and > adhere to the image format defined by the TEE. > > Signed-off-by: Arnaud Pouliquen > --- > drivers/remoteproc/stm32_rproc.c | 63 ++++++++++++++++++++++++++++++-- > 1 file changed, 60 insertions(+), 3 deletions(-) > > diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c > index 8cd838df4e92..fd905b3cf206 100644 > --- a/drivers/remoteproc/stm32_rproc.c > +++ b/drivers/remoteproc/stm32_rproc.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -257,6 +258,19 @@ static int stm32_rproc_release(struct rproc *rproc) > return 0; > } > > +static int stm32_rproc_tee_stop(struct rproc *rproc) > +{ > + int err; > + > + stm32_rproc_request_shutdown(rproc); > + > + err = tee_rproc_stop(rproc); > + if (err) > + return err; > + > + return stm32_rproc_release(rproc); > +} > + > static int stm32_rproc_prepare(struct rproc *rproc) > { > struct device *dev = rproc->dev.parent; > @@ -693,8 +707,20 @@ static const struct rproc_ops st_rproc_ops = { > .get_boot_addr = rproc_elf_get_boot_addr, > }; > > +static const struct rproc_ops st_rproc_tee_ops = { > + .prepare = stm32_rproc_prepare, > + .start = tee_rproc_start, > + .stop = stm32_rproc_tee_stop, > + .kick = stm32_rproc_kick, > + .load = tee_rproc_load_fw, > + .parse_fw = tee_rproc_parse_fw, > + .find_loaded_rsc_table = tee_rproc_find_loaded_rsc_table, > + > +}; > + > static const struct of_device_id stm32_rproc_match[] = { > { .compatible = "st,stm32mp1-m4" }, > + { .compatible = "st,stm32mp1-m4-tee" }, > {}, > }; > MODULE_DEVICE_TABLE(of, stm32_rproc_match); > @@ -853,17 +879,42 @@ static int stm32_rproc_probe(struct platform_device *pdev) > struct device *dev = &pdev->dev; > struct stm32_rproc *ddata; > struct device_node *np = dev->of_node; > + struct tee_rproc *trproc = NULL; > struct rproc *rproc; > unsigned int state; > + u32 proc_id; > int ret; > > ret = dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(32)); > if (ret) > return ret; > > - rproc = devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > - if (!rproc) > - return -ENOMEM; > + if (of_device_is_compatible(np, "st,stm32mp1-m4-tee")) { > + /* > + * Delegate the firmware management to the secure context. > + * The firmware loaded has to be signed. > + */ > + ret = of_property_read_u32(np, "st,proc-id", &proc_id); > + if (ret) { > + dev_err(dev, "failed to read st,rproc-id property\n"); > + return ret; > + } > + > + rproc = devm_rproc_alloc(dev, np->name, &st_rproc_tee_ops, NULL, sizeof(*ddata)); > + if (!rproc) > + return -ENOMEM; > + > + trproc = tee_rproc_register(dev, rproc, proc_id); > + if (IS_ERR(trproc)) { > + dev_err_probe(dev, PTR_ERR(trproc), > + "signed firmware not supported by TEE\n"); > + return PTR_ERR(trproc); > + } > + } else { > + rproc = devm_rproc_alloc(dev, np->name, &st_rproc_ops, NULL, sizeof(*ddata)); > + if (!rproc) > + return -ENOMEM; > + } > > ddata = rproc->priv; > > @@ -915,6 +966,9 @@ static int stm32_rproc_probe(struct platform_device *pdev) > dev_pm_clear_wake_irq(dev); > device_init_wakeup(dev, false); > } > + if (trproc) > + tee_rproc_unregister(trproc); > + > return ret; > } > > @@ -935,6 +989,9 @@ static void stm32_rproc_remove(struct platform_device *pdev) > dev_pm_clear_wake_irq(dev); > device_init_wakeup(dev, false); > } > + if (rproc->tee_interface) > + tee_rproc_unregister(rproc->tee_interface); > + > } > > static int stm32_rproc_suspend(struct device *dev) > -- > 2.25.1 >