From: Sudeep Holla <sudeep.holla@arm.com>
To: Sibi Sankar <quic_sibis@quicinc.com>
Cc: <ulf.hansson@linaro.org>, <cristian.marussi@arm.com>,
<linux-kernel@vger.kernel.org>, <arm-scmi@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <linux-pm@vger.kernel.org>,
<quic_rgottimu@quicinc.com>, <quic_kshivnan@quicinc.com>,
Sudeep Holla <sudeep.holla@arm.com>, <johan@kernel.org>
Subject: Re: [PATCH] pmdomain: arm: Fix debugfs node creation failure
Date: Thu, 4 Jul 2024 11:32:30 +0100 [thread overview]
Message-ID: <ZoZ6Pk7NSUNDB74i@bogus> (raw)
In-Reply-To: <20240703110741.2668800-1-quic_sibis@quicinc.com>
On Wed, Jul 03, 2024 at 04:37:41PM +0530, Sibi Sankar wrote:
> The domain attributes returned by the perf protocol can end up
> reporting identical names across domains, resulting in debugfs
> node creation failure. Fix this duplication by appending the
> domain-id to the domain name.
>
> Logs:
> debugfs: Directory 'NCC' with parent 'pm_genpd' already present!
> debugfs: Directory 'NCC' with parent 'pm_genpd' already present!
>
If there are 2 perf domains for a device or group of devices, there must
be something unique about each of these domains. Why can't the firmware
specify the uniqueness or the difference via the name?
The example above seems firmware is being just lazy to update it. Also
for the user/developer/debugger, the unique name might be more useful
than just this number.
So please use the name(we must now have extended name if 16bytes are less)
to provide unique names. Please stop working around such silly firmware
bugs like this, it just makes using debugfs for anything useful harder.
--
Regards,
Sudeep
next prev parent reply other threads:[~2024-07-04 10:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 11:07 [PATCH] pmdomain: arm: Fix debugfs node creation failure Sibi Sankar
2024-07-04 10:32 ` Sudeep Holla [this message]
2024-07-05 3:46 ` Sibi Sankar
2024-07-05 13:04 ` Sudeep Holla
2024-07-08 10:07 ` Sibi Sankar
2024-08-07 0:51 ` Peng Fan
2024-08-14 12:38 ` Ulf Hansson
2024-08-14 13:31 ` Sudeep Holla
2024-08-15 10:46 ` Ulf Hansson
2024-08-15 13:46 ` Sudeep Holla
2024-10-07 7:08 ` Sibi Sankar
2024-09-04 7:21 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZoZ6Pk7NSUNDB74i@bogus \
--to=sudeep.holla@arm.com \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=johan@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quic_kshivnan@quicinc.com \
--cc=quic_rgottimu@quicinc.com \
--cc=quic_sibis@quicinc.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).